add experimental warning for multinode clusters

pull/7934/head
Sharif Elgamal 2020-04-29 10:14:50 -07:00
parent 135a32f5f1
commit d09ae65cd9
3 changed files with 7 additions and 1 deletions

View File

@ -288,7 +288,7 @@ __minikube_bash_source <(__minikube_convert_bash_to_zsh)
return nil
}
// GenerateBashCompletion generates the completion for the bash shell
// GenerateFishCompletion generates the completion for the bash shell
func GenerateFishCompletion(w io.Writer, cmd *cobra.Command) error {
_, err := w.Write([]byte(boilerPlate))
if err != nil {

View File

@ -57,6 +57,7 @@ var nodeAddCmd = &cobra.Command{
// Make sure to decrease the default amount of memory we use per VM if this is the first worker node
if len(cc.Nodes) == 1 && viper.GetString(memory) == "" {
warnAboutMultiNode()
cc.Memory = 2200
}

View File

@ -285,6 +285,7 @@ func startWithDriver(starter node.Starter, existing *config.ClusterConfig) (*kub
if driver.BareMetal(starter.Cfg.Driver) {
exit.WithCodeT(exit.Config, "The none driver is not compatible with multi-node clusters.")
} else {
warnAboutMultiNode()
for i := 1; i < numNodes; i++ {
nodeName := node.Name(i + 1)
n := config.Node{
@ -305,6 +306,10 @@ func startWithDriver(starter node.Starter, existing *config.ClusterConfig) (*kub
return kubeconfig, nil
}
func warnAboutMultiNode() {
out.T(out.Tip, "Multi-node clusters are currently experimental and might exhibit unintended behavior.\nTo track progress on multi-node clusters, see https://github.com/kubernetes/minikube/issues/7538.")
}
func updateDriver(driverName string) {
v, err := version.GetSemverVersion()
if err != nil {