kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

clean exit pending socket_vmnet flags

pull/14890/head
klaases 2022-09-20 14:56:52 -07:00
parent 207ee7ec0a
commit d03b4a2bfb
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/drivers/qemu/qemu.go
View File

@ -41,6 +41,8 @@ import (
"github.com/spf13/viper"
pkgdrivers "k8s.io/minikube/pkg/drivers"
"k8s.io/minikube/pkg/minikube/exit"
"k8s.io/minikube/pkg/minikube/reason"
)
const (
@ -410,8 +412,8 @@ func (d *Driver) Start() error {
"-nic", fmt.Sprintf("user,model=virtio,hostfwd=tcp::%d-:22,hostfwd=tcp::%d-:2376,hostname=%s", d.SSHPort, d.EnginePort, d.GetMachineName()),
)
case "socket":
// TODO: finalize actual socket_vmnet network flags.
return errors.New("qemu socket_vmnet network flags are not yet implemented")
// TODO: implement final socket_vmnet network flags.
exit.Message(reason.Unimplemented, "socket_vmnet network flags are not yet implemented with the qemu2 driver.\n See https://github.com/kubernetes/minikube/pull/14890 for details.")
case "tap":
startCmd = append(startCmd,
"-nic", fmt.Sprintf("tap,model=virtio,ifname=%s,script=no,downscript=no", d.NetworkInterface),