kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #8305 from medyagh/skip_windows_tests 

skip two always failing test on windows and create issue
pull/8308/head
Medya Ghazizadeh 2020-05-28 21:01:23 +00:00 committed by GitHub
parent ea20609a3a 5ecb6da470
commit cdee1dcbaa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 19 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.github/workflows/master.yml vendored
View File

@ -249,8 +249,9 @@ jobs:
echo "-------------------------------------------------------" echo "-------------------------------------------------------"
$numPass=$(echo $Env:STAT | jq '.NumberOfPass') $numPass=$(echo $Env:STAT | jq '.NumberOfPass')
echo "*** $numPass Passed ***" echo "*** $numPass Passed ***"
If ($numFail -ge 0){ exit 2 } else { echo "goodjob" } If ($numFail -gt 0){ exit 2 }
If ($numPass -eq 0){ exit 2 } If ($numPass -eq 0){ exit 2 }
If ($numFail -eq 0){ exit 0 }
functional_test_hyperv_windows: functional_test_hyperv_windows:
needs: [build_minikube] needs: [build_minikube]
env: env:
@ -288,7 +289,7 @@ jobs:
$env:KUBECONFIG="${pwd}\testhome\kubeconfig" $env:KUBECONFIG="${pwd}\testhome\kubeconfig"
$env:MINIKUBE_HOME="${pwd}\testhome" $env:MINIKUBE_HOME="${pwd}\testhome"
$ErrorActionPreference = "SilentlyContinue" $ErrorActionPreference = "SilentlyContinue"
./e2e-windows-amd64.exe --minikube-start-args="--driver=hyperv" --test.timeout=13m --test.v --test.run=TestFunctional --binary="./minikube-windows-amd64.exe" | Out-File -FilePath .\report\testout.txt -Encoding ASCII ./e2e-windows-amd64.exe --minikube-start-args="--driver=hyperv" --test.timeout=13m -timeout-multiplier=1.5 --test.v --test.run=TestFunctional --binary="./minikube-windows-amd64.exe" | Out-File -FilePath .\report\testout.txt -Encoding ASCII
$END_TIME=(GET-DATE) $END_TIME=(GET-DATE)
echo $END_TIME echo $END_TIME
$DURATION=(NEW-TIMESPAN -Start $START_TIME -End $END_TIME) $DURATION=(NEW-TIMESPAN -Start $START_TIME -End $END_TIME)
@ -335,8 +336,9 @@ jobs:
echo "-------------------------------------------------------" echo "-------------------------------------------------------"
$numPass=$(echo $Env:STAT | jq '.NumberOfPass') $numPass=$(echo $Env:STAT | jq '.NumberOfPass')
echo "*** $numPass Passed ***" echo "*** $numPass Passed ***"
If ($numFail -ge 0){ exit 2 } else { echo "goodjob" } If ($numFail -gt 0){ exit 2 }
If ($numPass -eq 0){ exit 2 } If ($numPass -eq 0){ exit 2 }
If ($numFail -eq 0){ exit 0 }
addons_certs_tests_docker_ubuntu: addons_certs_tests_docker_ubuntu:
runs-on: ubuntu-18.04 runs-on: ubuntu-18.04
env: env:

8
.github/workflows/pr.yml vendored
View File

@ -247,8 +247,9 @@ jobs:
echo "-------------------------------------------------------" echo "-------------------------------------------------------"
$numPass=$(echo $Env:STAT | jq '.NumberOfPass') $numPass=$(echo $Env:STAT | jq '.NumberOfPass')
echo "*** $numPass Passed ***" echo "*** $numPass Passed ***"
If ($numFail -ge 0){ exit 2 } else { echo "goodjob" } If ($numFail -gt 0){ exit 2 }
If ($numPass -eq 0){ exit 2 } If ($numPass -eq 0){ exit 2 }
If ($numFail -eq 0){ exit 0 }
functional_test_hyperv_windows: functional_test_hyperv_windows:
needs: [build_minikube] needs: [build_minikube]
env: env:
@ -286,7 +287,7 @@ jobs:
$env:KUBECONFIG="${pwd}\testhome\kubeconfig" $env:KUBECONFIG="${pwd}\testhome\kubeconfig"
$env:MINIKUBE_HOME="${pwd}\testhome" $env:MINIKUBE_HOME="${pwd}\testhome"
$ErrorActionPreference = "SilentlyContinue" $ErrorActionPreference = "SilentlyContinue"
./e2e-windows-amd64.exe --minikube-start-args="--driver=hyperv" --test.timeout=13m --test.v --test.run=TestFunctional --binary="./minikube-windows-amd64.exe" | Out-File -FilePath .\report\testout.txt -Encoding ASCII ./e2e-windows-amd64.exe --minikube-start-args="--driver=hyperv" --test.timeout=13m -timeout-multiplier=1.5 --test.v --test.run=TestFunctional --binary="./minikube-windows-amd64.exe" | Out-File -FilePath .\report\testout.txt -Encoding ASCII
$END_TIME=(GET-DATE) $END_TIME=(GET-DATE)
echo $END_TIME echo $END_TIME
$DURATION=(NEW-TIMESPAN -Start $START_TIME -End $END_TIME) $DURATION=(NEW-TIMESPAN -Start $START_TIME -End $END_TIME)
@ -333,8 +334,9 @@ jobs:
echo "-------------------------------------------------------" echo "-------------------------------------------------------"
$numPass=$(echo $Env:STAT | jq '.NumberOfPass') $numPass=$(echo $Env:STAT | jq '.NumberOfPass')
echo "*** $numPass Passed ***" echo "*** $numPass Passed ***"
If ($numFail -ge 0){ exit 2 } else { echo "goodjob" } If ($numFail -gt 0){ exit 2 }
If ($numPass -eq 0){ exit 2 } If ($numPass -eq 0){ exit 2 }
If ($numFail -eq 0){ exit 0 }
addons_certs_tests_docker_ubuntu: addons_certs_tests_docker_ubuntu:
runs-on: ubuntu-18.04 runs-on: ubuntu-18.04
env: env:

6
test/integration/fn_mount_cmd.go
View File

@ -43,7 +43,7 @@ const (
createdByPodRemovedByTest = "created-by-pod-removed-by-test" createdByPodRemovedByTest = "created-by-pod-removed-by-test"
) )
func validateMountCmd(ctx context.Context, t *testing.T, profile string) { func validateMountCmd(ctx context.Context, t *testing.T, profile string) { // nolint: cyclomatic complexity 31
if NoneDriver() { if NoneDriver() {
t.Skip("skipping: none driver does not support mount") t.Skip("skipping: none driver does not support mount")
} }
@ -51,6 +51,10 @@ func validateMountCmd(ctx context.Context, t *testing.T, profile string) {
t.Skip("skipping: mount broken on hyperv: https://github.com/kubernetes/minikube/issues/5029") t.Skip("skipping: mount broken on hyperv: https://github.com/kubernetes/minikube/issues/5029")
} }
if runtime.GOOS == "windows" {
t.Skip("skipping: mount broken on windows: https://github.com/kubernetes/minikube/issues/8303")
}
tempDir, err := ioutil.TempDir("", "mounttest") tempDir, err := ioutil.TempDir("", "mounttest")
defer func() { //clean up tempdir defer func() { //clean up tempdir
err := os.RemoveAll(tempDir) err := os.RemoveAll(tempDir)

4
test/integration/fn_tunnel_cmd.go
View File

@ -173,6 +173,10 @@ func validateServiceStable(ctx context.Context, t *testing.T, profile string) {
// validateAccessDirect validates if the test service can be accessed with LoadBalancer IP from host // validateAccessDirect validates if the test service can be accessed with LoadBalancer IP from host
func validateAccessDirect(ctx context.Context, t *testing.T, profile string) { func validateAccessDirect(ctx context.Context, t *testing.T, profile string) {
if runtime.GOOS == "windows" {
t.Skip("skipping: access direct test is broken on windows: https://github.com/kubernetes/minikube/issues/8304")
}
checkRoutePassword(t) checkRoutePassword(t)
got := []byte{} got := []byte{}