From cc0a97f304a7e5b7601162426c3a1b5e0a97dd92 Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Fri, 5 Oct 2018 14:30:48 -0700 Subject: [PATCH] Building a release requires tags to be built --- docs/contributors/releasing_minikube.md | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index 1f43a5fba7..13623e989d 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -39,15 +39,6 @@ This will update users of HEAD to the new ISO. Please pay attention to test failures, as this is our integration test across platforms. If there are known acceptable failures, please add a PR comment linking to the appropriate issue. -## Build the Release - -This step publishes a new binary release, but only for people who know where to find it: - - * http://go/minikube:build-release - * Ensure that you are logged in (top right) - * For `ISO_SHA256`, run: `gsutil cat gs://minikube/iso/minikube-v.iso.sha256 - * Click *Build* - ## Update Release Notes and `releases.json` Add the checksums for the release to the top of `deploy/minikube/releases.json`. This file is used for auto-update notifications. The notifications are not activated until this file is copied to GCS. @@ -66,6 +57,14 @@ Run a command like this to tag it locally: `git tag -a v0.2.0 -m "0.2.0 Release" And run a command like this to push the tag: `git push upstream v0.2.0`. +## Build the Release + +This step uses the git tag to publish new binaries, but only for people who know where to find them: + + * http://go/minikube:build-release + * Ensure that you are logged in (top right) + * For `ISO_SHA256`, run: `gsutil cat gs://minikube/iso/minikube-v.iso.sha256 + * Click *Build* ## Create a Release in Github