From cbab32ca970f6aef90e6544a5ca31cbeea4e7d7b Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Wed, 12 Aug 2020 13:31:21 -0700 Subject: [PATCH] add chenglog --- CHANGELOG.md | 45 +++++++++++++++++++++++++++++++++++++++ Makefile | 59 ++++++++++++++++++++++++++++++++++++++++++++++++---- 2 files changed, 100 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e6a459dee6..0ae02614a7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,50 @@ # Release Notes + +## Version 1.12.3 - 2020-08-12 + +Features: + +* Make waiting for Host configurable via --wait-timeout flag [#8948](https://github.com/kubernetes/minikube/pull/8948) + +Bug Fixes: + +* Ignore localhost proxy started with scheme. [#8885](https://github.com/kubernetes/minikube/pull/8885) +* Skip validations if --force is supplied [#8969](https://github.com/kubernetes/minikube/pull/8969) +* Fix handling of parseIP error [#8820](https://github.com/kubernetes/minikube/pull/8820) + +Improvements: + +* GCP Auth Addon: Exit with better error messages [#8932](https://github.com/kubernetes/minikube/pull/8932) +* Add warning for ingress addon enabled with driver of none [#8870](https://github.com/kubernetes/minikube/pull/8870) +* Improve error handling for validating memory limits [#8959](https://github.com/kubernetes/minikube/pull/8959) +* Update Japanese translation [#8967](https://github.com/kubernetes/minikube/pull/8967) +* Update Japanese translation [#8878](https://github.com/kubernetes/minikube/pull/8878) +* Fix for a few typos in polish translations [#8950](https://github.com/kubernetes/minikube/pull/8950) + +Thank you to our contributors for this release! + +- Anders F Björklund +- Andrej Guran +- Chris Paika +- Dean Coakley +- Evgeny Shmarnev +- Kubernetes Prow Robot +- Ling Samuel +- Ma Xinjian +- Marcin Niemira +- Medya Gh +- Medya Ghazizadeh +- Pablo Caderno +- Priya Wadhwa +- RA489 +- Sharif Elgamal +- TAKAHASHI Shuuji +- Thomas Strömberg +- inductor +- priyawadhwa +- programistka + ## Version 1.12.2 - 2020-08-03 Features: diff --git a/Makefile b/Makefile index ff9f5c80e7..1911aea089 100644 --- a/Makefile +++ b/Makefile @@ -15,7 +15,7 @@ # Bump these on release - and please check ISO_VERSION for correctness. VERSION_MAJOR ?= 1 VERSION_MINOR ?= 12 -VERSION_BUILD ?= 2 +VERSION_BUILD ?= 3 RAW_VERSION=$(VERSION_MAJOR).$(VERSION_MINOR).$(VERSION_BUILD) VERSION ?= v$(RAW_VERSION) @@ -34,6 +34,7 @@ GO_VERSION ?= 1.14.6 INSTALL_SIZE ?= $(shell du out/minikube-windows-amd64.exe | cut -f1) BUILDROOT_BRANCH ?= 2019.02.11 REGISTRY?=gcr.io/k8s-minikube +REGISTRY_GH?=docker.pkg.github.com/kubernetes/minikube # Get git commit id COMMIT_NO := $(shell git rev-parse HEAD 2> /dev/null || true) @@ -46,6 +47,10 @@ BUILD_IMAGE ?= us.gcr.io/k8s-artifacts-prod/build-image/kube-cross:v$(GO_VERSIO ISO_BUILD_IMAGE ?= $(REGISTRY)/buildroot-image KVM_BUILD_IMAGE ?= $(REGISTRY)/kvm-build-image:$(GO_VERSION) +KIC_BASE_IMAGE_GCR ?= $(REGISTRY)/kicbase:$(KIC_VERSION) +KIC_BASE_IMAGE_GH ?= $(REGISTRY_GH)/kicbase:$(KIC_VERSION) +KIC_BASE_IMAGE_HUB ?= kicbase/stable:$(KIC_VERSION) + ISO_BUCKET ?= minikube/iso MINIKUBE_VERSION ?= $(ISO_VERSION) @@ -130,6 +135,20 @@ KVM2_LDFLAGS := -X k8s.io/minikube/pkg/drivers/kvm.version=$(VERSION) -X k8s.io/ # hyperkit ldflags HYPERKIT_LDFLAGS := -X k8s.io/minikube/pkg/drivers/hyperkit.version=$(VERSION) -X k8s.io/minikube/pkg/drivers/hyperkit.gitCommitID=$(COMMIT) +# autopush artefacts +AUTOPUSH ?= + +# don't ask for user confirmation +IN_CI := false + +# $(call user_confirm, message) +define user_confirm + @if [ "${IN_CI}" = "false" ]; then\ + echo "⚠️ $(1)";\ + read -p "Do you want to proceed? (Y/N): " confirm && echo $$confirm | grep -iq "^[yY]" || exit 1;\ + fi +endef + # $(call DOCKER, image, command) define DOCKER docker run --rm -e GOCACHE=/app/.cache -e IN_DOCKER=1 --user $(shell id -u):$(shell id -g) -w /app -v $(PWD):/app -v $(GOPATH):/go --init $(1) /bin/bash -c '$(2)' @@ -530,9 +549,12 @@ storage-provisioner-image: out/storage-provisioner-$(GOARCH) ## Build storage-pr .PHONY: kic-base-image kic-base-image: ## builds the base image used for kic. - docker rmi -f $(REGISTRY)/kicbase:$(KIC_VERSION)-snapshot || true - docker build -f ./deploy/kicbase/Dockerfile -t local/kicbase:$(KIC_VERSION)-snapshot --build-arg COMMIT_SHA=${VERSION}-$(COMMIT) --cache-from $(REGISTRY)/kicbase:$(KIC_VERSION) --target base ./deploy/kicbase - docker tag local/kicbase:$(KIC_VERSION)-snapshot $(REGISTRY)/kicbase:$(KIC_VERSION)-snapshot + docker rmi -f $(KIC_BASE_IMAGE_GCR)-snapshot || true + docker build -f ./deploy/kicbase/Dockerfile -t local/kicbase:$(KIC_VERSION)-snapshot --build-arg COMMIT_SHA=${VERSION}-$(COMMIT) --cache-from $(KIC_BASE_IMAGE_GCR) --target base ./deploy/kicbase + docker tag local/kicbase:$(KIC_VERSION)-snapshot $(KIC_BASE_IMAGE_GCR)-snapshot + docker tag local/kicbase:$(KIC_VERSION)-snapshot $(KIC_BASE_IMAGE_GCR) + docker tag local/kicbase:$(KIC_VERSION)-snapshot $(KIC_BASE_IMAGE_HUB) + docker tag local/kicbase:$(KIC_VERSION)-snapshot $(KIC_BASE_IMAGE_GH) .PHONY: upload-preloaded-images-tar upload-preloaded-images-tar: out/minikube # Upload the preloaded images for oldest supported, newest supported, and default kubernetes versions to GCS. @@ -543,6 +565,35 @@ upload-preloaded-images-tar: out/minikube # Upload the preloaded images for olde push-storage-provisioner-image: storage-provisioner-image ## Push storage-provisioner docker image using gcloud gcloud docker -- push $(STORAGE_PROVISIONER_IMAGE) +.PHONY: push-docker +push-docker: # Push docker image base on to IMAGE variable + (docker pull $(IMAGE) && (echo "Image already exist"; exit 1) || echo "Image doesn't exist in registry") +ifndef AUTOPUSH + $(call user_confirm, 'Are you sure you want to push $(IMAGE) ?') +endif + docker push $(IMAGE) || gcloud docker -- push $(IMAGE) + +.PHONY: push-kic-base-image-gcr +push-kic-base-image-gcr: kic-base-image ## Push kic-base to gcr + $(MAKE) push-docker IMAGE=$(KIC_BASE_IMAGE_GCR) + +.PHONY: push-kic-base-image-gh +push-kic-base-image-gh: kic-base-image ## Push kic-base to github + $(MAKE) push-docker IMAGE=$(KIC_BASE_IMAGE_GH) + +.PHONY: push-kic-base-image-hub +push-kic-base-image-hub: kic-base-image ## Push kic-base to docker hub + $(MAKE) push-docker IMAGE=$(KIC_BASE_IMAGE_HUB) + +.PHONY: push-kic-base-image +push-kic-base-image: ## Push kic-base to all registries +ifndef AUTOPUSH + $(call user_confirm, 'Are you sure you want to push: $(KIC_BASE_IMAGE_GH) & $(KIC_BASE_IMAGE_GCR) & $(KIC_BASE_IMAGE_HUB) ?') + $(MAKE) push-kic-base-image AUTOPUSH=true +else + $(MAKE) push-kic-base-image-gh push-kic-base-image-gcr push-kic-base-image-hub +endif + .PHONY: out/gvisor-addon out/gvisor-addon: pkg/minikube/assets/assets.go pkg/minikube/translate/translations.go ## Build gvisor addon GOOS=linux CGO_ENABLED=0 go build -o $@ cmd/gvisor/gvisor.go