From 36893766c425d49ce29fb3c3b21d10f172494a85 Mon Sep 17 00:00:00 2001 From: tstromberg Date: Wed, 18 Dec 2019 16:12:20 -0800 Subject: [PATCH 1/3] Not a crash, but an error --- pkg/minikube/exit/exit.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/minikube/exit/exit.go b/pkg/minikube/exit/exit.go index 04ff252ce8..c19c088711 100644 --- a/pkg/minikube/exit/exit.go +++ b/pkg/minikube/exit/exit.go @@ -102,6 +102,6 @@ func displayError(msg string, err error) { out.ErrT(out.Empty, "") out.FatalT("{{.msg}}: {{.err}}", out.V{"msg": translate.T(msg), "err": err}) out.ErrT(out.Empty, "") - out.ErrT(out.Sad, "Sorry that minikube crashed. If this was unexpected, we would love to hear from you:") + out.ErrT(out.Sad, "minikube is exiting due to an error. If this message is not helpful, please open an issue:") out.ErrT(out.URL, "https://github.com/kubernetes/minikube/issues/new/choose") } From 0796d866df6055ce5a2820b6168e207d8442a3ff Mon Sep 17 00:00:00 2001 From: tstromberg Date: Thu, 19 Dec 2019 12:51:02 -0800 Subject: [PATCH 2/3] Further clarification --- pkg/minikube/exit/exit.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/minikube/exit/exit.go b/pkg/minikube/exit/exit.go index c19c088711..7d5e96ef1d 100644 --- a/pkg/minikube/exit/exit.go +++ b/pkg/minikube/exit/exit.go @@ -102,6 +102,6 @@ func displayError(msg string, err error) { out.ErrT(out.Empty, "") out.FatalT("{{.msg}}: {{.err}}", out.V{"msg": translate.T(msg), "err": err}) out.ErrT(out.Empty, "") - out.ErrT(out.Sad, "minikube is exiting due to an error. If this message is not helpful, please open an issue:") + out.ErrT(out.Sad, "minikube is exiting due to an error. If the above message is not useful, open an issue:") out.ErrT(out.URL, "https://github.com/kubernetes/minikube/issues/new/choose") } From 6cc860e91103bb0f9f36d6f0d1f1513632779103 Mon Sep 17 00:00:00 2001 From: tstromberg Date: Thu, 19 Dec 2019 13:05:47 -0800 Subject: [PATCH 3/3] Add build tags so that the test only runs on Darwin --- pkg/minikube/registry/drvs/hyperkit/hyperkit_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/minikube/registry/drvs/hyperkit/hyperkit_test.go b/pkg/minikube/registry/drvs/hyperkit/hyperkit_test.go index 51cc3415ff..4e89276f94 100644 --- a/pkg/minikube/registry/drvs/hyperkit/hyperkit_test.go +++ b/pkg/minikube/registry/drvs/hyperkit/hyperkit_test.go @@ -1,3 +1,5 @@ +// +build darwin + /* Copyright 2019 The Kubernetes Authors All rights reserved.