From c61a34b38ffc361799d00d811cf6ca6dfacbb4d0 Mon Sep 17 00:00:00 2001 From: Steven Powell Date: Tue, 4 Jan 2022 16:53:13 -0800 Subject: [PATCH] increase test timeout for Docker Windows --- test/integration/functional_test.go | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/test/integration/functional_test.go b/test/integration/functional_test.go index a268c058ff..d1ad505db4 100644 --- a/test/integration/functional_test.go +++ b/test/integration/functional_test.go @@ -946,8 +946,12 @@ func dashboardURL(b *bufio.Reader) (string, error) { // validateDryRun asserts that the dry-run mode quickly exits with the right code func validateDryRun(ctx context.Context, t *testing.T, profile string) { - // dry-run mode should always be able to finish quickly (<5s) - mctx, cancel := context.WithTimeout(ctx, Seconds(5)) + // dry-run mode should always be able to finish quickly (<5s) expect Docker Windows + timeout := Seconds(5) + if runtime.GOOS == "windows" && DockerDriver() { + timeout = Seconds(10) + } + mctx, cancel := context.WithTimeout(ctx, timeout) defer cancel() // docs: Run `minikube start --dry-run --memory 250MB` @@ -985,8 +989,12 @@ func validateDryRun(ctx context.Context, t *testing.T, profile string) { // validateInternationalLanguage asserts that the language used can be changed with environment variables func validateInternationalLanguage(ctx context.Context, t *testing.T, profile string) { - // dry-run mode should always be able to finish quickly (<5s) - mctx, cancel := context.WithTimeout(ctx, Seconds(5)) + // dry-run mode should always be able to finish quickly (<5s) except Docker Windows + timeout := Seconds(5) + if runtime.GOOS == "windows" && DockerDriver() { + timeout = Seconds(10) + } + mctx, cancel := context.WithTimeout(ctx, timeout) defer cancel() // Too little memory!