kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #14290 from kgibm/issue12658 

Special case port mapping publish on macOS
pull/14177/head
Steven Powell 2022-06-08 11:09:20 -07:00 committed by GitHub
parent 040fa6503d 7df74d3e4a
commit c099c054b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/drivers/kic/oci/oci.go
View File

@ -488,8 +488,13 @@ func generatePortMappings(portMappings ...PortMapping) []string {
for _, pm := range portMappings {
// let docker pick a host port by leaving it as ::
// example --publish=127.0.0.17::8443 will get a random host port for 8443
publish := fmt.Sprintf("--publish=%s::%d", pm.ListenAddress, pm.ContainerPort)
result = append(result, publish)
if runtime.GOOS == "darwin" {
publish := fmt.Sprintf("--publish=%d", pm.ContainerPort)
result = append(result, publish)
} else {
publish := fmt.Sprintf("--publish=%s::%d", pm.ListenAddress, pm.ContainerPort)
result = append(result, publish)
}
}
return result
}