From bf4aa78ca6367aba419a9a935a9124a14d1a367b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Anders=20F=20Bj=C3=B6rklund?= Date: Mon, 27 Apr 2020 21:58:21 +0200 Subject: [PATCH] Log the version used of the two KIC runtimes --- pkg/minikube/registry/drvs/docker/docker.go | 4 +++- pkg/minikube/registry/drvs/podman/podman.go | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/minikube/registry/drvs/docker/docker.go b/pkg/minikube/registry/drvs/docker/docker.go index 13a4102e69..ada73686c0 100644 --- a/pkg/minikube/registry/drvs/docker/docker.go +++ b/pkg/minikube/registry/drvs/docker/docker.go @@ -83,8 +83,10 @@ func status() registry.State { // Quickly returns an error code if server is not running cmd := exec.CommandContext(ctx, oci.Docker, "version", "--format", "{{.Server.Version}}") - _, err = cmd.Output() + o, err := cmd.Output() + output := string(o) if err == nil { + glog.Infof("docker version: %s", output) return registry.State{Installed: true, Healthy: true} } diff --git a/pkg/minikube/registry/drvs/podman/podman.go b/pkg/minikube/registry/drvs/podman/podman.go index dd54e998d8..ffde7a19b9 100644 --- a/pkg/minikube/registry/drvs/podman/podman.go +++ b/pkg/minikube/registry/drvs/podman/podman.go @@ -95,6 +95,8 @@ func status() registry.State { o, err := cmd.Output() output := string(o) if err == nil { + glog.Infof("podman version: %s", output) + v, err := semver.Make(output) if err != nil { return registry.State{Error: err, Installed: true, Healthy: false, Fix: "Cant verify minimum required version for podman . See podman website for installation guide.", Doc: "https://podman.io/getting-started/installation.html"}