Merge pull request #9044 from medyagh/stop_keep_contex

add an new flag to stop command --keep-context-active
pull/9052/head
Medya Ghazizadeh 2020-08-21 12:02:35 -07:00 committed by GitHub
commit ba96f292d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 4 deletions

View File

@ -38,6 +38,7 @@ import (
)
var stopAll bool
var keepActive bool
// stopCmd represents the stop command
var stopCmd = &cobra.Command{
@ -51,6 +52,7 @@ itself, leaving all files intact. The cluster can be started again with the "sta
func init() {
stopCmd.Flags().BoolVar(&stopAll, "all", false, "Set flag to stop all profiles (clusters)")
stopCmd.Flags().BoolVar(&keepActive, "keep-context-active", false, "keep the kube-context active after cluster is stopped. Defaults to false.")
if err := viper.GetViper().BindPFlags(stopCmd.Flags()); err != nil {
exit.WithError("unable to bind flags", err)
@ -111,8 +113,10 @@ func stopProfile(profile string) int {
out.WarningT("Unable to kill mount process: {{.error}}", out.V{"error": err})
}
if err := kubeconfig.UnsetCurrentContext(profile, kubeconfig.PathFromEnv()); err != nil {
exit.WithError("update config", err)
if !keepActive {
if err := kubeconfig.UnsetCurrentContext(profile, kubeconfig.PathFromEnv()); err != nil {
exit.WithError("update config", err)
}
}
return stoppedNodes

View File

@ -22,8 +22,9 @@ minikube stop [flags]
### Options
```
--all Set flag to stop all profiles (clusters)
-h, --help help for stop
--all Set flag to stop all profiles (clusters)
-h, --help help for stop
--keep-context-active keep the kube-context active after cluster is stopped. Defaults to false.
```
### Options inherited from parent commands