kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #9269 from kubernetes/sharifelgamal-patch-4-1 

Fix documentation grammar
pull/9250/head
Sharif Elgamal 2020-09-17 13:30:35 -07:00 committed by GitHub
parent 9a3e58a7cc 2001d20510
commit b647a85ba1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
site/content/en/docs/contrib/releasing/binaries.md
View File

@ -20,13 +20,12 @@ description: >
See [ISO release instructions]({{<ref "iso.md">}})
## Tag KIC base image
## Release new kicbase image
for container drivers (docker,podman), if there has been any change in Dockerfile
(and there is a -snapshot image), should tag with latest release and push to gcr and docker hub and github packages.
If there are changes to the Dockerfile for the docker and/or podman drivers
(and there is a -snapshot image), you should retag it as a new version and push it to GCR, dockerhub and github packages.
for example if you are releasing v0.0.13 and latest kicbase image is v0.0.12-snapshot
should tag v0.0.13 and change the [kic/types.go](https://github.com/medyagh/minikube/blob/635ff53a63e5bb1be4e1abb9067ebe502a16224e/pkg/drivers/kic/types.go#L29-L30) file as well.
For example, if you are releasing v0.0.13 and the current kicbase image tag is v0.0.12-snapshot, you should tag v0.0.13 and change [kic/types.go](https://github.com/medyagh/minikube/blob/635ff53a63e5bb1be4e1abb9067ebe502a16224e/pkg/drivers/kic/types.go#L29-L30) as well.
## Update Release Notes