skip two always failing test on windows and create issue

pull/8305/head
Medya Gh 2020-05-28 10:57:41 -07:00
parent 4f0613929f
commit b44510c835
2 changed files with 9 additions and 1 deletions

View File

@ -43,7 +43,7 @@ const (
createdByPodRemovedByTest = "created-by-pod-removed-by-test" createdByPodRemovedByTest = "created-by-pod-removed-by-test"
) )
func validateMountCmd(ctx context.Context, t *testing.T, profile string) { func validateMountCmd(ctx context.Context, t *testing.T, profile string) { // nolint: cyclomatic complexity 31
if NoneDriver() { if NoneDriver() {
t.Skip("skipping: none driver does not support mount") t.Skip("skipping: none driver does not support mount")
} }
@ -51,6 +51,10 @@ func validateMountCmd(ctx context.Context, t *testing.T, profile string) {
t.Skip("skipping: mount broken on hyperv: https://github.com/kubernetes/minikube/issues/5029") t.Skip("skipping: mount broken on hyperv: https://github.com/kubernetes/minikube/issues/5029")
} }
if runtime.GOOS == "windows" {
t.Skip("skipping: mount broken on windows: https://github.com/kubernetes/minikube/issues/8303")
}
tempDir, err := ioutil.TempDir("", "mounttest") tempDir, err := ioutil.TempDir("", "mounttest")
defer func() { //clean up tempdir defer func() { //clean up tempdir
err := os.RemoveAll(tempDir) err := os.RemoveAll(tempDir)

View File

@ -173,6 +173,10 @@ func validateServiceStable(ctx context.Context, t *testing.T, profile string) {
// validateAccessDirect validates if the test service can be accessed with LoadBalancer IP from host // validateAccessDirect validates if the test service can be accessed with LoadBalancer IP from host
func validateAccessDirect(ctx context.Context, t *testing.T, profile string) { func validateAccessDirect(ctx context.Context, t *testing.T, profile string) {
if runtime.GOOS == "windows" {
t.Skip("skipping: mount broken on windows: https://github.com/kubernetes/minikube/issues/8304")
}
checkRoutePassword(t) checkRoutePassword(t)
got := []byte{} got := []byte{}