kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #8904 from Xcalizorz/master 

fixes(#8301): --help: bool flags which default to 'false' yield confusing output
pull/9199/head
priyawadhwa 2020-09-08 13:50:10 -04:00 committed by GitHub
parent f7b120a7d4 6f95e0fc7c
commit b4400ad70a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/minikube/cmd/service.go
View File

@ -104,7 +104,7 @@ You may select another namespace by using 'minikube service {{.service}} -n <nam
func init() { func init() {
serviceCmd.Flags().StringVarP(&namespace, "namespace", "n", "default", "The service namespace") serviceCmd.Flags().StringVarP(&namespace, "namespace", "n", "default", "The service namespace")
serviceCmd.Flags().BoolVar(&serviceURLMode, "url", false, "Display the Kubernetes service URL in the CLI instead of opening it in the default browser") serviceCmd.Flags().BoolVar(&serviceURLMode, "url", false, "Display the Kubernetes service URL in the CLI instead of opening it in the default browser")
serviceCmd.Flags().BoolVar(&https, "https", false, "Open the service URL with https instead of http") serviceCmd.Flags().BoolVar(&https, "https", false, "Open the service URL with https instead of http (defaults to \"false\")")
serviceCmd.Flags().IntVar(&wait, "wait", service.DefaultWait, "Amount of time to wait for a service in seconds") serviceCmd.Flags().IntVar(&wait, "wait", service.DefaultWait, "Amount of time to wait for a service in seconds")
serviceCmd.Flags().IntVar(&interval, "interval", service.DefaultInterval, "The initial time interval for each check that wait performs in seconds") serviceCmd.Flags().IntVar(&interval, "interval", service.DefaultInterval, "The initial time interval for each check that wait performs in seconds")

2
site/content/en/docs/commands/service.md
View File

@ -22,7 +22,7 @@ minikube service [flags] SERVICE
``` ```
--format string Format to output service URL in. This format will be applied to each url individually and they will be printed one at a time. (default "http://{{.IP}}:{{.Port}}") --format string Format to output service URL in. This format will be applied to each url individually and they will be printed one at a time. (default "http://{{.IP}}:{{.Port}}")
-h, --help help for service -h, --help help for service
--https Open the service URL with https instead of http --https Open the service URL with https instead of http (defaults to "false")
--interval int The initial time interval for each check that wait performs in seconds (default 1) --interval int The initial time interval for each check that wait performs in seconds (default 1)
-n, --namespace string The service namespace (default "default") -n, --namespace string The service namespace (default "default")
--url Display the Kubernetes service URL in the CLI instead of opening it in the default browser --url Display the Kubernetes service URL in the CLI instead of opening it in the default browser