simplify addon code by fixing gcp-auth failure policy

deploy/addons/gcp-auth/gcp-auth-webhook.yaml

@@ -50,8 +50,6 @@ spec:
   template:
     metadata:
       name: gcp-auth-certs-create
-      labels:
-          gcp-auth-skip-secret: "true"
     spec:
       serviceAccountName: minikube-gcp-auth-certs
       containers:
@@ -79,7 +77,6 @@ spec:
       labels:
         app: gcp-auth
         kubernetes.io/minikube-addons: gcp-auth
-        gcp-auth-skip-secret: "true"
     spec:
       containers:
         - name: gcp-auth
@@ -112,8 +109,6 @@ spec:
   template:
     metadata:
       name: gcp-auth-certs-patch
-      labels:
-          gcp-auth-skip-secret: "true"
     spec:
       serviceAccountName: minikube-gcp-auth-certs
       containers:
@@ -136,7 +131,7 @@ metadata:
     app: gcp-auth
 webhooks:
 - name: gcp-auth-mutate.k8s.io
-  failurePolicy: Fail
+  failurePolicy: Ignore
   objectSelector:
     matchExpressions:
       - key: gcp-auth-skip-secret

deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl

@@ -95,7 +95,6 @@ metadata:
   labels:
     integration-test: storage-provisioner
     addonmanager.kubernetes.io/mode: Reconcile
-    gcp-auth-skip-secret: "true"
 spec:
   serviceAccountName: storage-provisioner
   hostNetwork: true

pkg/addons/addons.go

@@ -406,18 +406,12 @@ func Start(wg *sync.WaitGroup, cc *config.ClusterConfig, toEnable map[string]boo
 	var awg sync.WaitGroup
 
 	enabledAddons := []string{}
-	deferredAddons := []string{}
 
 	defer func() { // making it show after verifications (see #7613)
 		register.Reg.SetStep(register.EnablingAddons)
 		out.T(style.AddonEnable, "Enabled addons: {{.addons}}", out.V{"addons": strings.Join(enabledAddons, ", ")})
 	}()
 	for _, a := range toEnableList {
-		if a == "gcp-auth" {
-			deferredAddons = append(deferredAddons, a)
-			continue
-		}
-
 		awg.Add(1)
 		go func(name string) {
 			err := RunCallbacks(cc, name, "true")
@@ -433,16 +427,6 @@ func Start(wg *sync.WaitGroup, cc *config.ClusterConfig, toEnable map[string]boo
 	// Wait until all of the addons are enabled before updating the config (not thread safe)
 	awg.Wait()
 
-	// Now run the deferred addons
-	for _, a := range deferredAddons {
-		err := RunCallbacks(cc, a, "true")
-		if err != nil {
-			out.WarningT("Enabling '{{.name}}' returned an error: {{.error}}", out.V{"name": a, "error": err})
-		} else {
-			enabledAddons = append(enabledAddons, a)
-		}
-	}
-
 	for _, a := range enabledAddons {
 		if err := Set(cc, a, "true"); err != nil {
 			glog.Errorf("store failed: %v", err)