kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Improve comments

pull/4141/head
Thomas Stromberg 2019-04-23 13:43:17 -07:00
parent 56bf985dc5
commit a1637061a0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/minikube/cmd/start.go
View File

@ -176,17 +176,17 @@ func runStart(cmd *cobra.Command, args []string) {
exit.WithError("Failed to generate config", err) exit.WithError("Failed to generate config", err)
} }
// The ISO is required to boot the VM, so block on completion before pulling images. // For non-"none", the ISO is required to boot, so block until it is downloaded
if viper.GetString(vmDriver) != constants.DriverNone { if viper.GetString(vmDriver) != constants.DriverNone {
if err := cluster.CacheISO(config.MachineConfig); err != nil { if err := cluster.CacheISO(config.MachineConfig); err != nil {
exit.WithError("Failed to cache ISO", err) exit.WithError("Failed to cache ISO", err)
} }
} else { } else {
// With "none", images are persistently loaded into Docker, so it's unneccessary to cache them in a second location. // With "none", images are persistently stored in Docker, so internal caching isn't necessary.
viper.Set(cacheImages, false) viper.Set(cacheImages, false)
} }
// Now that the ISO is downloaded, we pull images in the backgfround while the VM boots. // Now that the ISO is downloaded, pull images in the background while the VM boots.
var cacheGroup errgroup.Group var cacheGroup errgroup.Group
beginCacheImages(&cacheGroup, k8sVersion) beginCacheImages(&cacheGroup, k8sVersion)