From 61a12b313f688e887c060988f7984ac8a195d157 Mon Sep 17 00:00:00 2001 From: Predrag Rogic Date: Thu, 10 Dec 2020 01:28:40 +0000 Subject: [PATCH 1/4] fix: use release tags and add make targets --- Makefile | 12 ++++++++++++ hack/update/github.go | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 0915125708..d2dc1fdb75 100644 --- a/Makefile +++ b/Makefile @@ -798,3 +798,15 @@ help: @printf "\033[1mAvailable targets for minikube ${VERSION}\033[21m\n" @printf "\033[1m--------------------------------------\033[21m\n" @grep -h -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}' + + +.PHONY: update-kubernetes-version +update-kubernetes-version: + (cd hack/update/kubernetes_version && \ + go run update_kubernetes_version.go) + +.PHONY: update-kubernetes-version-pr +update-kubernetes-version-pr: + (cd hack/update/kubernetes_version && \ + export UPDATE_TARGET="gh" && \ + go run update_kubernetes_version.go) diff --git a/hack/update/github.go b/hack/update/github.go index 897a36a404..298ee866eb 100644 --- a/hack/update/github.go +++ b/hack/update/github.go @@ -216,12 +216,12 @@ func GHReleases(ctx context.Context, owner, repo string) (stable, latest string, // walk through the paginated list of up to ghSearchLimit newest releases opts := &github.ListOptions{PerPage: ghListPerPage} for (opts.Page+1)*ghListPerPage <= ghSearchLimit { - rls, resp, err := ghc.Repositories.ListReleases(ctx, owner, repo, opts) + rls, resp, err := ghc.Repositories.ListTags(ctx, owner, repo, opts) if err != nil { return "", "", err } for _, rl := range rls { - ver := rl.GetTagName() + ver := *rl.Name if !semver.IsValid(ver) { continue } From ff24033257c89f2c564146a513c1b3ae8ca94b29 Mon Sep 17 00:00:00 2001 From: Predrag Rogic Date: Thu, 10 Dec 2020 01:34:40 +0000 Subject: [PATCH 2/4] fix: use release tags and add make targets --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d2dc1fdb75..b983ad4a1b 100644 --- a/Makefile +++ b/Makefile @@ -808,5 +808,5 @@ update-kubernetes-version: .PHONY: update-kubernetes-version-pr update-kubernetes-version-pr: (cd hack/update/kubernetes_version && \ - export UPDATE_TARGET="gh" && \ + export UPDATE_TARGET="all" && \ go run update_kubernetes_version.go) From 871f22eb199f4211d05e6ff568223e29db578103 Mon Sep 17 00:00:00 2001 From: Predrag Rogic Date: Thu, 10 Dec 2020 02:16:29 +0000 Subject: [PATCH 3/4] fix: use release tags and add make targets --- Makefile | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Makefile b/Makefile index b983ad4a1b..75f126f45a 100644 --- a/Makefile +++ b/Makefile @@ -807,6 +807,11 @@ update-kubernetes-version: .PHONY: update-kubernetes-version-pr update-kubernetes-version-pr: +ifndef GITHUB_TOKEN + @echo "⚠️ please set GITHUB_TOKEN environment variable with your GitHub token" + @echo "you can use https://github.com/settings/tokens/new to create new one" +else (cd hack/update/kubernetes_version && \ export UPDATE_TARGET="all" && \ go run update_kubernetes_version.go) +endif From d472499af128c83d38f02fa06990d68b5a84ac5d Mon Sep 17 00:00:00 2001 From: Predrag Rogic Date: Thu, 10 Dec 2020 02:27:19 +0000 Subject: [PATCH 4/4] fix: use release tags and add make targets --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 75f126f45a..9ebf13dba3 100644 --- a/Makefile +++ b/Makefile @@ -809,7 +809,7 @@ update-kubernetes-version: update-kubernetes-version-pr: ifndef GITHUB_TOKEN @echo "⚠️ please set GITHUB_TOKEN environment variable with your GitHub token" - @echo "you can use https://github.com/settings/tokens/new to create new one" + @echo "you can use https://github.com/settings/tokens/new?scopes=repo,write:packages to create new one" else (cd hack/update/kubernetes_version && \ export UPDATE_TARGET="all" && \