From 9a0f1a012b7ec93a8174fac78a2497b870fbdc99 Mon Sep 17 00:00:00 2001 From: Sharif Elgamal Date: Wed, 11 May 2022 14:54:08 -0700 Subject: [PATCH] support darwin hardware acceleration --- pkg/drivers/qemu/qemu.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pkg/drivers/qemu/qemu.go b/pkg/drivers/qemu/qemu.go index 2b784cc1b5..9d2cdd2f31 100644 --- a/pkg/drivers/qemu/qemu.go +++ b/pkg/drivers/qemu/qemu.go @@ -339,6 +339,11 @@ func (d *Driver) Start() error { var startCmd []string if d.MachineType != "" { + machineType := d.MachineType + if runtime.GOOS == "darwin" { + // highmem=off needed, see https://patchwork.kernel.org/project/qemu-devel/patch/20201126215017.41156-9-agraf@csgraf.de/#23800615 for details + machineType += ",accel=hvf,highmem=off" + } startCmd = append(startCmd, "-M", d.MachineType, ) @@ -352,7 +357,7 @@ func (d *Driver) Start() error { if !d.BIOS { if d.Firmware != "" { startCmd = append(startCmd, - "-drive", fmt.Sprintf("file=%s,readonly,format=raw,if=pflash", d.Firmware)) + "-drive", fmt.Sprintf("file=%s,readonly=on,format=raw,if=pflash", d.Firmware)) } else { return fmt.Errorf("unknown firmware") }