From e57dff657b44744883dcaf6f0823613b188c004e Mon Sep 17 00:00:00 2001 From: Steven Powell Date: Thu, 26 May 2022 16:07:40 -0700 Subject: [PATCH 1/2] skip TestSkaffold on Hyper-V --- test/integration/skaffold_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/integration/skaffold_test.go b/test/integration/skaffold_test.go index 52223ac5d5..e9ea6d38b3 100644 --- a/test/integration/skaffold_test.go +++ b/test/integration/skaffold_test.go @@ -38,6 +38,9 @@ func TestSkaffold(t *testing.T) { if NoneDriver() { t.Skip("none driver doesn't support `minikube docker-env`; skaffold depends on this command") } + if HyperVDriver() { + t.Skip("skipping due to https://github.com/kubernetes/minikube/issues/14232") + } if cr := ContainerRuntime(); cr != "docker" { t.Skipf("skaffold requires docker-env, currently testing %s container runtime", cr) } From cbb189558a8637cc5645225aa2875e5bfa6d90f0 Mon Sep 17 00:00:00 2001 From: Steven Powell Date: Thu, 26 May 2022 16:19:26 -0700 Subject: [PATCH 2/2] skip for all of Windows --- test/integration/skaffold_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/integration/skaffold_test.go b/test/integration/skaffold_test.go index e9ea6d38b3..78351f8b29 100644 --- a/test/integration/skaffold_test.go +++ b/test/integration/skaffold_test.go @@ -35,12 +35,12 @@ import ( // TestSkaffold makes sure skaffold run can be run with minikube func TestSkaffold(t *testing.T) { + if runtime.GOOS == "windows" { + t.Skip("skipping due to https://github.com/kubernetes/minikube/issues/14232") + } if NoneDriver() { t.Skip("none driver doesn't support `minikube docker-env`; skaffold depends on this command") } - if HyperVDriver() { - t.Skip("skipping due to https://github.com/kubernetes/minikube/issues/14232") - } if cr := ContainerRuntime(); cr != "docker" { t.Skipf("skaffold requires docker-env, currently testing %s container runtime", cr) }