kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #6541 from anencore94/deleteContext 

Fix to delete context when delete minikube
pull/6555/head
Thomas Strömberg 2020-02-07 16:15:56 -08:00 committed by GitHub
parent f4da94f647 2c08f62ed2
commit 8762c48921
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/minikube/cmd/delete.go
View File

@ -238,7 +238,7 @@ func deleteProfile(profile *pkg_config.Profile) error {
} }
func deleteContext(machineName string) error { func deleteContext(machineName string) error {
if err := kubeconfig.DeleteContext(constants.KubeconfigPath, machineName); err != nil { if err := kubeconfig.DeleteContext(machineName); err != nil {
return DeletionError{Err: fmt.Errorf("update config: %v", err), Errtype: Fatal} return DeletionError{Err: fmt.Errorf("update config: %v", err), Errtype: Fatal}
} }

8
test/integration/start_stop_delete_test.go
View File

@ -153,6 +153,14 @@ func TestStartStop(t *testing.T) {
if err != nil { if err != nil {
t.Errorf("%s failed: %v", rr.Args, err) t.Errorf("%s failed: %v", rr.Args, err)
} }
rr, err = Run(t, exec.CommandContext(ctx, "kubectl", "config", "get-contexts"))
if err != nil {
t.Fatalf("%s failed: %v", rr.Args, err)
}
if notDeleted := strings.Contains(rr.Output(), profile); notDeleted {
t.Errorf(" kubeconfig of %s is not deleted = %t; want = %t", profile, notDeleted, false)
}
} }
}) })
} }