Update pkg/minikube/node/start.go

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
pull/18859/head
錦南路之花 2024-07-15 00:51:20 +02:00 committed by GitHub
parent 5bbb68fdb3
commit 8319a34381
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 4 deletions

View File

@ -870,11 +870,15 @@ func tryRegistry(r command.Runner, driverName, imageRepository, ip string) {
if driver.IsQEMU(driverName) && ip == "127.0.0.1" {
out.WarningT("Due to DNS issues your cluster may have problems starting and you may not be able to pull images\nMore details available at: https://minikube.sigs.k8s.io/docs/drivers/qemu/#known-issues")
}
// now we shall also try whether this registry is reachable outside the machine
// so that we can tell in the logs that if the user's computer had any network issue or could it be related to a network module config change in minikbue ISO
// now we shall also try whether this registry is reachable
// outside the machine so that we can tell in the logs that if
// the user's computer had any network issue or could it be
// related to a network module config change in minikube ISO
// We should skip the second check if the user is using the none or ssh driver since there is no difference
// between an "inside" and "outside" check on the none driver, and checking the host on the ssh driver is not helpful.
// We should skip the second check if the user is using the none
// or ssh driver since there is no difference between an "inside"
// and "outside" check on the none driver, and checking the host
// on the ssh driver is not helpful.
warning := "Failing to connect to {{.curlTarget}} from inside the minikube {{.type}}"
if !driver.IsNone(driverName) && !driver.IsSSH(driverName) {
if err := cmd.Run(); err != nil {