update TestValidateGPUs

pull/17314/head
Steven Powell 2023-10-03 10:01:35 -07:00
parent 55b78ed5cf
commit 8266558cf4
1 changed files with 15 additions and 12 deletions

View File

@ -860,28 +860,31 @@ func TestImageMatchesBinaryVersion(t *testing.T) {
} }
} }
func TestValidateEnableNvidiaGPUs(t *testing.T) { func TestValidateGPUs(t *testing.T) {
tests := []struct { tests := []struct {
enableNvidiaGPUs bool gpus string
drvName string drvName string
runtime string runtime string
errorMsg string errorMsg string
}{ }{
{false, "kvm", "containerd", ""}, {"", "kvm", "containerd", ""},
{true, "docker", "docker", ""}, {"all", "docker", "docker", ""},
{true, "docker", "", ""}, {"nvidia", "docker", "docker", ""},
{true, "kvm", "docker", "The enable-nvidia-gpus flag can only be run with the docker driver and docker container-runtime"}, {"all", "docker", "", ""},
{true, "docker", "containerd", "The enable-nvidia-gpus flag can only be run with the docker driver and docker container-runtime"}, {"nvidia", "docker", "", ""},
{"all", "kvm", "docker", "The gpus flag can only be used with the docker driver and docker container-runtime"},
{"nvidia", "docker", "containerd", "The gpus flag can only be used with the docker driver and docker container-runtime"},
{"cat", "docker", "docker", `The gpus flag must be passed a value of "nvidia" or "all"`},
} }
for _, tc := range tests { for _, tc := range tests {
gotError := "" gotError := ""
got := validateEnableNvidiaGPUs(tc.enableNvidiaGPUs, tc.drvName, tc.runtime) got := validateGPUs(tc.gpus, tc.drvName, tc.runtime)
if got != nil { if got != nil {
gotError = got.Error() gotError = got.Error()
} }
if gotError != tc.errorMsg { if gotError != tc.errorMsg {
t.Errorf("validateEnableNvidiaGPUs(%t, %s, %s) = %q; want = %q", tc.enableNvidiaGPUs, tc.drvName, tc.runtime, got, tc.errorMsg) t.Errorf("validateGPUs(%s, %s, %s) = %q; want = %q", tc.gpus, tc.drvName, tc.runtime, got, tc.errorMsg)
} }
} }
} }