From 7d749255783b07419985366b8b8b03554ef493e1 Mon Sep 17 00:00:00 2001 From: Sharif Elgamal <selgamal@google.com> Date: Mon, 13 Jun 2022 17:08:30 -0700 Subject: [PATCH] build auto-pause outside kicbase dockerfile --- Makefile | 3 ++- deploy/kicbase/Dockerfile | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index f540fefbe0..75bef36f42 100644 --- a/Makefile +++ b/Makefile @@ -739,7 +739,8 @@ endif ifndef CIBUILD $(call user_confirm, 'Are you sure you want to push $(KICBASE_IMAGE_REGISTRIES) ?') endif - env $(X_BUILD_ENV) docker buildx build -f ./deploy/kicbase/Dockerfile --builder $(X_DOCKER_BUILDER) --platform $(KICBASE_ARCH) $(addprefix -t ,$(KICBASE_IMAGE_REGISTRIES)) --push --build-arg COMMIT_SHA=${VERSION}-$(COMMIT) . + ./deploy/kicbase/build_auto_pause.sh $(KICBASE_ARCH) + env $(X_BUILD_ENV) docker buildx build -f ./deploy/kicbase/Dockerfile --builder $(X_DOCKER_BUILDER) --platform $(KICBASE_ARCH) $(addprefix -t ,$(KICBASE_IMAGE_REGISTRIES)) --push --build-arg COMMIT_SHA=${VERSION}-$(COMMIT) --build-arg PREBUILT_AUTO_PAUSE=true . out/preload-tool: go build -ldflags="$(MINIKUBE_LDFLAGS)" -o $@ ./hack/preload-images/*.go diff --git a/deploy/kicbase/Dockerfile b/deploy/kicbase/Dockerfile index a683b77046..743fb5eea1 100644 --- a/deploy/kicbase/Dockerfile +++ b/deploy/kicbase/Dockerfile @@ -31,7 +31,8 @@ COPY third_party/ ./third_party COPY go.mod go.sum ./ ARG TARGETARCH ENV GOARCH=${TARGETARCH} -RUN cd ./cmd/auto-pause/ && go build +ARG PREBUILT_AUTO_PAUSE +RUN if [ "$PREBUILT_AUTO_PAUSE" != "true" ]; then cd ./cmd/auto-pause/ && go build -o auto-pause-${TARGETARCH}; fi # start from ubuntu 20.04, this image is reasonably small as a starting point # for a kubernetes node image, it doesn't contain much we don't need @@ -51,7 +52,7 @@ COPY deploy/kicbase/02-crio.conf /etc/crio/crio.conf.d/02-crio.conf COPY deploy/kicbase/containerd.toml /etc/containerd/config.toml COPY deploy/kicbase/clean-install /usr/local/bin/clean-install COPY deploy/kicbase/entrypoint /usr/local/bin/entrypoint -COPY --from=auto-pause /src/cmd/auto-pause/auto-pause /bin/auto-pause +COPY --from=auto-pause /src/cmd/auto-pause/auto-pause-${TARGETARCH} /bin/auto-pause # Install dependencies, first from apt, then from release tarballs.