kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

moved test out of functional into integration

pull/13340/head
Steven Powell 2022-01-18 13:46:43 -08:00
parent 9908a1614e
commit 7d1912bc71
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/integration/functional_test.go
View File

@ -2071,7 +2071,7 @@ func startMinikubeWithProxy(ctx context.Context, t *testing.T, profile string, p
memoryFlag = "--memory=6000"
}
// passing --api-server-port so later verify it didn't change in soft start.
startArgs := append([]string{"start", "-p", profile, memoryFlag, fmt.Sprintf("--apiserver-port=%d", apiPortTest), "--wait=all", "--disable-optimizations=true"}, StartArgs()...)
startArgs := append([]string{"start", "-p", profile, memoryFlag, fmt.Sprintf("--apiserver-port=%d", apiPortTest), "--wait=all"}, StartArgs()...)
c := exec.CommandContext(ctx, Target(), startArgs...)
env := os.Environ()
env = append(env, fmt.Sprintf("%s=%s", proxyEnv, addr))
@ -2091,10 +2091,6 @@ func startMinikubeWithProxy(ctx context.Context, t *testing.T, profile string, p
if !strings.Contains(rr.Stderr.String(), want) {
t.Errorf("start stderr=%s, want: *%s*", rr.Stderr.String(), want)
}
if strings.Contains(rr.Stderr.String(), "kubelet.housekeeping-interval=5m") {
t.Error("--disable-optimizations=true is not working, optimizations found")
}
}
// validateVersionCmd asserts `minikube version` command works fine for both --short and --components

6
test/integration/guest_env_test.go
View File

@ -37,11 +37,15 @@ func TestGuestEnvironment(t *testing.T) {
defer CleanupWithLogs(t, profile, cancel)
t.Run("Setup", func(t *testing.T) {
args := append([]string{"start", "-p", profile, "--install-addons=false", "--memory=2048", "--wait=false"}, StartArgs()...)
args := append([]string{"start", "-p", profile, "--install-addons=false", "--memory=2048", "--wait=false", "--disable-optimizations=true"}, StartArgs()...)
rr, err := Run(t, exec.CommandContext(ctx, Target(), args...))
if err != nil {
t.Errorf("failed to start minikube: args %q: %v", rr.Command(), err)
}
if strings.Contains(rr.Stderr.String(), "kubelet.housekeeping-interval=5m") {
t.Error("--disable-optimizations=true is not working, optimizations found")
}
})
// Run as a group so that our defer doesn't happen as tests are runnings