kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

lint

pull/11011/head
Sharif Elgamal 2021-04-06 17:28:22 -07:00
parent 84f2c86a50
commit 782bdae4ed
3 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
hack/jenkins/prbot.sh
View File

@ -1,18 +1,18 @@
#!/bin/bash #!/bin/bash
# Copyright 2021 The Kubernetes Authors All rights reserved. # Copyright 2021 The Kubernetes Authors All rights reserved.
# #
# Licensed under the Apache License, Version 2.0 (the "License"); # Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License. # you may not use this file except in compliance with the License.
# You may obtain a copy of the License at # You may obtain a copy of the License at
# #
# http://www.apache.org/licenses/LICENSE-2.0 # http://www.apache.org/licenses/LICENSE-2.0
# #
# Unless required by applicable law or agreed to in writing, software # Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, # distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
set -x -o pipefail set -x -o pipefail
# Only run this on PRs # Only run this on PRs

2
pkg/minikube/perf/result_manager.go
View File

@ -64,7 +64,7 @@ func (rm *resultManager) averageTime(binary *Binary) float64 {
return average(times) return average(times)
} }
func (rm *resultManager) summarizeResults(binaries []*Binary, driver string) { func (rm *resultManager) summarizeResults(binaries []*Binary) {
// print total and average times // print total and average times
for _, b := range binaries { for _, b := range binaries {
fmt.Printf("Times for %s: ", b.Name()) fmt.Printf("Times for %s: ", b.Name())

2
pkg/minikube/perf/start.go
View File

@ -50,7 +50,7 @@ func CompareMinikubeStart(ctx context.Context, out io.Writer, binaries []*Binary
fmt.Printf("error collecting results for %s driver: %v\n", d, err) fmt.Printf("error collecting results for %s driver: %v\n", d, err)
continue continue
} }
rm.summarizeResults(binaries, d) rm.summarizeResults(binaries)
fmt.Println() fmt.Println()
} }
return nil return nil