From 2ba29cecda78c232219d5db943a8281a9cf07d3c Mon Sep 17 00:00:00 2001 From: Divy Singhvi Date: Fri, 3 Oct 2025 21:48:09 +0530 Subject: [PATCH 1/2] Created warnDriverDeprecated function --- cmd/minikube/cmd/start.go | 43 ++++++++++++++++++++------------------- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index 020cd198a9..fe8198db46 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -308,8 +308,7 @@ func provisionWithDriver(cmd *cobra.Command, ds registry.DriverState, existing * klog.Errorf("Error autoSetOptions : %v", err) } - virtualBoxMacOS13PlusWarning(driverName) - hyperkitDeprecationWarning(driverName) + warnDriverDeprecated(driverName) validateFlags(cmd, driverName) validateUser(driverName) if driverName == oci.Docker { @@ -402,29 +401,31 @@ func provisionWithDriver(cmd *cobra.Command, ds registry.DriverState, existing * }, nil } -func virtualBoxMacOS13PlusWarning(driverName string) { - if !driver.IsVirtualBox(driverName) || !detect.MacOS13Plus() { +// warnDriverDeprecated prints a small deprecation warning if the selected driver is deprecated +func warnDriverDeprecated(driverName string) { + if driverName == "" { return } - out.WarningT(`Due to changes in macOS 13+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'. - https://minikube.sigs.k8s.io/docs/drivers/vfkit/ - https://minikube.sigs.k8s.io/docs/drivers/qemu/ - https://minikube.sigs.k8s.io/docs/drivers/docker/ - For more details on the issue see: https://github.com/kubernetes/minikube/issues/15274 -`) -} -// hyperkitDeprecationWarning prints a deprecation warning for the hyperkit driver -func hyperkitDeprecationWarning(driverName string) { - if !driver.IsHyperKit(driverName) { - return + for _, d := range registry.List() { + if d.Priority != registry.Deprecated { + continue + } + + // match driver name + if d.Name == driverName { + out.WarningT("The '{{.name}}' driver is deprecated and will be removed in a future release.\n You can use alternative drivers: {{.drivers}}.", out.V{"name": d.Name, "drivers": strings.Join(driver.SupportedDrivers(), ", ")}) + return + } + + // match any alias + for _, a := range d.Alias { + if a == driverName { + out.WarningT("The '{{.name}}' driver is deprecated and will be removed in a future release.\n You can use alternative drivers: {{.drivers}}.", out.V{"name": d.Name, "drivers": strings.Join(driver.SupportedDrivers(), ", ")}) + return + } + } } - out.WarningT(`The 'hyperkit' driver is deprecated and will be removed in a future release. - You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'. - https://minikube.sigs.k8s.io/docs/drivers/vfkit/ - https://minikube.sigs.k8s.io/docs/drivers/qemu/ - https://minikube.sigs.k8s.io/docs/drivers/docker/ - `) } func validateBuiltImageVersion(r command.Runner, driverName string) { From 7be0e00a79d34c3736773018004379e8be36141c Mon Sep 17 00:00:00 2001 From: Divy Singhvi Date: Fri, 3 Oct 2025 22:04:40 +0530 Subject: [PATCH 2/2] Code fix --- cmd/minikube/cmd/start.go | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index fe8198db46..bbad5f28cd 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -308,6 +308,7 @@ func provisionWithDriver(cmd *cobra.Command, ds registry.DriverState, existing * klog.Errorf("Error autoSetOptions : %v", err) } + virtualBoxMacOS13PlusWarning(driverName) warnDriverDeprecated(driverName) validateFlags(cmd, driverName) validateUser(driverName) @@ -401,6 +402,18 @@ func provisionWithDriver(cmd *cobra.Command, ds registry.DriverState, existing * }, nil } +func virtualBoxMacOS13PlusWarning(driverName string) { + if !driver.IsVirtualBox(driverName) || !detect.MacOS13Plus() { + return + } + out.WarningT(`Due to changes in macOS 13+ minikube doesn't currently support VirtualBox. You can use alternative drivers such as 'vfkit', 'qemu', or 'docker'. + https://minikube.sigs.k8s.io/docs/drivers/vfkit/ + https://minikube.sigs.k8s.io/docs/drivers/qemu/ + https://minikube.sigs.k8s.io/docs/drivers/docker/ + For more details on the issue see: https://github.com/kubernetes/minikube/issues/15274 +`) +} + // warnDriverDeprecated prints a small deprecation warning if the selected driver is deprecated func warnDriverDeprecated(driverName string) { if driverName == "" {