From 7322fdd5377e66c0d37d6d8b9d6b7972c5c39414 Mon Sep 17 00:00:00 2001
From: Ilya Zuyev <izuyev@google.com>
Date: Mon, 5 Oct 2020 22:11:28 -0700
Subject: [PATCH] Add an integration test for hyperkit driver upgrades

---
 .../driver_install_or_update_test.go          | 83 +++++++++++++++++++
 1 file changed, 83 insertions(+)

diff --git a/test/integration/driver_install_or_update_test.go b/test/integration/driver_install_or_update_test.go
index a36522a5a6..e9d704e978 100644
--- a/test/integration/driver_install_or_update_test.go
+++ b/test/integration/driver_install_or_update_test.go
@@ -28,6 +28,7 @@ import (
 	"github.com/blang/semver"
 
 	"k8s.io/minikube/pkg/minikube/driver"
+	"k8s.io/minikube/pkg/version"
 )
 
 func TestKVMDriverInstallOrUpdate(t *testing.T) {
@@ -173,3 +174,85 @@ func TestHyperKitDriverInstallOrUpdate(t *testing.T) {
 		}
 	}
 }
+
+func TestHyperKitDriverSkipUpgrade(t *testing.T) {
+	if runtime.GOOS != "darwin" {
+		t.Skip("Skip if not darwin.")
+	}
+	MaybeParallel(t)
+	tests := []struct {
+		name             string
+		path             string
+		downloadExpected bool
+	}{
+		{
+			name:             "upgrade-v1.11.0-to-current",
+			path:             filepath.Join(*testdataDir, "hyperkit-driver-version-1.11.0"),
+			downloadExpected: false,
+		},
+		{
+			name:             "upgrade-v1.2.0-to-current",
+			path:             filepath.Join(*testdataDir, "hyperkit-driver-older-version"),
+			downloadExpected: true,
+		},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			originalPath := os.Getenv("PATH")
+			defer func() {
+				if err := os.Setenv("PATH", originalPath); err != nil {
+					t.Errorf("failed to restore PATH: %v", err)
+				}
+			}()
+
+			dir, err := ioutil.TempDir("", tc.name)
+			if err != nil {
+				t.Fatalf("Expected to create tempdir. test: %s, got: %v", tc.name, err)
+			}
+			defer func() {
+				if err := os.RemoveAll(dir); err != nil {
+					t.Errorf("Failed to remove dir %q: %v", dir, err)
+				}
+			}()
+
+			pwd, err := os.Getwd()
+			if err != nil {
+				t.Fatalf("Error not expected when getting working directory. test: %s, got: %v", tc.name, err)
+			}
+
+			driverPath := filepath.Join(pwd, tc.path, "docker-machine-driver-hyperkit")
+			if _, err = os.Stat(driverPath); err != nil {
+				t.Fatalf("Expected driver to exist. test: %s, got: %v", tc.name, err)
+			}
+
+			// change permission to allow driver to be executable
+			if err = os.Chmod(driverPath, 0700); err != nil {
+				t.Fatalf("Expected not expected when changing driver permission. test: %s, got: %v", tc.name, err)
+			}
+
+			if err = os.Setenv("PATH", filepath.Dir(driverPath)); err != nil {
+				t.Fatalf("Unexpected error on SetEn, got: %v", err)
+			}
+			curVersion, err := version.GetSemverVersion()
+			if err != nil {
+				t.Fatalf("Expected new semver. test: %v, got: %v", tc.name, err)
+			}
+
+			if _, err = driver.AssureDriverBinary("hyperkit", dir, curVersion, true); err != nil {
+				t.Fatalf("Failed to update driver to %v. test: %s, got: %v", curVersion, tc.name, err)
+			}
+
+			_, err = os.Stat(filepath.Join(dir, "docker-machine-driver-hyperkit"))
+			if tc.downloadExpected {
+				if err != nil {
+					t.Fatalf("driver downlad expected. test: %s, got: %v", tc.name, err)
+				}
+			} else {
+				if err == nil {
+					t.Fatalf("driver downlad NOT expected. test: %s", tc.name)
+				}
+			}
+		})
+	}
+}