From 7098409bdc96a53a28064da7412c13e1165e79f7 Mon Sep 17 00:00:00 2001 From: Steven Powell Date: Tue, 23 Feb 2021 16:51:40 -0700 Subject: [PATCH] optimized file/dir creation logic --- cmd/minikube/main.go | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/cmd/minikube/main.go b/cmd/minikube/main.go index e13665addf..81f7cc8c55 100644 --- a/cmd/minikube/main.go +++ b/cmd/minikube/main.go @@ -165,17 +165,12 @@ func setLastStartFlags() { return } fp := localpath.LastStartLog() - if err := os.Remove(fp); err != nil && !os.IsNotExist(err) { - klog.Warningf("Unable to delete file %s: %v", err) - } dp := filepath.Dir(fp) - if _, err := os.Stat(dp); err != nil { - if !os.IsNotExist(err) { - klog.Warningf("Unable to get log folder %s: %v", dp, err) - } - if err := os.MkdirAll(dp, 0755); err != nil { - klog.Warningf("Unable to make log folder %s: %v", dp, err) - } + if err := os.MkdirAll(dp, 0755); err != nil { + klog.Warningf("Unable to make log dir %s: %v", dp, err) + } + if _, err := os.Create(fp); err != nil { + klog.Warningf("Unable to create/truncate file %s: %v", fp, err) } if err := pflag.Set("log_file", fp); err != nil { klog.Warningf("Unable to set default flag value for log_file: %v", err)