kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

gitignore: Ignore test/integration/licenses (#21267) 

Running the function tests creates a licenses directory and checks out
the "github.com/hooklift/iso9660" module, which imports
"github.com/c4milo/gotoolkit".

    % git status
    ...

    Untracked files:
      (use "git add <file>..." to include in what will be committed)
            test/integration/licenses/

At this point running go mod tidy will add the gotoolkit module:

    % go mod tidy --diff
    diff current/go.mod tidy/go.mod
    --- current/go.mod
    +++ tidy/go.mod
    @@ -13,6 +13,7 @@
            github.com/Xuanwo/go-locale v1.1.3
            github.com/blang/semver/v4 v4.0.0
            github.com/briandowns/spinner v1.23.2
    +	    github.com/c4milo/gotoolkit v0.0.0-20190525173301-67483a18c17a
            github.com/cenkalti/backoff/v4 v4.3.0
            github.com/cheggaaa/pb/v3 v3.1.7
            github.com/cloudevents/sdk-go/v2 v2.16.0
    ...

"github.com/hooklift/iso9660" does not have a go.mod file, so `go mod
tidy` treats is as part of the main module and update go.mod.

We should find a better place to check out the licenses, maybe a test
temporary directory, but let's start with quick fix: ignore the license
directory, and include it in `make clean`.
pull/21270/head
Nir Soffer 2025-08-09 04:01:51 +03:00 committed by GitHub
parent 6b0b64e1db
commit 6b397d8285
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.gitignore vendored
View File

@ -53,7 +53,8 @@ deploy/iso/minikube-iso/board/minikube/aarch64/rootfs-overlay/version.json
/.vscode /.vscode
test/integration/testdata/minikube-linux-amd64-latest-stable /test/integration/testdata/minikube-linux-amd64-latest-stable
/test/integration/licenses
# hugo # hugo
/public /public

1
Makefile
View File

@ -490,6 +490,7 @@ clean: ## Clean build
rm -f pkg/minikube/translate/translations.go rm -f pkg/minikube/translate/translations.go
rm -rf ./vendor rm -rf ./vendor
rm -rf /tmp/tmp.*.minikube_* rm -rf /tmp/tmp.*.minikube_*
rm -rf test/integration/licenses
.PHONY: gendocs .PHONY: gendocs
gendocs: out/docs/minikube.md ## Generate documentation gendocs: out/docs/minikube.md ## Generate documentation