From 6a6098367970ce1c210c8e3a07cb7a07c69895e6 Mon Sep 17 00:00:00 2001 From: Ilya Zuyev Date: Mon, 21 Sep 2020 23:28:34 -0700 Subject: [PATCH] Show invalid flag diagnostic message to user --- cmd/minikube/cmd/start.go | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index 192d5732f4..652c73afbf 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -1193,12 +1193,18 @@ func validateKubernetesVersion(old *config.ClusterConfig) { // validateBaseImage checks that --base-image is not passed if the drive being in use is KIC (docker/podman) // if so, the function exits the process -func validateBaseImage(baseImage *pflag.Flag, driver string) { - if !validBaseImageFlag(baseImage.Changed, driver) { - exit.Message(reason.Usage, "TODO: image {{.image}} with driver {{.driver}}", +func validateBaseImage(imageFlag *pflag.Flag, driver string) { + if !validBaseImageFlag(imageFlag.Changed, driver) { + exit.Message(reason.Usage, + "flag --{{.imgFlag}} is not available for driver '{{.driver}}'. Did you mean to use '{{.docker}}' or '{{.podman}}' driver instead?\n"+ + "Please use --{{.isoFlag}} flag to configure VM based drivers", out.V{ - "driver": driver, - "image": baseImage.Value, + "imgFlag": imageFlag.Name, + "driver": driver, + "image": imageFlag.Value, + "docker": registry.Docker, + "podman": registry.Podman, + "isoFlag": isoURL, }, ) }