kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

address lint concerns

pull/12885/head
Steven Powell 2021-11-08 09:23:00 -05:00
parent 09328fd571
commit 69aa495d02
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/minikube/bootstrapper/bsutil/kubeadm_test.go
View File

@ -103,10 +103,10 @@ func recentReleases(n int) ([]string, error) {
foundDefault := false foundDefault := false
for _, v := range versions { for _, v := range versions {
if strings.HasPrefix(constants.NewestKubernetesVersion, v) { if strings.HasPrefix(constants.NewestKubernetesVersion, v) { //nolint:gocritic // Complains "constants.NewestKubernetesVersion and v arguments order looks reversed"
foundNewest = true foundNewest = true
} }
if strings.HasPrefix(constants.DefaultKubernetesVersion, v) { if strings.HasPrefix(constants.DefaultKubernetesVersion, v) { //nolint:gocritic // Same as above
foundDefault = true foundDefault = true
} }
} }

2
test/integration/driver_install_or_update_test.go
View File

@ -293,7 +293,7 @@ func prepareTempMinikubeDirWithHyperkitDriver(name, driver string) (string, stri
} }
// try to copy cached files to the temp minikube folder to avoid downloading of iso and preloads // try to copy cached files to the temp minikube folder to avoid downloading of iso and preloads
_ = CopyDir(filepath.Join(localpath.MakeMiniPath("cache")), filepath.Join(mkDir, "cache")) _ = CopyDir(localpath.MakeMiniPath("cache"), filepath.Join(mkDir, "cache"))
// change permission to allow driver to be executable // change permission to allow driver to be executable
if err = os.Chmod(testDriverPath, 0755); err != nil { if err = os.Chmod(testDriverPath, 0755); err != nil {