Merge pull request #14323 from lakshkeswani/master
Don't allow --control-plane=true for node add #14300pull/14369/head
Steven Powell
GitHub
commit
6405bb3185
|
|
@ -50,8 +50,13 @@ var nodeAddCmd = &cobra.Command{
|
|||
|
||||
name := node.Name(len(cc.Nodes) + 1)
|
||||
|
||||
out.Step(style.Happy, "Adding node {{.name}} to cluster {{.cluster}}", out.V{"name": name, "cluster": cc.Name})
|
||||
// for now control-plane feature is not supported
|
||||
if cp {
|
||||
out.Step(style.Unsupported, "Adding a control-plane node is not yet supported, setting control-plane flag to false")
|
||||
cp = false
|
||||
}
|
||||
|
||||
out.Step(style.Happy, "Adding node {{.name}} to cluster {{.cluster}}", out.V{"name": name, "cluster": cc.Name})
|
||||
// TODO: Deal with parameters better. Ideally we should be able to acceot any node-specific minikube start params here.
|
||||
n := config.Node{
|
||||
Name: name,
|
||||
|
|
@ -89,7 +94,7 @@ var nodeAddCmd = &cobra.Command{
|
|||
|
||||
func init() {
|
||||
// TODO(https://github.com/kubernetes/minikube/issues/7366): We should figure out which minikube start flags to actually import
|
||||
nodeAddCmd.Flags().BoolVar(&cp, "control-plane", false, "If true, the node added will also be a control plane in addition to a worker.")
|
||||
nodeAddCmd.Flags().BoolVar(&cp, "control-plane", false, "This flag is currently unsupported.")
|
||||
nodeAddCmd.Flags().BoolVar(&worker, "worker", true, "If true, the added node will be marked for work. Defaults to true.")
|
||||
nodeAddCmd.Flags().Bool(deleteOnFailure, false, "If set, delete the current cluster if start fails and try again. Defaults to false.")
|
||||
|
||||
|
|
|
|||
|
|
@ -55,7 +55,7 @@ minikube node add [flags]
|
|||
### Options
|
||||
|
||||
```
|
||||
--control-plane If true, the node added will also be a control plane in addition to a worker.
|
||||
--control-plane This flag is currently unsupported.
|
||||
--delete-on-failure If set, delete the current cluster if start fails and try again. Defaults to false.
|
||||
--worker If true, the added node will be marked for work. Defaults to true. (default true)
|
||||
```
|
||||
|
|
|
|||
|
|
@ -48,6 +48,7 @@
|
|||
"Add machine IP to NO_PROXY environment variable": "Die IP der Maschine zur NO_PROXY Umgebungsvariable hinzufügen",
|
||||
"Add, delete, or push a local image into minikube": "Lokales Image zu Minikube hinzufügen, löschen oder pushen",
|
||||
"Add, remove, or list additional nodes": "Hinzufügen, Löschen oder auflisten von zusätzlichen Nodes",
|
||||
"Adding a control-plane node is not yet supported, setting control-plane flag to false": "",
|
||||
"Adding node {{.name}} to cluster {{.cluster}}": "Node {{.name}} zu Cluster {{.cluster}} hinzufügen",
|
||||
"Additional help topics": "Weitere Hilfe-Themen",
|
||||
"Adds a node to the given cluster config, and starts it.": "Fügt einen Node zur angegebenen Cluster-Konfiguration hinzu und startet es.",
|
||||
|
|
@ -734,6 +735,7 @@
|
|||
"This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true": "Dies kann auch automatisch erfolgen, indem Sie die env var CHANGE_MINIKUBE_NONE_USER = true setzen",
|
||||
"This control plane is not running! (state={{.state}})": "Diese Kontroll-Ebene läuft nicht! (state={{.state}})",
|
||||
"This driver does not yet work on your architecture. Maybe try --driver=none": "Dieser Treiber funktioniert noch nicht mit dieser Architektur. Versuche --driver=none zu verwenden",
|
||||
"This flag is currently unsupported.": "",
|
||||
"This is a known issue with BTRFS storage driver, there is a workaround, please checkout the issue on GitHub": "Dies ist ein bekanntes Problem mit dem BTRFS Treiber. Es exisitiert ein Workaround. Bitte schaue das GitHub Issue an",
|
||||
"This is unusual - you may want to investigate using \"{{.command}}\"": "Das ist ungewöhnlich - Du könntest versuchen \"{{.command}}\" zu verwenden",
|
||||
"This will keep the existing kubectl context and will create a minikube context.": "Dadurch wird der vorhandene Kubectl-Kontext beibehalten und ein minikube-Kontext erstellt.",
|
||||
|
|
|
|||
|
|
@ -49,6 +49,7 @@
|
|||
"Add machine IP to NO_PROXY environment variable": "Agregar una IP de máquina a la variable de entorno NO_PROXY",
|
||||
"Add, delete, or push a local image into minikube": "Agrega, elimina, o empuja una imagen local dentro de minikube, haciendo (add, delete, push) respectivamente.",
|
||||
"Add, remove, or list additional nodes": "Usa (add, remove, list) para agregar, eliminar o listar nodos adicionales.",
|
||||
"Adding a control-plane node is not yet supported, setting control-plane flag to false": "",
|
||||
"Adding node {{.name}} to cluster {{.cluster}}": "Agregando el nodo {{.name}} al cluster {{.cluster}}.",
|
||||
"Additional help topics": "Temas de ayuda adicionales",
|
||||
"Additional mount options, such as cache=fscache": "Opciones de montaje adicionales, por ejemplo cache=fscache",
|
||||
|
|
@ -358,7 +359,6 @@
|
|||
"If true, print web links to addons' documentation if using --output=list (default).": "",
|
||||
"If true, returns list of profiles faster by skipping validating the status of the cluster.": "",
|
||||
"If true, the added node will be marked for work. Defaults to true.": "",
|
||||
"If true, the node added will also be a control plane in addition to a worker.": "",
|
||||
"If true, will perform potentially dangerous operations. Use with discretion.": "",
|
||||
"If you are running minikube within a VM, consider using --driver=none:": "",
|
||||
"If you are still interested to make {{.driver_name}} driver work. The following suggestions might help you get passed this issue:": "",
|
||||
|
|
@ -738,6 +738,7 @@
|
|||
"This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true": "El proceso se puede automatizar si se define la variable de entorno CHANGE_MINIKUBE_NONE_USER=true",
|
||||
"This control plane is not running! (state={{.state}})": "",
|
||||
"This driver does not yet work on your architecture. Maybe try --driver=none": "",
|
||||
"This flag is currently unsupported.": "",
|
||||
"This is a known issue with BTRFS storage driver, there is a workaround, please checkout the issue on GitHub": "",
|
||||
"This is unusual - you may want to investigate using \"{{.command}}\"": "",
|
||||
"This will keep the existing kubectl context and will create a minikube context.": "Se conservará el contexto de kubectl actual y se creará uno de minikube.",
|
||||
|
|
|
|||
|
|
@ -49,6 +49,7 @@
|
|||
"Add machine IP to NO_PROXY environment variable": "Ajouter l'IP de la machine à la variable d'environnement NO_PROXY",
|
||||
"Add, delete, or push a local image into minikube": "Ajouter, supprimer ou pousser une image locale dans minikube",
|
||||
"Add, remove, or list additional nodes": "Ajouter, supprimer ou lister des nœuds supplémentaires",
|
||||
"Adding a control-plane node is not yet supported, setting control-plane flag to false": "",
|
||||
"Adding node {{.name}} to cluster {{.cluster}}": "Ajout du nœud {{.name}} au cluster {{.cluster}}",
|
||||
"Additional help topics": "Rubriques d'aide supplémentaires",
|
||||
"Additional mount options, such as cache=fscache": "Options de montage supplémentaires, telles que cache=fscache",
|
||||
|
|
@ -710,6 +711,7 @@
|
|||
"This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true": "Cette opération peut également être réalisée en définissant la variable d'environment \"CHANGE_MINIKUBE_NONE_USER=true\".",
|
||||
"This control plane is not running! (state={{.state}})": "Ce plan de contrôle ne fonctionne pas ! (état={{.state}})",
|
||||
"This driver does not yet work on your architecture. Maybe try --driver=none": "Ce pilote ne fonctionne pas encore sur votre architecture. Essayez peut-être --driver=none",
|
||||
"This flag is currently unsupported.": "",
|
||||
"This is a known issue with BTRFS storage driver, there is a workaround, please checkout the issue on GitHub": "Il s'agit d'un problème connu avec le pilote de stockage BTRFS, il existe une solution de contournement, veuillez vérifier le problème sur GitHub",
|
||||
"This is unusual - you may want to investigate using \"{{.command}}\"": "C'est inhabituel - vous voudrez peut-être investiguer en utilisant \"{{.command}}\"",
|
||||
"This will keep the existing kubectl context and will create a minikube context.": "Cela permet de conserver le contexte kubectl existent et de créer un contexte minikube.",
|
||||
|
|
|
|||
|
|
@ -50,6 +50,7 @@
|
|||
"Add machine IP to NO_PROXY environment variable": "マシンの IP アドレスを NO_PROXY 環境変数に追加します",
|
||||
"Add, delete, or push a local image into minikube": "ローカルイメージを minikube に追加、削除、またはプッシュします",
|
||||
"Add, remove, or list additional nodes": "追加のノードを追加、削除またはリストアップします",
|
||||
"Adding a control-plane node is not yet supported, setting control-plane flag to false": "",
|
||||
"Adding node {{.name}} to cluster {{.cluster}}": "{{.name}} ノードを {{.cluster}} クラスターに追加します",
|
||||
"Additional help topics": "追加のトピック",
|
||||
"Additional mount options, such as cache=fscache": "cache=fscache などの追加のマウントオプション",
|
||||
|
|
@ -736,6 +737,7 @@
|
|||
"This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true": "これは環境変数 CHANGE_MINIKUBE_NONE_USER=true を設定して自動的に行うこともできます",
|
||||
"This control plane is not running! (state={{.state}})": "このコントロールプレーンは動作していません！(state={{.state}})",
|
||||
"This driver does not yet work on your architecture. Maybe try --driver=none": "このドライバーはあなたのアーキテクチャではまだ機能しません。もしかしたら、--driver=none を試してみてください",
|
||||
"This flag is currently unsupported.": "",
|
||||
"This is a known issue with BTRFS storage driver, there is a workaround, please checkout the issue on GitHub": "これは BTRFS ストレージドライバーの既知の問題です (回避策があります)。GitHub の issue を確認してください",
|
||||
"This is unusual - you may want to investigate using \"{{.command}}\"": "これは異常です - 「{{.command}}」を使って調査できます",
|
||||
"This will keep the existing kubectl context and will create a minikube context.": "これにより既存の kubectl コンテキストが保持され、minikube コンテキストが作成されます。",
|
||||
|
|
|
|||
|
|
@ -52,6 +52,7 @@
|
|||
"Add or delete an image from the local cache.": "로컬 캐시에 이미지를 추가하거나 삭제합니다",
|
||||
"Add, delete, or push a local image into minikube": "minikube에 로컬 이미지를 추가하거나 삭제, 푸시합니다",
|
||||
"Add, remove, or list additional nodes": "노드를 추가하거나 삭제, 나열합니다",
|
||||
"Adding a control-plane node is not yet supported, setting control-plane flag to false": "",
|
||||
"Adding node {{.name}} to cluster {{.cluster}}": "노드 {{.name}} 를 클러스터 {{.cluster}} 에 추가합니다",
|
||||
"Additional help topics": "",
|
||||
"Additional mount options, such as cache=fscache": "cache=fscache 와 같은 추가적인 마운트 옵션",
|
||||
|
|
@ -375,7 +376,6 @@
|
|||
"If true, print web links to addons' documentation if using --output=list (default).": "",
|
||||
"If true, returns list of profiles faster by skipping validating the status of the cluster.": "",
|
||||
"If true, the added node will be marked for work. Defaults to true.": "",
|
||||
"If true, the node added will also be a control plane in addition to a worker.": "",
|
||||
"If true, will perform potentially dangerous operations. Use with discretion.": "",
|
||||
"If you are running minikube within a VM, consider using --driver=none:": "",
|
||||
"If you are still interested to make {{.driver_name}} driver work. The following suggestions might help you get passed this issue:": "",
|
||||
|
|
@ -741,6 +741,7 @@
|
|||
"This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true": "",
|
||||
"This control plane is not running! (state={{.state}})": "",
|
||||
"This driver does not yet work on your architecture. Maybe try --driver=none": "",
|
||||
"This flag is currently unsupported.": "",
|
||||
"This is a known issue with BTRFS storage driver, there is a workaround, please checkout the issue on GitHub": "",
|
||||
"This is unusual - you may want to investigate using \"{{.command}}\"": "",
|
||||
"This will keep the existing kubectl context and will create a minikube context.": "",
|
||||
|
|
|
|||
|
|
@ -50,6 +50,7 @@
|
|||
"Add machine IP to NO_PROXY environment variable": "Dodaj IP serwera do zmiennej środowiskowej NO_PROXY",
|
||||
"Add, delete, or push a local image into minikube": "Dodaj, usuń lub wypchnij lokalny obraz do minikube",
|
||||
"Add, remove, or list additional nodes": "Dodaj, usuń lub wylistuj pozostałe węzły",
|
||||
"Adding a control-plane node is not yet supported, setting control-plane flag to false": "",
|
||||
"Adding node {{.name}} to cluster {{.cluster}}": "Dodawanie węzła {{.name}} do klastra {{.cluster}}",
|
||||
"Additional help topics": "Dodatkowe tematy pomocy",
|
||||
"Additional mount options, such as cache=fscache": "Dodatkowe opcje montowania, jak na przykład cache=fscache",
|
||||
|
|
@ -361,7 +362,6 @@
|
|||
"If true, print web links to addons' documentation if using --output=list (default).": "",
|
||||
"If true, returns list of profiles faster by skipping validating the status of the cluster.": "",
|
||||
"If true, the added node will be marked for work. Defaults to true.": "",
|
||||
"If true, the node added will also be a control plane in addition to a worker.": "",
|
||||
"If true, will perform potentially dangerous operations. Use with discretion.": "",
|
||||
"If using the none driver, ensure that systemctl is installed": "Jeśli użyto sterownika 'none', upewnij się że systemctl jest zainstalowany",
|
||||
"If you are running minikube within a VM, consider using --driver=none:": "",
|
||||
|
|
@ -752,6 +752,7 @@
|
|||
"This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true": "",
|
||||
"This control plane is not running! (state={{.state}})": "",
|
||||
"This driver does not yet work on your architecture. Maybe try --driver=none": "",
|
||||
"This flag is currently unsupported.": "",
|
||||
"This is a known issue with BTRFS storage driver, there is a workaround, please checkout the issue on GitHub": "",
|
||||
"This is unusual - you may want to investigate using \"{{.command}}\"": "",
|
||||
"This will keep the existing kubectl context and will create a minikube context.": "",
|
||||
|
|
|
|||
|
|
@ -44,6 +44,7 @@
|
|||
"Add image to cache for all running minikube clusters": "",
|
||||
"Add machine IP to NO_PROXY environment variable": "",
|
||||
"Add, remove, or list additional nodes": "",
|
||||
"Adding a control-plane node is not yet supported, setting control-plane flag to false": "",
|
||||
"Adding node {{.name}} to cluster {{.cluster}}": "",
|
||||
"Additional help topics": "",
|
||||
"Adds a node to the given cluster config, and starts it.": "",
|
||||
|
|
@ -328,7 +329,6 @@
|
|||
"If true, print web links to addons' documentation if using --output=list (default).": "",
|
||||
"If true, returns list of profiles faster by skipping validating the status of the cluster.": "",
|
||||
"If true, the added node will be marked for work. Defaults to true.": "",
|
||||
"If true, the node added will also be a control plane in addition to a worker.": "",
|
||||
"If true, will perform potentially dangerous operations. Use with discretion.": "",
|
||||
"If you are running minikube within a VM, consider using --driver=none:": "",
|
||||
"If you are still interested to make {{.driver_name}} driver work. The following suggestions might help you get passed this issue:": "",
|
||||
|
|
@ -683,6 +683,7 @@
|
|||
"This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true": "",
|
||||
"This control plane is not running! (state={{.state}})": "",
|
||||
"This driver does not yet work on your architecture. Maybe try --driver=none": "",
|
||||
"This flag is currently unsupported.": "",
|
||||
"This is a known issue with BTRFS storage driver, there is a workaround, please checkout the issue on GitHub": "",
|
||||
"This is unusual - you may want to investigate using \"{{.command}}\"": "",
|
||||
"This will keep the existing kubectl context and will create a minikube context.": "",
|
||||
|
|
|
|||
|
|
@ -44,6 +44,7 @@
|
|||
"Add image to cache for all running minikube clusters": "",
|
||||
"Add machine IP to NO_PROXY environment variable": "",
|
||||
"Add, remove, or list additional nodes": "",
|
||||
"Adding a control-plane node is not yet supported, setting control-plane flag to false": "",
|
||||
"Adding node {{.name}} to cluster {{.cluster}}": "",
|
||||
"Additional help topics": "",
|
||||
"Adds a node to the given cluster config, and starts it.": "",
|
||||
|
|
@ -328,7 +329,6 @@
|
|||
"If true, print web links to addons' documentation if using --output=list (default).": "",
|
||||
"If true, returns list of profiles faster by skipping validating the status of the cluster.": "",
|
||||
"If true, the added node will be marked for work. Defaults to true.": "",
|
||||
"If true, the node added will also be a control plane in addition to a worker.": "",
|
||||
"If true, will perform potentially dangerous operations. Use with discretion.": "",
|
||||
"If you are running minikube within a VM, consider using --driver=none:": "",
|
||||
"If you are still interested to make {{.driver_name}} driver work. The following suggestions might help you get passed this issue:": "",
|
||||
|
|
@ -683,6 +683,7 @@
|
|||
"This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true": "",
|
||||
"This control plane is not running! (state={{.state}})": "",
|
||||
"This driver does not yet work on your architecture. Maybe try --driver=none": "",
|
||||
"This flag is currently unsupported.": "",
|
||||
"This is a known issue with BTRFS storage driver, there is a workaround, please checkout the issue on GitHub": "",
|
||||
"This is unusual - you may want to investigate using \"{{.command}}\"": "",
|
||||
"This will keep the existing kubectl context and will create a minikube context.": "",
|
||||
|
|
|
|||
|
|
@ -57,6 +57,7 @@
|
|||
"Add machine IP to NO_PROXY environment variable": "将机器IP添加到环境变量 NO_PROXY 中",
|
||||
"Add or delete an image from the local cache.": "在本地缓存中添加或删除 image。",
|
||||
"Add, remove, or list additional nodes": "",
|
||||
"Adding a control-plane node is not yet supported, setting control-plane flag to false": "",
|
||||
"Adding node {{.name}} to cluster {{.cluster}}": "添加节点 {{.name}} 至集群 {{.cluster}}",
|
||||
"Additional help topics": "其他帮助",
|
||||
"Additional mount options, such as cache=fscache": "其他挂载选项，例如：cache=fscache",
|
||||
|
|
@ -433,7 +434,6 @@
|
|||
"If true, print web links to addons' documentation if using --output=list (default).": "",
|
||||
"If true, returns list of profiles faster by skipping validating the status of the cluster.": "",
|
||||
"If true, the added node will be marked for work. Defaults to true.": "",
|
||||
"If true, the node added will also be a control plane in addition to a worker.": "",
|
||||
"If true, will perform potentially dangerous operations. Use with discretion.": "",
|
||||
"If you are running minikube within a VM, consider using --driver=none:": "",
|
||||
"If you are still interested to make {{.driver_name}} driver work. The following suggestions might help you get passed this issue:": "",
|
||||
|
|
@ -840,6 +840,7 @@
|
|||
"This can also be done automatically by setting the env var CHANGE_MINIKUBE_NONE_USER=true": "此操作还可通过设置环境变量 CHANGE_MINIKUBE_NONE_USER=true 自动完成",
|
||||
"This control plane is not running! (state={{.state}})": "",
|
||||
"This driver does not yet work on your architecture. Maybe try --driver=none": "",
|
||||
"This flag is currently unsupported.": "",
|
||||
"This is a known issue with BTRFS storage driver, there is a workaround, please checkout the issue on GitHub": "",
|
||||
"This is unusual - you may want to investigate using \"{{.command}}\"": "",
|
||||
"This will keep the existing kubectl context and will create a minikube context.": "这将保留现有 kubectl 上下文并创建 minikube 上下文。",
|
||||
|
|
|
|||
Loading…
Reference in New Issue