kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Revert comment removal

pull/8051/head
Thomas Stromberg 2020-05-08 17:19:32 -07:00
parent 28d0a465e6
commit 625b316f98
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/integration/functional_test.go
View File

@ -714,6 +714,7 @@ func validateServiceCmd(ctx context.Context, t *testing.T, profile string) {
t.Skipf("test is broken for port-forwarded drivers: https://github.com/kubernetes/minikube/issues/7383") t.Skipf("test is broken for port-forwarded drivers: https://github.com/kubernetes/minikube/issues/7383")
} }
// Test --https --url mode
rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "service", "--namespace=default", "--https", "--url", "hello-node")) rr, err = Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "service", "--namespace=default", "--https", "--url", "hello-node"))
if err != nil { if err != nil {
t.Fatalf("failed to get service url. args %q : %v", rr.Command(), err) t.Fatalf("failed to get service url. args %q : %v", rr.Command(), err)
@ -721,9 +722,10 @@ func validateServiceCmd(ctx context.Context, t *testing.T, profile string) {
if rr.Stderr.String() != "" { if rr.Stderr.String() != "" {
t.Errorf("expected stderr to be empty but got *%q* . args %q", rr.Stderr, rr.Command()) t.Errorf("expected stderr to be empty but got *%q* . args %q", rr.Stderr, rr.Command())
} }
endpoint := strings.TrimSpace(rr.Stdout.String())
endpoint := strings.TrimSpace(rr.Stdout.String())
t.Logf("found endpoint: %s", endpoint) t.Logf("found endpoint: %s", endpoint)
u, err := url.Parse(endpoint) u, err := url.Parse(endpoint)
if err != nil { if err != nil {
t.Fatalf("failed to parse service url endpoint %q: %v", endpoint, err) t.Fatalf("failed to parse service url endpoint %q: %v", endpoint, err)