From 5fc653ba83b4a434361be0114f936b0052e4b038 Mon Sep 17 00:00:00 2001 From: Steven Powell Date: Mon, 26 Sep 2022 15:06:41 -0700 Subject: [PATCH] update experimental message and logic --- cmd/minikube/cmd/start_flags.go | 4 ++-- translations/de.json | 2 +- translations/es.json | 2 +- translations/fr.json | 1 + translations/ja.json | 2 +- translations/ko.json | 2 +- translations/pl.json | 2 +- translations/ru.json | 2 +- translations/strings.txt | 2 +- translations/zh-CN.json | 2 +- 10 files changed, 11 insertions(+), 10 deletions(-) diff --git a/cmd/minikube/cmd/start_flags.go b/cmd/minikube/cmd/start_flags.go index 49ff725f6f..aeec3dc0c6 100644 --- a/cmd/minikube/cmd/start_flags.go +++ b/cmd/minikube/cmd/start_flags.go @@ -483,8 +483,8 @@ func generateNewConfigFromFlags(cmd *cobra.Command, k8sVersion string, rtime str out.WarningT("--network flag is only valid with the docker/podman, KVM and Qemu drivers, it will be ignored") } - if driver.IsQEMU(drvName) && viper.GetString(network) == "socket" { - out.WarningT("Using qemu with --network=socket for 'socket_vmnet' is experimental") + if driver.IsQEMU(drvName) && viper.GetString(network) == "socket_vmnet" { + out.WarningT("Using qemu with 'socket_vmnet' network is experimental") } checkNumaCount(k8sVersion) diff --git a/translations/de.json b/translations/de.json index 197b110afd..7dc9917fc6 100644 --- a/translations/de.json +++ b/translations/de.json @@ -849,7 +849,7 @@ "Using image repository {{.name}}": "Verwenden des Image-Repositorys {{.name}}", "Using image {{.registry}}{{.image}}": "Verwende Image {{.registry}}{{.image}}", "Using image {{.registry}}{{.image}} (global image repository)": "Verwende das Image {{.registry}}{{.image}} (globale Image Repository)", - "Using qemu with --network=socket for 'socket_vmnet' is experimental": "", + "Using qemu with 'socket_vmnet' network is experimental": "", "Using rootless Docker driver was required, but the current Docker does not seem rootless. Try 'docker context use rootless' .": "", "Using rootless driver was required, but the current driver does not seem rootless": "", "Using rootless {{.driver_name}} driver": "", diff --git a/translations/es.json b/translations/es.json index cf6f0d6a90..54780ea521 100644 --- a/translations/es.json +++ b/translations/es.json @@ -850,7 +850,7 @@ "Using image repository {{.name}}": "Utilizando el repositorio de imágenes {{.name}}", "Using image {{.registry}}{{.image}}": "", "Using image {{.registry}}{{.image}} (global image repository)": "", - "Using qemu with --network=socket for 'socket_vmnet' is experimental": "", + "Using qemu with 'socket_vmnet' network is experimental": "", "Using rootless Docker driver was required, but the current Docker does not seem rootless. Try 'docker context use rootless' .": "", "Using rootless driver was required, but the current driver does not seem rootless": "", "Using rootless {{.driver_name}} driver": "", diff --git a/translations/fr.json b/translations/fr.json index 43b5474017..bcb683fbce 100644 --- a/translations/fr.json +++ b/translations/fr.json @@ -822,6 +822,7 @@ "Using image {{.registry}}{{.image}}": "Utilisation de l'image {{.registry}}{{.image}}", "Using image {{.registry}}{{.image}} (global image repository)": "Utilisation de l'image {{.registry}}{{.image}} (référentiel d'images global)", "Using qemu with --network=socket for 'socket_vmnet' is experimental": "L'utilisation de qemu avec --network=socket pour 'socket_vmnet' est expérimentale", + "Using qemu with 'socket_vmnet' network is experimental": "", "Using rootless Docker driver was required, but the current Docker does not seem rootless. Try 'docker context use rootless' .": "L'utilisation du pilote Docker sans root était nécessaire, mais le Docker actuel ne semble pas sans root. Essayez 'docker context use rootless' .", "Using rootless driver was required, but the current driver does not seem rootless": "L'utilisation d'un pilote sans root était nécessaire, mais le pilote actuel ne semble pas sans root", "Using rootless {{.driver_name}} driver": "Utilisation du pilote {{.driver_name}} sans root", diff --git a/translations/ja.json b/translations/ja.json index 723ae2c548..36d6282e19 100644 --- a/translations/ja.json +++ b/translations/ja.json @@ -789,7 +789,7 @@ "Using image repository {{.name}}": "{{.name}} イメージリポジトリーを使用しています", "Using image {{.registry}}{{.image}}": "{{.registry}}{{.image}} イメージを使用しています", "Using image {{.registry}}{{.image}} (global image repository)": "{{.registry}}{{.image}} イメージ (グローバルイメージリポジトリー) を使用しています", - "Using qemu with --network=socket for 'socket_vmnet' is experimental": "", + "Using qemu with 'socket_vmnet' network is experimental": "", "Using rootless Docker driver was required, but the current Docker does not seem rootless. Try 'docker context use rootless' .": "rootless Docker ドライバー使用が必要でしたが、現在の Docker は rootless が必要ないようです。'docker context use rootless' を試してみてください。", "Using rootless driver was required, but the current driver does not seem rootless": "rootless ドライバー使用が必要でしたが、現在のドライバーは rootless が必要ないようです", "Using rootless {{.driver_name}} driver": "rootless {{.driver_name}} ドライバー使用", diff --git a/translations/ko.json b/translations/ko.json index 2052323d15..915e9866be 100644 --- a/translations/ko.json +++ b/translations/ko.json @@ -849,7 +849,7 @@ "Using image repository {{.name}}": "", "Using image {{.registry}}{{.image}}": "", "Using image {{.registry}}{{.image}} (global image repository)": "", - "Using qemu with --network=socket for 'socket_vmnet' is experimental": "", + "Using qemu with 'socket_vmnet' network is experimental": "", "Using rootless Docker driver was required, but the current Docker does not seem rootless. Try 'docker context use rootless' .": "", "Using rootless driver was required, but the current driver does not seem rootless": "", "Using rootless {{.driver_name}} driver": "", diff --git a/translations/pl.json b/translations/pl.json index 9e633e4fc5..d65438d037 100644 --- a/translations/pl.json +++ b/translations/pl.json @@ -859,7 +859,7 @@ "Using image repository {{.name}}": "", "Using image {{.registry}}{{.image}}": "", "Using image {{.registry}}{{.image}} (global image repository)": "", - "Using qemu with --network=socket for 'socket_vmnet' is experimental": "", + "Using qemu with 'socket_vmnet' network is experimental": "", "Using rootless Docker driver was required, but the current Docker does not seem rootless. Try 'docker context use rootless' .": "", "Using rootless driver was required, but the current driver does not seem rootless": "", "Using rootless {{.driver_name}} driver": "", diff --git a/translations/ru.json b/translations/ru.json index 99842d270b..06627a7a5b 100644 --- a/translations/ru.json +++ b/translations/ru.json @@ -785,7 +785,7 @@ "Using image repository {{.name}}": "", "Using image {{.registry}}{{.image}}": "Используется образ {{.registry}}{{.image}}", "Using image {{.registry}}{{.image}} (global image repository)": "", - "Using qemu with --network=socket for 'socket_vmnet' is experimental": "", + "Using qemu with 'socket_vmnet' network is experimental": "", "Using rootless Docker driver was required, but the current Docker does not seem rootless. Try 'docker context use rootless' .": "", "Using rootless driver was required, but the current driver does not seem rootless": "", "Using rootless {{.driver_name}} driver": "", diff --git a/translations/strings.txt b/translations/strings.txt index b3f19a14d1..c8cc4afd1c 100644 --- a/translations/strings.txt +++ b/translations/strings.txt @@ -785,7 +785,7 @@ "Using image repository {{.name}}": "", "Using image {{.registry}}{{.image}}": "", "Using image {{.registry}}{{.image}} (global image repository)": "", - "Using qemu with --network=socket for 'socket_vmnet' is experimental": "", + "Using qemu with 'socket_vmnet' network is experimental": "", "Using rootless Docker driver was required, but the current Docker does not seem rootless. Try 'docker context use rootless' .": "", "Using rootless driver was required, but the current driver does not seem rootless": "", "Using rootless {{.driver_name}} driver": "", diff --git a/translations/zh-CN.json b/translations/zh-CN.json index 022fa9974b..9f1af9a43d 100644 --- a/translations/zh-CN.json +++ b/translations/zh-CN.json @@ -960,7 +960,7 @@ "Using image repository {{.name}}": "正在使用镜像存储库 {{.name}}", "Using image {{.registry}}{{.image}}": "", "Using image {{.registry}}{{.image}} (global image repository)": "", - "Using qemu with --network=socket for 'socket_vmnet' is experimental": "", + "Using qemu with 'socket_vmnet' network is experimental": "", "Using rootless Docker driver was required, but the current Docker does not seem rootless. Try 'docker context use rootless' .": "", "Using rootless driver was required, but the current driver does not seem rootless": "", "Using rootless {{.driver_name}} driver": "",