Create test for mounting with port.

pull/11979/head
Andriy Dzikh 2021-07-14 17:52:21 -07:00
parent 49cd3840d3
commit 5ca1164fb9
1 changed files with 231 additions and 138 deletions

View File

@ -22,11 +22,13 @@ import (
"bytes"
"context"
"fmt"
"io"
"io/ioutil"
"os"
"os/exec"
"path"
"path/filepath"
"regexp"
"runtime"
"strings"
"testing"
@ -56,6 +58,7 @@ func validateMountCmd(ctx context.Context, t *testing.T, profile string) { // no
t.Skip("skipping: mount broken on windows: https://github.com/kubernetes/minikube/issues/8303")
}
t.Run("any-port", func(t *testing.T) {
tempDir, err := ioutil.TempDir("", "mounttest")
defer func() { // clean up tempdir
err := os.RemoveAll(tempDir)
@ -203,4 +206,94 @@ func validateMountCmd(ctx context.Context, t *testing.T, profile string) { // no
if err := os.Remove(p); err != nil {
t.Errorf("failed to remove file %q: %v", p, err)
}
})
t.Run("specific-port", func(t *testing.T) {
tempDir, err := ioutil.TempDir("", "mounttest")
defer func() { // clean up tempdir
err := os.RemoveAll(tempDir)
if err != nil {
t.Errorf("failed to clean up %q temp folder.", tempDir)
}
}()
if err != nil {
t.Fatalf("Unexpected error while creating tempDir: %v", err)
}
ctx, cancel := context.WithTimeout(ctx, Minutes(10))
args := []string{"mount", "-p", profile, fmt.Sprintf("%s:%s", tempDir, guestMount), "--alsologtostderr", "-v=1", "--port", "46464"}
ss, err := Start(t, exec.CommandContext(ctx, Target(), args...))
if err != nil {
t.Fatalf("%v failed: %v", args, err)
}
defer func() {
if t.Failed() {
t.Logf("%q failed, getting debug info...", t.Name())
rr, err := Run(t, exec.Command(Target(), "-p", profile, "ssh", "mount | grep 9p; ls -la /mount-9p; cat /mount-9p/pod-dates"))
if err != nil {
t.Logf("debugging command %q failed : %v", rr.Command(), err)
} else {
t.Logf("(debug) %s:\n%s", rr.Command(), rr.Stdout)
}
}
// Cleanup in advance of future tests
rr, err := Run(t, exec.Command(Target(), "-p", profile, "ssh", "sudo umount -f /mount-9p"))
if err != nil {
t.Logf("%q: %v", rr.Command(), err)
}
ss.Stop(t)
cancel()
if *cleanup {
os.RemoveAll(tempDir)
}
}()
// Block until the mount succeeds to avoid file race
checkMount := func() error {
_, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "ssh", "findmnt -T /mount-9p | grep 9p"))
return err
}
start := time.Now()
if err := retry.Expo(checkMount, time.Millisecond*500, Seconds(15)); err != nil {
// For local testing, allow macOS users to click prompt. If they don't, skip the test.
if runtime.GOOS == "darwin" {
t.Skip("skipping: mount did not appear, likely because macOS requires prompt to allow non-codesigned binaries to listen on non-localhost port")
}
t.Fatalf("/mount-9p did not appear within %s: %v", time.Since(start), err)
}
// Assert that we can access the mount without an error. Display for debugging.
rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "ssh", "--", "ls", "-la", guestMount))
if err != nil {
t.Fatalf("failed verifying accessing to the mount. args %q : %v", rr.Command(), err)
}
t.Logf("guest mount directory contents\n%s", rr.Stdout)
ss.Stop(t)
t.Logf("reading mount text")
mountText := func() string {
str := ""
var err error = nil
for err == nil {
var add string
add, err = ss.Stdout.ReadString(0)
str += add
}
if err != io.EOF {
t.Fatalf("failed to read stdout of mount cmd. err: %v", err)
}
return str
}()
t.Logf("done reading mount text")
match, err := regexp.Match("Bind Address:\\s*[0-9.]+:46464", []byte(mountText))
if err != nil {
t.Fatalf("failed to match regex pattern. err: %v", err)
}
if !match {
t.Fatalf("failed to find bind address with port 46464. Mount command out: \n%v", mountText)
}
})
}