From bc03821826d96ea651b1e193b325ba0dce6d9fba Mon Sep 17 00:00:00 2001 From: Kian-Meng Ang Date: Sat, 29 Jan 2022 08:41:41 +0800 Subject: [PATCH 1/2] Fix typos --- CHANGELOG.md | 30 +++++++++---------- cmd/minikube/cmd/cp.go | 4 +-- cmd/minikube/cmd/start.go | 2 +- cmd/minikube/cmd/status.go | 2 +- cmd/minikube/main.go | 2 +- .../ambassador-operator-crds.yaml.tmpl | 2 +- deploy/addons/olm/crds.yaml.tmpl | 4 +-- ...t.storage.k8s.io_volumesnapshots.yaml.tmpl | 4 +-- .../package/crio-bin-aarch64/crio.conf | 2 +- .../crio-bin-aarch64/crio.conf.default | 2 +- .../public-chart/generate-chart.go | 2 +- hack/jenkins/common.ps1 | 2 +- .../test-flake-chart/compute_flake_rate.go | 2 +- hack/preload-images/generate.go | 2 +- hack/release_notes.sh | 2 +- hack/update/github.go | 4 +-- pkg/drivers/kic/kic.go | 2 +- pkg/drivers/kic/oci/errors.go | 2 +- pkg/drivers/kic/oci/network.go | 2 +- pkg/drivers/kic/oci/network_create.go | 2 +- pkg/drivers/kic/oci/oci.go | 6 ++-- .../bootstrapper/bsutil/kverify/kverify.go | 2 +- pkg/minikube/bootstrapper/kubeadm/kubeadm.go | 4 +-- pkg/minikube/cni/calico.yaml | 2 +- pkg/minikube/command/ssh_runner.go | 2 +- pkg/minikube/config/profile.go | 2 +- pkg/minikube/config/profile_test.go | 2 +- pkg/minikube/constants/constants.go | 2 +- pkg/minikube/cruntime/cri.go | 2 +- pkg/minikube/download/preload.go | 2 +- pkg/minikube/driver/driver.go | 2 +- pkg/minikube/kubeconfig/extension.go | 2 +- pkg/minikube/machine/cache_images.go | 2 +- pkg/minikube/machine/client.go | 2 +- pkg/minikube/machine/delete.go | 2 +- pkg/minikube/machine/fix.go | 2 +- pkg/minikube/machine/stop.go | 2 +- pkg/minikube/node/start.go | 2 +- pkg/minikube/registry/drvs/kvm2/kvm2.go | 4 +-- pkg/minikube/registry/drvs/podman/podman.go | 2 +- pkg/minikube/shell/shell_test.go | 2 +- pkg/trace/trace.go | 2 +- pkg/util/utils_test.go | 2 +- site/README.md | 2 +- .../imageBuild/benchmarkingprocess.md | 8 ++--- .../en/docs/contrib/external-packages.en.md | 2 +- .../content/en/docs/contrib/json_output.en.md | 2 +- site/content/en/docs/contrib/tests.en.md | 2 +- .../en/docs/handbook/troubleshooting.md | 2 +- site/content/en/docs/tutorials/telemetry.md | 2 +- .../en/docs/tutorials/token-auth-file.md | 2 +- site/content/en/docs/tutorials/user_flag.md | 2 +- test/integration/cert_options_test.go | 2 +- test/integration/functional_test.go | 2 +- test/integration/guest_env_test.go | 2 +- test/integration/gvisor_addon_test.go | 2 +- test/integration/multinode_test.go | 4 +-- test/integration/version_upgrade_test.go | 4 +-- 58 files changed, 85 insertions(+), 85 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a400053194..c85acc2bb3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -218,7 +218,7 @@ Check out our [contributions leaderboard](https://minikube.sigs.k8s.io/docs/cont * Resolved regression breaking `minikube start` with hyperkit driver [#13418](https://github.com/kubernetes/minikube/pull/13418) -For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). +For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). Thank you to our contributors for this release! @@ -265,7 +265,7 @@ Version Upgrades: Deprecation: * mount: Remove `--mode` flag [#13162](https://github.com/kubernetes/minikube/pull/13162) -For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). +For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). Thank you to our contributors for this release! @@ -342,7 +342,7 @@ Bug fixes: * fix zsh completion [#12841](https://github.com/kubernetes/minikube/pull/12841) * Fix starting on Windows with VMware driver on non `C:` drive [#12819](https://github.com/kubernetes/minikube/pull/12819) -For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). +For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). Thank you to our contributors for this release! @@ -404,7 +404,7 @@ Version Upgrades: * minikube-ingress-dns: Update image to 0.0.2 [#12730](https://github.com/kubernetes/minikube/pull/12730) * helm-tiller: Update image to v2.17.0 [#12641](https://github.com/kubernetes/minikube/pull/12641) -For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). +For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). Thank you to our contributors for this release! @@ -463,7 +463,7 @@ Fix crio regression: * Roll back default crio cgroup to systemd [#12533](https://github.com/kubernetes/minikube/pull/12533) * Fix template typo [#12532](https://github.com/kubernetes/minikube/pull/12532) -For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). +For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). Thank you to our contributors for this release! @@ -509,7 +509,7 @@ Version Upgrades: * Bump cri-o from v1.20.0 to 1.22.0 [#12425](https://github.com/kubernetes/minikube/pull/12425) * Bump dashboard from v2.1.0 to v2.3.1 and metrics-scraper from v1.0.4 to v1.0.7 [#12475](https://github.com/kubernetes/minikube/pull/12475) -For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). +For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). Thank you to our contributors for this release! @@ -657,7 +657,7 @@ Bugs: Version Upgrades: * bump default kubernetes version to v1.21.2 & newest kubernetes version to v1.22.0-beta.0 [#11901](https://github.com/kubernetes/minikube/pull/11901) -For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). +For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). Thank you to our contributors for this release! @@ -702,7 +702,7 @@ Bugs: * Fix embed-certs global config [#11576](https://github.com/kubernetes/minikube/pull/11576) * Fix a download link to use arm64 instead of amd64 [#11653](https://github.com/kubernetes/minikube/pull/11653) * fix downloading duplicate base image [#11690](https://github.com/kubernetes/minikube/pull/11690) -* fix multi-node loosing track of nodes after second restart [#11731](https://github.com/kubernetes/minikube/pull/11731) +* fix multi-node losing track of nodes after second restart [#11731](https://github.com/kubernetes/minikube/pull/11731) * gcp-auth: do not override existing environment variables in pods [#11665](https://github.com/kubernetes/minikube/pull/11665) Minor improvements: @@ -710,7 +710,7 @@ Minor improvements: * Allow running amd64 binary on M1 [#11674](https://github.com/kubernetes/minikube/pull/11674) * improve containerd experience on cgroup v2 [#11632](https://github.com/kubernetes/minikube/pull/11632) * Improve French locale [#11728](https://github.com/kubernetes/minikube/pull/11728) -* Fix UI error for stoppping systemd service [#11667](https://github.com/kubernetes/minikube/pull/11667) +* Fix UI error for stopping systemd service [#11667](https://github.com/kubernetes/minikube/pull/11667) * international languages: allow using LC_ALL env to set local language for windows [#11721](https://github.com/kubernetes/minikube/pull/11721) * Change registery_mirror to registery-mirror [#11678](https://github.com/kubernetes/minikube/pull/11678) @@ -719,7 +719,7 @@ Version Upgrades: * ISO: Upgrade podman to 3.1.2 [#11704](https://github.com/kubernetes/minikube/pull/11704) * Upgrade Buildroot to 2021.02 LTS with Linux 4.19 [#11688](https://github.com/kubernetes/minikube/pull/11688) -For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). +For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). Thank you to our contributors for this release! @@ -756,7 +756,7 @@ Thank you to our triage members for this release! * add more polish translations [#11587](https://github.com/kubernetes/minikube/pull/11587) * Modify MetricsServer to use v1 api version (instead of v1beta1). [#11584](https://github.com/kubernetes/minikube/pull/11584) -For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). +For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). Thank you to our contributors for this release! @@ -805,7 +805,7 @@ Version Upgrades: * containerd: upgrade `io.containerd.runtime.v1.linux` to `io.containerd.runc.v2` (suppot cgroup v2) [#11325](https://github.com/kubernetes/minikube/pull/11325) * metallb-addon: Update metallb from 0.8.2 to 0.9.6 [#11410](https://github.com/kubernetes/minikube/pull/11410) -For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). +For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). Thank you to our contributors for this release! @@ -869,7 +869,7 @@ Version Upgrades: * Update olm addon to v0.17.0 [#10947](https://github.com/kubernetes/minikube/pull/10947) * Update newest supported Kubernetes version to v1.22.0-alpha.1 [#11287](https://github.com/kubernetes/minikube/pull/11287) -For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). +For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md). Thank you to our contributors for this release! @@ -1237,7 +1237,7 @@ Minor Improvements: Bug Fixes: -* Snap package manger: fix cert copy issue [#10042](https://github.com/kubernetes/minikube/pull/10042) +* Snap package manager: fix cert copy issue [#10042](https://github.com/kubernetes/minikube/pull/10042) * Ignore non-socks5 ALL_PROXY env var when checking docker status [#10109](https://github.com/kubernetes/minikube/pull/10109) * Docker-env: avoid race condition in bootstrap certs for parallel runs [#10118](https://github.com/kubernetes/minikube/pull/10118) * Fix 'profile list' for multi-node clusters [#9955](https://github.com/kubernetes/minikube/pull/9955) @@ -2106,7 +2106,7 @@ Improvements: * Behavior change: start with no arguments uses existing cluster config [#7449](https://github.com/kubernetes/minikube/pull/7449) * conformance: add --wait=all, reduce quirks [#7716](https://github.com/kubernetes/minikube/pull/7716) * Upgrade minimum supported k8s version to v1.12 [#7723](https://github.com/kubernetes/minikube/pull/7723) -* Add default CNI network for running wth podman [#7754](https://github.com/kubernetes/minikube/pull/7754) +* Add default CNI network for running with podman [#7754](https://github.com/kubernetes/minikube/pull/7754) * Behavior change: fallback to alternate drivers on failure [#7389](https://github.com/kubernetes/minikube/pull/7389) * Add registry addon feature for docker on mac/windows [#7603](https://github.com/kubernetes/minikube/pull/7603) * Check node pressure & new option "node_ready" for --wait flag [#7752](https://github.com/kubernetes/minikube/pull/7752) diff --git a/cmd/minikube/cmd/cp.go b/cmd/minikube/cmd/cp.go index d4269d8c9c..012b0f5976 100644 --- a/cmd/minikube/cmd/cp.go +++ b/cmd/minikube/cmd/cp.go @@ -66,7 +66,7 @@ Example Command : "minikube cp a.txt /home/docker/b.txt" + if dst.node != "" { runner = remoteCommandRunner(&co, dst.node) } else if src.node == "" { - // if node name not explicitly specfied in both of source and target, + // if node name not explicitly specified in both of source and target, // consider target is controlpanel node for backward compatibility. runner = co.CP.Runner } else { @@ -158,7 +158,7 @@ func validateArgs(src, dst *remotePath) { exit.Message(reason.Usage, "Target {{.path}} can not be empty", out.V{"path": dst.path}) } - // if node name not explicitly specfied in both of source and target, + // if node name not explicitly specified in both of source and target, // consider target node is controlpanel for backward compatibility. if src.node == "" && dst.node == "" && !strings.HasPrefix(dst.path, "/") { exit.Message(reason.Usage, `Target must be an absolute Path. Relative Path is not allowed (example: "minikube:/home/docker/copied.txt")`) diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index afee89071a..d34f522975 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -1574,7 +1574,7 @@ func validateKubernetesVersion(old *config.ClusterConfig) { zeroVersion := semver.MustParse(strings.TrimPrefix(constants.NoKubernetesVersion, version.VersionPrefix)) if nvs.Equals(zeroVersion) { - klog.Infof("No Kuberentes version set for minikube, setting Kubernetes version to %s", constants.NoKubernetesVersion) + klog.Infof("No Kubernetes version set for minikube, setting Kubernetes version to %s", constants.NoKubernetesVersion) return } if nvs.Major > newestVersion.Major { diff --git a/cmd/minikube/cmd/status.go b/cmd/minikube/cmd/status.go index 67d6ac7242..9e9e1c322c 100644 --- a/cmd/minikube/cmd/status.go +++ b/cmd/minikube/cmd/status.go @@ -293,7 +293,7 @@ func writeStatusesAtInterval(duration time.Duration, api libmachine.API, cc *con } } -// exitCode calcluates the appropriate exit code given a set of status messages +// exitCode calculates the appropriate exit code given a set of status messages func exitCode(statuses []*Status) int { c := 0 for _, st := range statuses { diff --git a/cmd/minikube/main.go b/cmd/minikube/main.go index b7a56d375a..09dbe85f93 100644 --- a/cmd/minikube/main.go +++ b/cmd/minikube/main.go @@ -180,7 +180,7 @@ func logFileName(dir string, logIdx int64) string { // setFlags sets the flags func setFlags(parse bool) { - // parse flags beyond subcommand - get aroung go flag 'limitations': + // parse flags beyond subcommand - get around go flag 'limitations': // "Flag parsing stops just before the first non-flag argument" (ref: https://pkg.go.dev/flag#hdr-Command_line_flag_syntax) pflag.CommandLine.ParseErrorsWhitelist.UnknownFlags = true pflag.CommandLine.AddGoFlagSet(flag.CommandLine) diff --git a/deploy/addons/ambassador/ambassador-operator-crds.yaml.tmpl b/deploy/addons/ambassador/ambassador-operator-crds.yaml.tmpl index b8d52b3b89..b6a0d8a0f4 100644 --- a/deploy/addons/ambassador/ambassador-operator-crds.yaml.tmpl +++ b/deploy/addons/ambassador/ambassador-operator-crds.yaml.tmpl @@ -91,7 +91,7 @@ spec: instead of [AES](https://www.getambassador.io/docs/latest/topics/install/). Default is false which means it installs AES by default. TODO: 1. AES/AOSS is not installed and the user installs using `installOSS: - true`, then we straightaway install AOSS. 2. AOSS is installed via + true`, then we straight away install AOSS. 2. AOSS is installed via operator and the user sets `installOSS: false`, then we perform the migration as detailed here - https://www.getambassador.io/docs/latest/topics/install/upgrade-to-edge-stack/ 3. AES is installed and the user sets `installOSS: true`, then we diff --git a/deploy/addons/olm/crds.yaml.tmpl b/deploy/addons/olm/crds.yaml.tmpl index 44811eb989..6c4a68171d 100644 --- a/deploy/addons/olm/crds.yaml.tmpl +++ b/deploy/addons/olm/crds.yaml.tmpl @@ -3674,7 +3674,7 @@ spec: description: TopologyKey is the key of node labels. Nodes that have a label with this key and identical values are considered to be in the same topology. We consider each as a "bucket", and try to put balanced number of pods into each bucket. It's a required field. type: string whenUnsatisfiable: - description: 'WhenUnsatisfiable indicates how to deal with a pod if it doesn''t satisfy the spread constraint. - DoNotSchedule (default) tells the scheduler not to schedule it. - ScheduleAnyway tells the scheduler to schedule the pod in any location, but giving higher precedence to topologies that would help reduce the skew. A constraint is considered "Unsatisfiable" for an incoming pod if and only if every possible node assigment for that pod would violate "MaxSkew" on some topology. For example, in a 3-zone cluster, MaxSkew is set to 1, and pods with the same labelSelector spread as 3/1/1: | zone1 | zone2 | zone3 | | P P P | P | P | If WhenUnsatisfiable is set to DoNotSchedule, incoming pod can only be scheduled to zone2(zone3) to become 3/2/1(3/1/2) as ActualSkew(2-1) on zone2(zone3) satisfies MaxSkew(1). In other words, the cluster can still be imbalanced, but scheduler won''t make it *more* imbalanced. It''s a required field.' + description: 'WhenUnsatisfiable indicates how to deal with a pod if it doesn''t satisfy the spread constraint. - DoNotSchedule (default) tells the scheduler not to schedule it. - ScheduleAnyway tells the scheduler to schedule the pod in any location, but giving higher precedence to topologies that would help reduce the skew. A constraint is considered "Unsatisfiable" for an incoming pod if and only if every possible node assignment for that pod would violate "MaxSkew" on some topology. For example, in a 3-zone cluster, MaxSkew is set to 1, and pods with the same labelSelector spread as 3/1/1: | zone1 | zone2 | zone3 | | P P P | P | P | If WhenUnsatisfiable is set to DoNotSchedule, incoming pod can only be scheduled to zone2(zone3) to become 3/2/1(3/1/2) as ActualSkew(2-1) on zone2(zone3) satisfies MaxSkew(1). In other words, the cluster can still be imbalanced, but scheduler won''t make it *more* imbalanced. It''s a required field.' type: string x-kubernetes-list-map-keys: - topologyKey @@ -4678,7 +4678,7 @@ spec: nativeAPIs: type: array items: - description: GroupVersionKind unambiguously identifies a kind. It doesn't anonymously include GroupVersion to avoid automatic coersion. It doesn't use a GroupVersion to avoid custom marshalling + description: GroupVersionKind unambiguously identifies a kind. It doesn't anonymously include GroupVersion to avoid automatic coercion. It doesn't use a GroupVersion to avoid custom marshalling type: object required: - group diff --git a/deploy/addons/volumesnapshots/snapshot.storage.k8s.io_volumesnapshots.yaml.tmpl b/deploy/addons/volumesnapshots/snapshot.storage.k8s.io_volumesnapshots.yaml.tmpl index 9153c660e2..9111ecc009 100644 --- a/deploy/addons/volumesnapshots/snapshot.storage.k8s.io_volumesnapshots.yaml.tmpl +++ b/deploy/addons/volumesnapshots/snapshot.storage.k8s.io_volumesnapshots.yaml.tmpl @@ -107,7 +107,7 @@ spec: format: date-time type: string error: - description: error is the last observed error during snapshot creation, if any. This field could be helpful to upper level controllers(i.e., application controller) to decide whether they should continue on waiting for the snapshot to be created based on the type of error reported. The snapshot controller will keep retrying when an error occurrs during the snapshot creation. Upon success, this error field will be cleared. + description: error is the last observed error during snapshot creation, if any. This field could be helpful to upper level controllers(i.e., application controller) to decide whether they should continue on waiting for the snapshot to be created based on the type of error reported. The snapshot controller will keep retrying when an error occurs during the snapshot creation. Upon success, this error field will be cleared. properties: message: description: 'message is a string detailing the encountered error during snapshot creation if specified. NOTE: message may be logged, and it should not contain sensitive information.' @@ -206,7 +206,7 @@ spec: format: date-time type: string error: - description: error is the last observed error during snapshot creation, if any. This field could be helpful to upper level controllers(i.e., application controller) to decide whether they should continue on waiting for the snapshot to be created based on the type of error reported. The snapshot controller will keep retrying when an error occurrs during the snapshot creation. Upon success, this error field will be cleared. + description: error is the last observed error during snapshot creation, if any. This field could be helpful to upper level controllers(i.e., application controller) to decide whether they should continue on waiting for the snapshot to be created based on the type of error reported. The snapshot controller will keep retrying when an error occurs during the snapshot creation. Upon success, this error field will be cleared. properties: message: description: 'message is a string detailing the encountered error during snapshot creation if specified. NOTE: message may be logged, and it should not contain sensitive information.' diff --git a/deploy/iso/minikube-iso/arch/aarch64/package/crio-bin-aarch64/crio.conf b/deploy/iso/minikube-iso/arch/aarch64/package/crio-bin-aarch64/crio.conf index fafaed67bc..110152f9c3 100644 --- a/deploy/iso/minikube-iso/arch/aarch64/package/crio-bin-aarch64/crio.conf +++ b/deploy/iso/minikube-iso/arch/aarch64/package/crio-bin-aarch64/crio.conf @@ -203,7 +203,7 @@ pids_limit = 1024 # limit is never exceeded. log_size_max = -1 -# Whether container output should be logged to journald in addition to the kuberentes log file +# Whether container output should be logged to journald in addition to the kubernetes log file log_to_journald = false # Path to directory in which container exit files are written to by conmon. diff --git a/deploy/iso/minikube-iso/arch/aarch64/package/crio-bin-aarch64/crio.conf.default b/deploy/iso/minikube-iso/arch/aarch64/package/crio-bin-aarch64/crio.conf.default index 25debfab9f..1a8ddfc3a5 100644 --- a/deploy/iso/minikube-iso/arch/aarch64/package/crio-bin-aarch64/crio.conf.default +++ b/deploy/iso/minikube-iso/arch/aarch64/package/crio-bin-aarch64/crio.conf.default @@ -203,7 +203,7 @@ pids_limit = 1024 # limit is never exceeded. log_size_max = -1 -# Whether container output should be logged to journald in addition to the kuberentes log file +# Whether container output should be logged to journald in addition to the kubernetes log file log_to_journald = false # Path to directory in which container exit files are written to by conmon. diff --git a/hack/benchmark/time-to-k8s/public-chart/generate-chart.go b/hack/benchmark/time-to-k8s/public-chart/generate-chart.go index bbaec8a7e9..897783595d 100644 --- a/hack/benchmark/time-to-k8s/public-chart/generate-chart.go +++ b/hack/benchmark/time-to-k8s/public-chart/generate-chart.go @@ -250,7 +250,7 @@ func createWeeklyChart(benchmarks []benchmark, chartOutputPath string) { if i == len(benchmarks) { break } - // try running this benchmark again, this is needed incase there's a week without any benchmarks + // try running this benchmark again, this is needed in case there's a week without any benchmarks i-- continue } diff --git a/hack/jenkins/common.ps1 b/hack/jenkins/common.ps1 index dc8418a6ae..668886f40d 100644 --- a/hack/jenkins/common.ps1 +++ b/hack/jenkins/common.ps1 @@ -118,7 +118,7 @@ echo $description #Upload logs to gcs If($env:EXTERNAL -eq "yes"){ # If we're not already in GCP, we won't have credentials to upload to GCS - # Instad, move logs to a predictable spot Jenkins can find and upload itself + # Instead, move logs to a predictable spot Jenkins can find and upload itself mkdir -p test_reports cp testout.txt test_reports/out.txt cp testout.json test_reports/out.json diff --git a/hack/jenkins/test-flake-chart/compute_flake_rate.go b/hack/jenkins/test-flake-chart/compute_flake_rate.go index 1ab72a2ecb..03142cef2b 100644 --- a/hack/jenkins/test-flake-chart/compute_flake_rate.go +++ b/hack/jenkins/test-flake-chart/compute_flake_rate.go @@ -105,7 +105,7 @@ func readData(file io.Reader) []testEntry { } } if len(fields) != 9 { - fmt.Printf("Found line with wrong number of columns. Expectd 9, but got %d - skipping\n", len(fields)) + fmt.Printf("Found line with wrong number of columns. Expected 9, but got %d - skipping\n", len(fields)) continue } previousLine = fields diff --git a/hack/preload-images/generate.go b/hack/preload-images/generate.go index b5947b35e4..0744d3fa1f 100644 --- a/hack/preload-images/generate.go +++ b/hack/preload-images/generate.go @@ -87,7 +87,7 @@ func generateTarball(kubernetesVersion, containerRuntime, tarballFilename string Type: containerRuntime, Runner: runner, ImageRepository: "", - KubernetesVersion: sv, // this is just to satisfy cruntime and shouldnt matter what version. + KubernetesVersion: sv, // this is just to satisfy cruntime and shouldn't matter what version. } cr, err := cruntime.New(co) if err != nil { diff --git a/hack/release_notes.sh b/hack/release_notes.sh index 9e85e8499f..ade4ed16f5 100755 --- a/hack/release_notes.sh +++ b/hack/release_notes.sh @@ -41,7 +41,7 @@ recent_date=$(git log -1 --format=%as $recent) "${DIR}/release-notes" kubernetes minikube --since $recent echo "" -echo "For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md)." +echo "For a more detailed changelog, including changes occurring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md)." echo "" echo "Thank you to our contributors for this release!" diff --git a/hack/update/github.go b/hack/update/github.go index d2ed8221f1..b49bca56ac 100644 --- a/hack/update/github.go +++ b/hack/update/github.go @@ -131,7 +131,7 @@ func ghCreatePR(ctx context.Context, owner, repo, base, branch, title string, is klog.Fatalf("Unable to parse schema: %v\n%s", err, pretty) } modifiable := true - pr, _, err := ghc.PullRequests.Create(ctx, owner, repo, &github.NewPullRequest{ + pr, _, err := ghc.pull requests.Create(ctx, owner, repo, &github.NewPullRequest{ Title: github.String(title), Head: github.String(*fork.Owner.Login + ":" + prBranch), Base: github.String(base), @@ -144,7 +144,7 @@ func ghCreatePR(ctx context.Context, owner, repo, base, branch, title string, is return pr, nil } -// ghFindPR returns URL of the PR if found in the given GitHub ower/repo base and any error occurred. +// ghFindPR returns URL of the PR if found in the given GitHub owner/repo base and any error occurred. func ghFindPR(ctx context.Context, title, owner, repo, base, token string) (url string, err error) { ghc := ghClient(ctx, token) diff --git a/pkg/drivers/kic/kic.go b/pkg/drivers/kic/kic.go index 8c71743277..7ea6739868 100644 --- a/pkg/drivers/kic/kic.go +++ b/pkg/drivers/kic/kic.go @@ -343,7 +343,7 @@ func (d *Driver) Kill() error { klog.Warningf("couldn't shutdown the container, will continue with kill anyways: %v", err) } - cr := command.NewExecRunner(false) // using exec runner for interacting with dameon. + cr := command.NewExecRunner(false) // using exec runner for interacting with daemon. if _, err := cr.RunCmd(oci.PrefixCmd(exec.Command(d.NodeConfig.OCIBinary, "kill", d.MachineName))); err != nil { return errors.Wrapf(err, "killing %q", d.MachineName) } diff --git a/pkg/drivers/kic/oci/errors.go b/pkg/drivers/kic/oci/errors.go index 832500b53e..a1967ca1b2 100644 --- a/pkg/drivers/kic/oci/errors.go +++ b/pkg/drivers/kic/oci/errors.go @@ -63,7 +63,7 @@ var ErrNetworkSubnetTaken = errors.New("subnet is taken") // ErrNetworkNotFound is when given network was not found var ErrNetworkNotFound = errors.New("kic network not found") -// ErrNetworkGatewayTaken is when given network gatway is taken +// ErrNetworkGatewayTaken is when given network gateway is taken var ErrNetworkGatewayTaken = errors.New("network gateway is taken") // ErrNetworkInUse is when trying to delete a network which is attached to another container diff --git a/pkg/drivers/kic/oci/network.go b/pkg/drivers/kic/oci/network.go index da73ff26ad..8486fa6989 100644 --- a/pkg/drivers/kic/oci/network.go +++ b/pkg/drivers/kic/oci/network.go @@ -66,7 +66,7 @@ func RoutableHostIPFromInside(ociBin string, clusterName string, containerName s info, err := containerNetworkInspect(ociBin, clusterName) if err != nil { if errors.Is(err, ErrNetworkNotFound) { - klog.Infof("The container %s is not attached to a network, this could be because the cluster was created by minikube /dev/null ``` -For instance after running `minikube start`, the above comamnd will show: +For instance after running `minikube start`, the above command will show: `-rw-r--r-- 1 user grp 718 Aug 18 12:40 /var/folders/n1/qxvd9kc/T//minikube_start_dc950831e1a232e0318a6d6ca82aaf4f4a8a048b_0.log` diff --git a/site/content/en/docs/tutorials/telemetry.md b/site/content/en/docs/tutorials/telemetry.md index b3dc9ab3a3..29de8455f5 100644 --- a/site/content/en/docs/tutorials/telemetry.md +++ b/site/content/en/docs/tutorials/telemetry.md @@ -7,7 +7,7 @@ date: 2020-11-24 ## Overview -minikube provides telemetry suppport via [OpenTelemetry tracing](https://opentelemetry.io/about/) to collect trace data for `minikube start`. +minikube provides telemetry support via [OpenTelemetry tracing](https://opentelemetry.io/about/) to collect trace data for `minikube start`. Currently, minikube supports the following exporters for tracing data: diff --git a/site/content/en/docs/tutorials/token-auth-file.md b/site/content/en/docs/tutorials/token-auth-file.md index e1d105093e..4b3cf7485e 100644 --- a/site/content/en/docs/tutorials/token-auth-file.md +++ b/site/content/en/docs/tutorials/token-auth-file.md @@ -9,7 +9,7 @@ description: > ## Overview -A [static token file](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#static-token-file) can be used to ensure only authenticated users access the API server. As minikube nodes are run in VMs/containers, this adds a complication to ensuring this token file is accessable to the node. This tutorial explains how to configure a static token file. +A [static token file](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#static-token-file) can be used to ensure only authenticated users access the API server. As minikube nodes are run in VMs/containers, this adds a complication to ensuring this token file is accessible to the node. This tutorial explains how to configure a static token file. ## Tutorial diff --git a/site/content/en/docs/tutorials/user_flag.md b/site/content/en/docs/tutorials/user_flag.md index 55e8ee4752..c0bf2846e5 100644 --- a/site/content/en/docs/tutorials/user_flag.md +++ b/site/content/en/docs/tutorials/user_flag.md @@ -46,7 +46,7 @@ Here you can see that passing `--user=mary` overwrote the OS user with `mary` as ## How do I use minikube in a script? -If you are using minikube in a script or plugin it is recommeneded to add `--user=your_script_name` to all operations. +If you are using minikube in a script or plugin it is recommended to add `--user=your_script_name` to all operations. Example: ``` diff --git a/test/integration/cert_options_test.go b/test/integration/cert_options_test.go index 8dd842dad4..101b5c01d3 100644 --- a/test/integration/cert_options_test.go +++ b/test/integration/cert_options_test.go @@ -103,7 +103,7 @@ func TestCertOptions(t *testing.T) { } if !strings.Contains(rr.Stdout.String(), "8555") { - t.Errorf("Internal minikube kubeconfig (admin.conf) does not containe the right api port. %s", rr.Output()) + t.Errorf("Internal minikube kubeconfig (admin.conf) does not contains the right api port. %s", rr.Output()) } } diff --git a/test/integration/functional_test.go b/test/integration/functional_test.go index a3109b1b70..cbe2d7614c 100644 --- a/test/integration/functional_test.go +++ b/test/integration/functional_test.go @@ -94,7 +94,7 @@ func TestFunctional(t *testing.T) { {"CopySyncFile", setupFileSync}, // Set file for the file sync test case {"StartWithProxy", validateStartWithProxy}, // Set everything else up for success {"AuditLog", validateAuditAfterStart}, // check audit feature works - {"SoftStart", validateSoftStart}, // do a soft start. ensure config didnt change. + {"SoftStart", validateSoftStart}, // do a soft start. ensure config didn't change. {"KubeContext", validateKubeContext}, // Racy: must come immediately after "minikube start" {"KubectlGetPods", validateKubectlGetPods}, // Make sure apiserver is up {"CacheCmd", validateCacheCmd}, // Caches images needed for subsequent tests because of proxy diff --git a/test/integration/guest_env_test.go b/test/integration/guest_env_test.go index 6791ce4895..34f4c13d6b 100644 --- a/test/integration/guest_env_test.go +++ b/test/integration/guest_env_test.go @@ -27,7 +27,7 @@ import ( "k8s.io/minikube/pkg/minikube/vmpath" ) -// TestGuestEnvironment verifies files and packges installed inside minikube ISO/Base image +// TestGuestEnvironment verifies files and packages installed inside minikube ISO/Base image func TestGuestEnvironment(t *testing.T) { MaybeParallel(t) diff --git a/test/integration/gvisor_addon_test.go b/test/integration/gvisor_addon_test.go index c07f7f9729..28893de9ed 100644 --- a/test/integration/gvisor_addon_test.go +++ b/test/integration/gvisor_addon_test.go @@ -90,7 +90,7 @@ func TestGvisorAddon(t *testing.T) { // Ensure that workloads survive a restart rr, err = Run(t, exec.CommandContext(ctx, Target(), "stop", "-p", profile)) if err != nil { - t.Fatalf("faild stopping minikube. args %q : %v", rr.Command(), err) + t.Fatalf("failed stopping minikube. args %q : %v", rr.Command(), err) } rr, err = Run(t, exec.CommandContext(ctx, Target(), startArgs...)) diff --git a/test/integration/multinode_test.go b/test/integration/multinode_test.go index 6079278dd4..d4dbd7e1dc 100644 --- a/test/integration/multinode_test.go +++ b/test/integration/multinode_test.go @@ -444,7 +444,7 @@ func validateNameConflict(ctx context.Context, t *testing.T, profile string) { } curNodeNum := strings.Count(rr.Stdout.String(), profile) - // Start new profile. It's expected failture + // Start new profile. It's expected failure profileName := fmt.Sprintf("%s-m0%d", profile, curNodeNum) startArgs := append([]string{"start", "-p", profileName}, StartArgs()...) rr, err = Run(t, exec.CommandContext(ctx, Target(), startArgs...)) @@ -460,7 +460,7 @@ func validateNameConflict(ctx context.Context, t *testing.T, profile string) { t.Errorf("failed to start profile. args %q : %v", rr.Command(), err) } - // Add a node to the current cluster. It's expected failture + // Add a node to the current cluster. It's expected failure addArgs := []string{"node", "add", "-p", profile} rr, err = Run(t, exec.CommandContext(ctx, Target(), addArgs...)) if err == nil { diff --git a/test/integration/version_upgrade_test.go b/test/integration/version_upgrade_test.go index 7e3b7d4aa7..8187f58411 100644 --- a/test/integration/version_upgrade_test.go +++ b/test/integration/version_upgrade_test.go @@ -108,7 +108,7 @@ func TestRunningBinaryUpgrade(t *testing.T) { c := exec.CommandContext(ctx, tf.Name(), args...) var legacyEnv []string // replace the global KUBECONFIG with a fresh kubeconfig - // because for minikube<1.17.0 it can not read the new kubeconfigs that have extra "Extenions" block + // because for minikube<1.17.0 it can not read the new kubeconfigs that have extra "Extensions" block // see: https://github.com/kubernetes/minikube/issues/10210 for _, e := range os.Environ() { if !strings.Contains(e, "KUBECONFIG") { // get all global envs except the Kubeconfig which is used by new versions of minikubes @@ -171,7 +171,7 @@ func TestStoppedBinaryUpgrade(t *testing.T) { c := exec.CommandContext(ctx, tf.Name(), args...) var legacyEnv []string // replace the global KUBECONFIG with a fresh kubeconfig - // because for minikube<1.17.0 it can not read the new kubeconfigs that have extra "Extenions" block + // because for minikube<1.17.0 it can not read the new kubeconfigs that have extra "Extensions" block // see: https://github.com/kubernetes/minikube/issues/10210 for _, e := range os.Environ() { if !strings.Contains(e, "KUBECONFIG") { // get all global envs except the Kubeconfig which is used by new versions of minikubes From cfa620c26ebf1e7ba8b82dbb53535e717d405127 Mon Sep 17 00:00:00 2001 From: Steven Powell Date: Fri, 10 Jun 2022 15:36:18 -0700 Subject: [PATCH 2/2] run make generate-docs --- hack/update/github.go | 2 +- translations/de.json | 1 - translations/es.json | 2 +- translations/fr.json | 1 + translations/ja.json | 1 + translations/ko.json | 2 +- translations/pl.json | 1 + translations/ru.json | 2 +- translations/strings.txt | 2 +- translations/zh-CN.json | 2 +- 10 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hack/update/github.go b/hack/update/github.go index b49bca56ac..0456485444 100644 --- a/hack/update/github.go +++ b/hack/update/github.go @@ -131,7 +131,7 @@ func ghCreatePR(ctx context.Context, owner, repo, base, branch, title string, is klog.Fatalf("Unable to parse schema: %v\n%s", err, pretty) } modifiable := true - pr, _, err := ghc.pull requests.Create(ctx, owner, repo, &github.NewPullRequest{ + pr, _, err := ghc.PullRequests.Create(ctx, owner, repo, &github.NewPullRequest{ Title: github.String(title), Head: github.String(*fork.Owner.Login + ":" + prBranch), Base: github.String(base), diff --git a/translations/de.json b/translations/de.json index f8079cfff9..704f9e5506 100644 --- a/translations/de.json +++ b/translations/de.json @@ -467,7 +467,6 @@ "Please enter a value:": "Bitte geben Sie einen Wert ein:", "Please free up disk or prune images.": "Bitte geben Sie Plattenplatz frei oder löschen Sie unbenutzte Images (prune)", "Please increase Desktop's disk size.": "Bitte erhöhen Sie die Plattengröße von Desktop", - "Please increse Desktop's disk size.": "", "Please install the minikube hyperkit VM driver, or select an alternative --driver": "Bitte installieren Sie den minikube hyperkit VM Treiber oder geben Sie einen alternativen Treiber mit --driver an", "Please install the minikube kvm2 VM driver, or select an alternative --driver": "Bitte installieren Sie den minikube kvm2 VM Treiber oder geben Sie einen alternativen Treiber mit --driver an", "Please make sure the service you are looking for is deployed or is in the correct namespace.": "Bitte stellen Sie sicher, dass der gesuchte Service deployed ist oder im korrekten Namespace ist.", diff --git a/translations/es.json b/translations/es.json index 49a9e40b67..1d857ae00a 100644 --- a/translations/es.json +++ b/translations/es.json @@ -474,7 +474,7 @@ "Please either authenticate to the registry or use --base-image flag to use a different registry.": "", "Please enter a value:": "", "Please free up disk or prune images.": "", - "Please increse Desktop's disk size.": "", + "Please increase Desktop's disk size.": "", "Please install the minikube hyperkit VM driver, or select an alternative --driver": "", "Please install the minikube kvm2 VM driver, or select an alternative --driver": "", "Please make sure the service you are looking for is deployed or is in the correct namespace.": "", diff --git a/translations/fr.json b/translations/fr.json index 605ed5f438..11ab7332f3 100644 --- a/translations/fr.json +++ b/translations/fr.json @@ -454,6 +454,7 @@ "Please either authenticate to the registry or use --base-image flag to use a different registry.": "Veuillez vous authentifier auprès du registre ou utiliser l'indicateur --base-image pour utiliser un registre différent.", "Please enter a value:": "Entrer un nombre, SVP:", "Please free up disk or prune images.": "Veuillez libérer le disque ou élaguer les images.", + "Please increase Desktop's disk size.": "", "Please increse Desktop's disk size.": "Veuillez augmenter la taille du disque du bureau.", "Please install the minikube hyperkit VM driver, or select an alternative --driver": "Veuillez installer le pilote minikube hyperkit VM, ou sélectionnez un --driver alternatif", "Please install the minikube kvm2 VM driver, or select an alternative --driver": "Veuillez installer le pilote minikube kvm2 VM, ou sélectionnez un --driver alternatif", diff --git a/translations/ja.json b/translations/ja.json index 9fb0045d1d..8b63e0745a 100644 --- a/translations/ja.json +++ b/translations/ja.json @@ -464,6 +464,7 @@ "Please either authenticate to the registry or use --base-image flag to use a different registry.": "レジストリーに認証するか、--base-image フラグで別のレジストリーを指定するかどちらを行ってください。", "Please enter a value:": "値を入力してください:", "Please free up disk or prune images.": "ディスクを解放するか、イメージを削除してください。", + "Please increase Desktop's disk size.": "", "Please increse Desktop's disk size.": "Desktop のディスクサイズを増やしてください。", "Please install the minikube hyperkit VM driver, or select an alternative --driver": "minikube hyperkit VM ドライバーをインストールするか、--driver で別のドライバーを選択してください", "Please install the minikube kvm2 VM driver, or select an alternative --driver": "minikube kvm2 VM ドライバーをインストールするか、--driver で別のドライバーを選択してください", diff --git a/translations/ko.json b/translations/ko.json index 6d553b11d5..e694d3e36d 100644 --- a/translations/ko.json +++ b/translations/ko.json @@ -489,7 +489,7 @@ "Please either authenticate to the registry or use --base-image flag to use a different registry.": "", "Please enter a value:": "값을 입력하세요", "Please free up disk or prune images.": "", - "Please increse Desktop's disk size.": "", + "Please increase Desktop's disk size.": "", "Please install the minikube hyperkit VM driver, or select an alternative --driver": "", "Please install the minikube kvm2 VM driver, or select an alternative --driver": "", "Please make sure the service you are looking for is deployed or is in the correct namespace.": "", diff --git a/translations/pl.json b/translations/pl.json index 6f70148964..f38c679044 100644 --- a/translations/pl.json +++ b/translations/pl.json @@ -484,6 +484,7 @@ "Please either authenticate to the registry or use --base-image flag to use a different registry.": "Uwierzytelnij się w rejestrze lub użyć flagi --base-image w celu użycia innego rejestru.", "Please enter a value:": "Wprowadź wartość", "Please free up disk or prune images.": "Zwolnij miejsce na dysku lub usuń niepotrzebne obrazy", + "Please increase Desktop's disk size.": "", "Please increse Desktop's disk size.": "Zwiększ miejsce na dysku dla programu Docker Desktop", "Please install the minikube hyperkit VM driver, or select an alternative --driver": "Zainstaluj sterownik hyperkit lub wybierz inny sterownik używając flagi --driver", "Please install the minikube kvm2 VM driver, or select an alternative --driver": "Zainstaluj sterownik kvm2 lub wybierz inny sterownik używając flagi --driver", diff --git a/translations/ru.json b/translations/ru.json index bbb156f5a3..248fd40769 100644 --- a/translations/ru.json +++ b/translations/ru.json @@ -439,7 +439,7 @@ "Please either authenticate to the registry or use --base-image flag to use a different registry.": "", "Please enter a value:": "", "Please free up disk or prune images.": "", - "Please increse Desktop's disk size.": "", + "Please increase Desktop's disk size.": "", "Please install the minikube hyperkit VM driver, or select an alternative --driver": "", "Please install the minikube kvm2 VM driver, or select an alternative --driver": "", "Please make sure the service you are looking for is deployed or is in the correct namespace.": "", diff --git a/translations/strings.txt b/translations/strings.txt index f1d330ecc4..235cf74840 100644 --- a/translations/strings.txt +++ b/translations/strings.txt @@ -439,7 +439,7 @@ "Please either authenticate to the registry or use --base-image flag to use a different registry.": "", "Please enter a value:": "", "Please free up disk or prune images.": "", - "Please increse Desktop's disk size.": "", + "Please increase Desktop's disk size.": "", "Please install the minikube hyperkit VM driver, or select an alternative --driver": "", "Please install the minikube kvm2 VM driver, or select an alternative --driver": "", "Please make sure the service you are looking for is deployed or is in the correct namespace.": "", diff --git a/translations/zh-CN.json b/translations/zh-CN.json index dc7e7f1c87..6d994db135 100644 --- a/translations/zh-CN.json +++ b/translations/zh-CN.json @@ -557,7 +557,7 @@ "Please either authenticate to the registry or use --base-image flag to use a different registry.": "", "Please enter a value:": "请输入一个值：", "Please free up disk or prune images.": "", - "Please increse Desktop's disk size.": "", + "Please increase Desktop's disk size.": "", "Please install the minikube hyperkit VM driver, or select an alternative --driver": "", "Please install the minikube kvm2 VM driver, or select an alternative --driver": "", "Please make sure the service you are looking for is deployed or is in the correct namespace.": "",