From 5b2a552091a905225d84c8f0eaf0bf298a70738d Mon Sep 17 00:00:00 2001 From: Priya Wadhwa Date: Mon, 23 Nov 2020 16:21:13 -0800 Subject: [PATCH] cleanup --- hack/metrics/README.md | 2 +- hack/metrics/metrics.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hack/metrics/README.md b/hack/metrics/README.md index ab82671fc6..68df5ac838 100644 --- a/hack/metrics/README.md +++ b/hack/metrics/README.md @@ -1,4 +1,4 @@ -This script runs `minikube start` in a loop times how long it takes. +This script runs `minikube start` in a loop and measures how long it takes. It exports this data to Stackdriver via the OpenTelemetry API. This script is used to track minikube performance and prevent regressions. diff --git a/hack/metrics/metrics.go b/hack/metrics/metrics.go index 0c0b7153b5..bf74e3ba39 100644 --- a/hack/metrics/metrics.go +++ b/hack/metrics/metrics.go @@ -76,7 +76,7 @@ func execute() error { Aggregation: view.LastValue(), } if err := view.Register(v); err != nil { - log.Fatalf("Failed to register the view: %v", err) + return errors.Wrap(err, "registering view") } sd, err := stackdriver.NewExporter(stackdriver.Options{