From 59274b22da44b1c9e5fee989c19e848feb4e02d9 Mon Sep 17 00:00:00 2001 From: dlorenc Date: Tue, 2 Jan 2018 13:32:47 -0800 Subject: [PATCH] Code review feedback. --- cmd/minikube/cmd/start.go | 4 ++-- pkg/drivers/hyperkit/driver.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index 7047348373..c9dc799f6f 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -371,8 +371,8 @@ func init() { startCmd.Flags().String(hypervVirtualSwitch, "", "The hyperv virtual switch name. Defaults to first found. (only supported with HyperV driver)") startCmd.Flags().String(kvmNetwork, "default", "The KVM network name. (only supported with KVM driver)") startCmd.Flags().String(xhyveDiskDriver, "ahci-hd", "The disk driver to use [ahci-hd|virtio-blk] (only supported with xhyve driver)") - startCmd.Flags().StringSlice(NFSShare, []string{}, "Local folders to share with Guest via NFS mounts") - startCmd.Flags().String(NFSSharesRoot, "/nfsshares", "Where to root the NFS Shares (defaults to /nfsshares)") + startCmd.Flags().StringSlice(NFSShare, []string{}, "Local folders to share with Guest via NFS mounts (Only supported on with hyperkit now)") + startCmd.Flags().String(NFSSharesRoot, "/nfsshares", "Where to root the NFS Shares (defaults to /nfsshares, only supported with hyperkit now)") startCmd.Flags().StringArrayVar(&dockerEnv, "docker-env", nil, "Environment variables to pass to the Docker daemon. (format: key=value)") startCmd.Flags().StringArrayVar(&dockerOpt, "docker-opt", nil, "Specify arbitrary flags to pass to the Docker daemon. (format: key=value)") startCmd.Flags().String(apiServerName, constants.APIServerName, "The apiserver name which is used in the generated certificate for localkube/kubernetes. This can be used if you want to make the apiserver available from outside the machine") diff --git a/pkg/drivers/hyperkit/driver.go b/pkg/drivers/hyperkit/driver.go index 462a9f7c3b..889312a5ca 100644 --- a/pkg/drivers/hyperkit/driver.go +++ b/pkg/drivers/hyperkit/driver.go @@ -297,7 +297,7 @@ func (d *Driver) setupNFSShare() error { } func (d *Driver) nfsExportIdentifier(path string) string { - return fmt.Sprintf("docker-machine-driver-hyperkit %s-%s", d.MachineName, path) + return fmt.Sprintf("minikube-hyperkit %s-%s", d.MachineName, path) } func (d *Driver) sendSignal(s os.Signal) error {