kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

reduce minikube profile list calls

pull/14062/head
Steven Powell 2022-04-26 16:49:43 -07:00
parent ae43182657
commit 4e8852e3e9
2 changed files with 52 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
gui/window.cpp
View File

@ -156,7 +156,7 @@ void Window::createBasicView()
connect(basicStopButton, &QAbstractButton::clicked, this, &Window::stopMinikube);
connect(basicPauseButton, &QAbstractButton::clicked, this, &Window::pauseOrUnpauseMinikube);
connect(basicDeleteButton, &QAbstractButton::clicked, this, &Window::deleteMinikube);
connect(basicRefreshButton, &QAbstractButton::clicked, this, &Window::updateClusters);
connect(basicRefreshButton, &QAbstractButton::clicked, this, &Window::updateClustersTable);
connect(advancedViewButton, &QAbstractButton::clicked, this, &Window::toAdvancedView);
}
@ -165,6 +165,7 @@ void Window::toAdvancedView()
isBasicView = false;
stackedWidget->setCurrentIndex(1);
resize(600, 400);
updateButtons();
}
void Window::toBasicView()
@ -172,6 +173,7 @@ void Window::toBasicView()
isBasicView = true;
stackedWidget->setCurrentIndex(0);
resize(200, 250);
updateButtons();
}
void Window::createAdvancedView()
@ -182,7 +184,7 @@ void Window::createAdvancedView()
connect(stopButton, &QAbstractButton::clicked, this, &Window::stopMinikube);
connect(pauseButton, &QAbstractButton::clicked, this, &Window::pauseOrUnpauseMinikube);
connect(deleteButton, &QAbstractButton::clicked, this, &Window::deleteMinikube);
connect(refreshButton, &QAbstractButton::clicked, this, &Window::updateClusters);
connect(refreshButton, &QAbstractButton::clicked, this, &Window::updateClustersTable);
connect(createButton, &QAbstractButton::clicked, this, &Window::initMachine);
connect(trayIcon, &QSystemTrayIcon::messageClicked, this, &Window::messageClicked);
@ -246,7 +248,7 @@ void Window::createActions()
void Window::restoreWindow()
{
QWidget::showNormal();
updateClusters();
updateClustersTable();
}
static QString minikubePath()
@ -282,7 +284,7 @@ void Window::startMinikube(QStringList moreArgs)
QStringList args = { "start", "-o", "json" };
args << moreArgs;
bool success = sendMinikubeCommand(args, text);
updateClusters();
updateClustersTable();
if (success) {
return;
}
@ -299,39 +301,40 @@ void Window::stopMinikube()
{
QStringList args = { "stop", "-p", selectedClusterName() };
sendMinikubeCommand(args);
updateClusters();
updateClustersTable();
}
void Window::pauseMinikube()
{
QStringList args = { "pause", "-p", selectedClusterName() };
sendMinikubeCommand(args);
updateClusters();
updateClustersTable();
}
void Window::unpauseMinikube()
{
QStringList args = { "unpause", "-p", selectedClusterName() };
sendMinikubeCommand(args);
updateClusters();
updateClustersTable();
}
void Window::deleteMinikube()
{
QStringList args = { "delete", "-p", selectedClusterName() };
sendMinikubeCommand(args);
updateClusters();
updateClustersTable();
}
void Window::updateClusters()
void Window::updateClustersTable()
{
QString cluster = selectedClusterName();
clusterModel->setClusters(getClusters());
updateClusterList();
clusterModel->setClusters(clusterList);
setSelectedClusterName(cluster);
updateButtons();
}
ClusterList Window::getClusters()
void Window::updateClusterList()
{
ClusterList clusters;
QStringList args = { "profile", "list", "-o", "json" };
@ -366,7 +369,7 @@ ClusterList Window::getClusters()
clusters << cluster;
}
}
return clusters;
clusterList = clusters;
}
Cluster Window::createClusterObject(QJsonObject obj)
@ -417,7 +420,7 @@ QString Window::selectedClusterName()
return "minikube";
}
QModelIndex index = clusterListView->currentIndex();
QVariant variant = index.data(Qt::DisplayRole);
QVariant variant = index.siblingAtColumn(0).data(Qt::DisplayRole);
if (variant.isNull()) {
return QString();
}
@ -439,7 +442,8 @@ void Window::createClusterGroupBox()
{
clusterGroupBox = new QGroupBox(tr("Clusters"));
ClusterList clusters = getClusters();
updateClusterList();
ClusterList clusters = clusterList;
clusterModel = new ClusterModel(clusters);
clusterListView = new QTableView();
@ -487,6 +491,13 @@ void Window::createClusterGroupBox()
clusterLayout->addWidget(clusterListView);
clusterLayout->addLayout(bottomButtonLayout);
clusterGroupBox->setLayout(clusterLayout);
startButton->setEnabled(false);
stopButton->setEnabled(false);
pauseButton->setEnabled(false);
deleteButton->setEnabled(false);
sshButton->setEnabled(false);
dashboardButton->setEnabled(false);
}
void Window::updateButtons()
@ -506,11 +517,8 @@ void Window::updateTrayActions(Cluster cluster)
bool isPaused = cluster.status() == "Paused";
pauseAction->setEnabled(isRunning || isPaused);
stopAction->setEnabled(isRunning || isPaused);
QString pauseLabel = tr("Pause");
if (isPaused) {
pauseLabel = tr("Unpause");
}
pauseAction->setText(pauseLabel);
pauseAction->setText(getPauseLabel(isRunning));
startAction->setText(getStartLabel(isRunning));
}
Cluster Window::selectedCluster()
@ -519,7 +527,7 @@ Cluster Window::selectedCluster()
if (clusterName.isEmpty()) {
return Cluster();
}
ClusterList clusters = getClusters();
ClusterList clusters = clusterList;
ClusterHash clusterHash;
for (int i = 0; i < clusters.size(); i++) {
Cluster cluster = clusters.at(i);
@ -542,11 +550,24 @@ void Window::updateBasicButtons(Cluster cluster)
#else
basicSSHButton->setEnabled(false);
#endif
QString pauseLabel = tr("Pause");
basicPauseButton->setText(getPauseLabel(isPaused));
basicStartButton->setText(getStartLabel(isRunning));
}
QString Window::getPauseLabel(bool isPaused)
{
if (isPaused) {
pauseLabel = tr("Unpause");
return tr("Unpause");
}
basicPauseButton->setText(pauseLabel);
return tr("Pause");
}
QString Window::getStartLabel(bool isRunning)
{
if (isRunning) {
return tr("Reload");
}
return tr("Start");
}
void Window::pauseOrUnpauseMinikube()
@ -574,11 +595,8 @@ void Window::updateAdvancedButtons(Cluster cluster)
#else
sshButton->setEnabled(false);
#endif
QString pauseLabel = tr("Pause");
if (isPaused) {
pauseLabel = tr("Unpause");
}
pauseButton->setText(pauseLabel);
pauseButton->setText(getPauseLabel(isPaused));
startButton->setText(getStartLabel(isRunning));
}
bool Window::sendMinikubeCommand(QStringList cmds)
@ -788,7 +806,7 @@ QLabel *Window::createLabel(QString title, QString text, QFormLayout *form, bool
void Window::initMachine()
{
askName();
updateClusters();
updateClustersTable();
}
void Window::sshConsole()

7
gui/window.h
View File

@ -144,10 +144,11 @@ private:
QString selectedClusterName();
void setSelectedClusterName(QString cluster);
Cluster selectedCluster();
ClusterList getClusters();
void updateClusters();
void updateClusterList();
void updateClustersTable();
ClusterModel *clusterModel;
QTableView *clusterListView;
ClusterList clusterList;
// Create cluster
void askCustom();
@ -179,6 +180,8 @@ private:
void checkForMinikube();
void restoreWindow();
QString getPauseLabel(bool isPaused);
QString getStartLabel(bool isRunning);
QProcessEnvironment setMacEnv();
QStackedWidget *stackedWidget;
bool isBasicView;