kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #17690 from spowelljr/fixUnitTest 

Fix TestEnable unit test
pull/17691/head
Medya Ghazizadeh 2023-11-29 14:40:15 -08:00 committed by GitHub
parent 51edffa3be cee02a2eb3
commit 4df5a8735e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
pkg/minikube/cruntime/cruntime_test.go
View File

@ -616,6 +616,7 @@ func TestVersion(t *testing.T) {
// defaultServices reflects the default boot state for the minikube VM
var defaultServices = map[string]serviceState{
"docker": SvcRunning,
"docker.socket": SvcRunning,
"crio": SvcExited,
"crio-shutdown": SvcExited,
"containerd": SvcExited,
@ -624,6 +625,7 @@ var defaultServices = map[string]serviceState{
// allServices reflects the state of all actual services running at once
var allServices = map[string]serviceState{
"docker": SvcRunning,
"docker.socket": SvcRunning,
"crio": SvcRunning,
"crio-shutdown": SvcExited,
"containerd": SvcRunning,
@ -662,41 +664,46 @@ func TestDisable(t *testing.T) {
func TestEnable(t *testing.T) {
var tests = []struct {
runtime string
services map[string]serviceState
want map[string]serviceState
description string
runtime string
services map[string]serviceState
want map[string]serviceState
}{
{"docker", defaultServices,
{"DockerDefaultServices", "docker", defaultServices,
map[string]serviceState{
"docker": SvcRestarted,
"docker.socket": SvcRunning,
"containerd": SvcExited,
"crio": SvcExited,
"crio-shutdown": SvcExited,
}},
{"docker", allServices,
{"DockerAllServices", "docker", allServices,
map[string]serviceState{
"docker": SvcRestarted,
"docker.socket": SvcRunning,
"containerd": SvcExited,
"crio": SvcExited,
"crio-shutdown": SvcExited,
}},
{"containerd", defaultServices,
{"ContainerdDefaultServices", "containerd", defaultServices,
map[string]serviceState{
"docker": SvcExited,
"docker.socket": SvcExited,
"containerd": SvcRestarted,
"crio": SvcExited,
"crio-shutdown": SvcExited,
}},
{"crio", defaultServices,
{"CrioServices", "crio", defaultServices,
map[string]serviceState{
"docker": SvcExited,
"docker.socket": SvcExited,
"containerd": SvcExited,
"crio": SvcRestarted,
"crio-shutdown": SvcExited,
}},
}
for _, tc := range tests {
t.Run(tc.runtime, func(t *testing.T) {
t.Run(tc.description, func(t *testing.T) {
runner := NewFakeRunner(t)
for k, v := range tc.services {
runner.services[k] = v