From 4d9730137f1e4092176aee99f47b50c5840ec482 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Thu, 20 Feb 2020 21:56:23 -0800 Subject: [PATCH] improve logging --- .github/workflows/main.yml | 8 ++++---- cmd/minikube/cmd/config/get_test.go | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 288a917856..2f7b09a082 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -381,11 +381,11 @@ jobs: shell: bash run: | echo ${GOPOGH_RESULT} - echo "--------------------------------------------" + numFail=$(echo $STAT | jq '.NumberOfFail') + echo "----------------${numFail} Failures----------------------------" echo $STAT | jq '.FailedTests' || true - echo "--------------------------------------------" - numberOfFailures=$(echo $STAT | jq '.NumberOfFail') - if [ "$numberOfFailures" -gt 0 ];then echo "*** $numberOfFailures Failed ***";exit 2;fi + echo "-------------------------------------------------------" + if [ "$numFail" -gt 0 ];then echo "*** $numFail Failed ***";exit 2;fi # After all 4 integration tests finished # collect all the reports and upload upload_all_reports: diff --git a/cmd/minikube/cmd/config/get_test.go b/cmd/minikube/cmd/config/get_test.go index f35e335ede..e83e119f25 100644 --- a/cmd/minikube/cmd/config/get_test.go +++ b/cmd/minikube/cmd/config/get_test.go @@ -29,11 +29,11 @@ func TestGetOK(t *testing.T) { name := "vm-driver" err := Set(name, "virtualbox") if err != nil { - t.Fatalf("Set returned error for property %s: %v", err, name) + t.Fatalf("Set returned error for property %s: %v", name, err) } val, err := Get(name) if err != nil { - t.Fatalf("Get returned error for property %s: %v", err, name) + t.Fatalf("Get returned error for property %s: %v", name, err) } if val != "virtualbox" { t.Fatalf("Get returned %s, expected virtualbox", val)