From 436cee2d841869a4dcff97190c7ddcb1ca5cab60 Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Thu, 7 May 2020 14:12:10 -0700 Subject: [PATCH] Fix minikube/kubernetes capitalization, make short help consistent --- cmd/minikube/cmd/cache.go | 4 ++-- cmd/minikube/cmd/completion.go | 2 +- cmd/minikube/cmd/config/addons.go | 2 +- cmd/minikube/cmd/config/config.go | 2 +- cmd/minikube/cmd/config/open.go | 4 ++-- cmd/minikube/cmd/config/profile.go | 2 +- cmd/minikube/cmd/dashboard.go | 4 ++-- cmd/minikube/cmd/delete.go | 4 ++-- cmd/minikube/cmd/docker-env.go | 2 +- cmd/minikube/cmd/kubectl.go | 4 ++-- cmd/minikube/cmd/logs.go | 2 +- cmd/minikube/cmd/node.go | 2 +- cmd/minikube/cmd/node_list.go | 4 ++-- cmd/minikube/cmd/options.go | 9 +++++---- cmd/minikube/cmd/pause.go | 2 +- cmd/minikube/cmd/podman-env.go | 2 +- cmd/minikube/cmd/root.go | 6 +++--- cmd/minikube/cmd/service.go | 6 +++--- cmd/minikube/cmd/ssh.go | 2 +- cmd/minikube/cmd/start.go | 8 ++++---- cmd/minikube/cmd/start_flags.go | 8 ++++---- cmd/minikube/cmd/status.go | 8 ++++---- cmd/minikube/cmd/stop.go | 4 ++-- cmd/minikube/cmd/tunnel.go | 2 +- cmd/minikube/cmd/update-context.go | 2 +- hack/preload-images/generate.go | 2 +- hack/preload-images/preload_images.go | 2 +- pkg/drivers/kic/oci/types.go | 2 +- pkg/drivers/kic/types.go | 4 ++-- pkg/generate/docs.go | 2 +- pkg/generate/rewrite.go | 2 +- pkg/kapi/kapi.go | 2 +- pkg/minikube/bootstrapper/bootstrapper.go | 2 +- pkg/minikube/bootstrapper/bsutil/kubeadm.go | 2 +- pkg/minikube/bootstrapper/bsutil/kubelet.go | 2 +- .../bootstrapper/bsutil/kverify/api_server.go | 2 +- .../bootstrapper/bsutil/kverify/default_sa.go | 2 +- pkg/minikube/bootstrapper/bsutil/kverify/kverify.go | 2 +- .../bootstrapper/bsutil/kverify/node_conditions.go | 2 +- .../bootstrapper/bsutil/kverify/node_ready.go | 2 +- .../bootstrapper/bsutil/kverify/system_pods.go | 2 +- pkg/minikube/bootstrapper/bsutil/ops.go | 2 +- pkg/minikube/bootstrapper/kubeadm/kubeadm.go | 12 ++++++------ pkg/minikube/cluster/cluster.go | 2 +- pkg/minikube/config/config.go | 6 +++--- pkg/minikube/config/types.go | 2 +- pkg/minikube/constants/constants.go | 6 +++--- pkg/minikube/cruntime/docker.go | 2 +- pkg/minikube/driver/driver.go | 2 +- pkg/minikube/kubeconfig/settings.go | 2 +- pkg/minikube/localpath/localpath.go | 2 +- pkg/minikube/node/cache.go | 2 +- pkg/minikube/node/start.go | 4 ++-- pkg/minikube/registry/global.go | 2 +- pkg/minikube/service/service.go | 4 ++-- pkg/storage/storage_provisioner.go | 2 +- pkg/util/utils.go | 2 +- test/integration/addons_test.go | 8 ++++---- test/integration/fn_tunnel_cmd.go | 2 +- test/integration/version_upgrade_test.go | 2 +- 60 files changed, 99 insertions(+), 98 deletions(-) diff --git a/cmd/minikube/cmd/cache.go b/cmd/minikube/cmd/cache.go index eb91371984..30579d45fa 100644 --- a/cmd/minikube/cmd/cache.go +++ b/cmd/minikube/cmd/cache.go @@ -31,8 +31,8 @@ const cacheImageConfigKey = "cache" // cacheCmd represents the cache command var cacheCmd = &cobra.Command{ Use: "cache", - Short: "Add or delete an image from the local cache.", - Long: "Add or delete an image from the local cache.", + Short: "Add, delete, or push a local image into minikube", + Long: "Add, delete, or push a local image into minikube", } // addCacheCmd represents the cache add command diff --git a/cmd/minikube/cmd/completion.go b/cmd/minikube/cmd/completion.go index 7356a7bea6..35e359e188 100644 --- a/cmd/minikube/cmd/completion.go +++ b/cmd/minikube/cmd/completion.go @@ -69,7 +69,7 @@ const boilerPlate = ` var completionCmd = &cobra.Command{ Use: "completion SHELL", - Short: "Outputs minikube shell completion for the given shell (bash, zsh or fish)", + Short: "Generate command completion for a shell", Long: longDescription, Run: func(cmd *cobra.Command, args []string) { if len(args) != 1 { diff --git a/cmd/minikube/cmd/config/addons.go b/cmd/minikube/cmd/config/addons.go index ddcf9ae076..5a0d842599 100644 --- a/cmd/minikube/cmd/config/addons.go +++ b/cmd/minikube/cmd/config/addons.go @@ -24,7 +24,7 @@ import ( // AddonsCmd represents the addons command var AddonsCmd = &cobra.Command{ Use: "addons SUBCOMMAND [flags]", - Short: "Modify minikube's kubernetes addons", + Short: "Enable or disable a minikube addon", Long: `addons modifies minikube addons files using subcommands like "minikube addons enable dashboard"`, Run: func(cmd *cobra.Command, args []string) { if err := cmd.Help(); err != nil { diff --git a/cmd/minikube/cmd/config/config.go b/cmd/minikube/cmd/config/config.go index aa6a603068..9d80c2112b 100644 --- a/cmd/minikube/cmd/config/config.go +++ b/cmd/minikube/cmd/config/config.go @@ -177,7 +177,7 @@ var settings = []Setting{ // ConfigCmd represents the config command var ConfigCmd = &cobra.Command{ Use: "config SUBCOMMAND [flags]", - Short: "Modify minikube config", + Short: "Modify persistent configuration values", Long: `config modifies minikube config files using subcommands like "minikube config set driver kvm" Configurable fields: ` + "\n\n" + configurableFields(), Run: func(cmd *cobra.Command, args []string) { diff --git a/cmd/minikube/cmd/config/open.go b/cmd/minikube/cmd/config/open.go index b5ad2db22e..070fce6fc1 100644 --- a/cmd/minikube/cmd/config/open.go +++ b/cmd/minikube/cmd/config/open.go @@ -94,7 +94,7 @@ You can add one by annotating a service with the label {{.labelName}}:{{.addonNa } if len(urlString) != 0 { - out.T(out.Celebrate, "Opening kubernetes service {{.namespace_name}}/{{.service_name}} in default browser...", out.V{"namespace_name": namespace, "service_name": svc}) + out.T(out.Celebrate, "Opening Kubernetes service {{.namespace_name}}/{{.service_name}} in default browser...", out.V{"namespace_name": namespace, "service_name": svc}) for _, url := range urlString { if err := browser.OpenURL(url); err != nil { exit.WithError(fmt.Sprintf("browser failed to open url %s", url), err) @@ -106,7 +106,7 @@ You can add one by annotating a service with the label {{.labelName}}:{{.addonNa } func init() { - addonsOpenCmd.Flags().BoolVar(&addonsURLMode, "url", false, "Display the kubernetes addons URL in the CLI instead of opening it in the default browser") + addonsOpenCmd.Flags().BoolVar(&addonsURLMode, "url", false, "Display the Kubernetes addons URL in the CLI instead of opening it in the default browser") addonsOpenCmd.Flags().BoolVar(&https, "https", false, "Open the addons URL with https instead of http") addonsOpenCmd.Flags().IntVar(&wait, "wait", service.DefaultWait, "Amount of time to wait for service in seconds") addonsOpenCmd.Flags().IntVar(&interval, "interval", service.DefaultInterval, "The time interval for each check that wait performs in seconds") diff --git a/cmd/minikube/cmd/config/profile.go b/cmd/minikube/cmd/config/profile.go index 182b480600..171d90a3bd 100644 --- a/cmd/minikube/cmd/config/profile.go +++ b/cmd/minikube/cmd/config/profile.go @@ -30,7 +30,7 @@ import ( // ProfileCmd represents the profile command var ProfileCmd = &cobra.Command{ Use: "profile [MINIKUBE_PROFILE_NAME]. You can return to the default minikube profile by running `minikube profile default`", - Short: "Profile gets or sets the current minikube profile", + Short: "Get or list the the current profiles (clusters)", Long: "profile sets the current minikube profile, or gets the current profile if no arguments are provided. This is used to run and manage multiple minikube instance. You can return to the default minikube profile by running `minikube profile default`", Run: func(cmd *cobra.Command, args []string) { if len(args) == 0 { diff --git a/cmd/minikube/cmd/dashboard.go b/cmd/minikube/cmd/dashboard.go index c83dd210fe..31516e0c73 100644 --- a/cmd/minikube/cmd/dashboard.go +++ b/cmd/minikube/cmd/dashboard.go @@ -51,8 +51,8 @@ var ( // dashboardCmd represents the dashboard command var dashboardCmd = &cobra.Command{ Use: "dashboard", - Short: "Access the kubernetes dashboard running within the minikube cluster", - Long: `Access the kubernetes dashboard running within the minikube cluster`, + Short: "Access the Kubernetes dashboard running within the minikube cluster", + Long: `Access the Kubernetes dashboard running within the minikube cluster`, Run: func(cmd *cobra.Command, args []string) { cname := ClusterFlagValue() co := mustload.Healthy(cname) diff --git a/cmd/minikube/cmd/delete.go b/cmd/minikube/cmd/delete.go index c2b05800aa..09fd7d9615 100644 --- a/cmd/minikube/cmd/delete.go +++ b/cmd/minikube/cmd/delete.go @@ -51,8 +51,8 @@ var purge bool // deleteCmd represents the delete command var deleteCmd = &cobra.Command{ Use: "delete", - Short: "Deletes a local kubernetes cluster", - Long: `Deletes a local kubernetes cluster. This command deletes the VM, and removes all + Short: "Deletes a local Kubernetes cluster", + Long: `Deletes a local Kubernetes cluster. This command deletes the VM, and removes all associated files.`, Run: runDelete, } diff --git a/cmd/minikube/cmd/docker-env.go b/cmd/minikube/cmd/docker-env.go index c4432c6b58..edf6aca261 100644 --- a/cmd/minikube/cmd/docker-env.go +++ b/cmd/minikube/cmd/docker-env.go @@ -122,7 +122,7 @@ func isDockerActive(r command.Runner) bool { // dockerEnvCmd represents the docker-env command var dockerEnvCmd = &cobra.Command{ Use: "docker-env", - Short: "Sets up docker env variables; similar to '$(docker-machine env)'", + Short: "Configure environment to use minikube's Docker daemon", Long: `Sets up docker env variables; similar to '$(docker-machine env)'.`, Run: func(cmd *cobra.Command, args []string) { cname := ClusterFlagValue() diff --git a/cmd/minikube/cmd/kubectl.go b/cmd/minikube/cmd/kubectl.go index 3eca6dfb06..9f304c03c3 100644 --- a/cmd/minikube/cmd/kubectl.go +++ b/cmd/minikube/cmd/kubectl.go @@ -33,8 +33,8 @@ import ( // kubectlCmd represents the kubectl command var kubectlCmd = &cobra.Command{ Use: "kubectl", - Short: "Run kubectl", - Long: `Run the kubernetes client, download it if necessary. Remember -- after kubectl! + Short: "Run a kubectl binary matching the cluster version", + Long: `Run the Kubernetes client, download it if necessary. Remember -- after kubectl! Examples: minikube kubectl -- --help diff --git a/cmd/minikube/cmd/logs.go b/cmd/minikube/cmd/logs.go index 7dfc2df24f..5b5708f296 100644 --- a/cmd/minikube/cmd/logs.go +++ b/cmd/minikube/cmd/logs.go @@ -48,7 +48,7 @@ var ( // logsCmd represents the logs command var logsCmd = &cobra.Command{ Use: "logs", - Short: "Gets the logs of the running instance, used for debugging minikube, not user code.", + Short: "Returns logs to debug a local Kubernetes cluster", Long: `Gets the logs of the running instance, used for debugging minikube, not user code.`, Run: func(cmd *cobra.Command, args []string) { co := mustload.Running(ClusterFlagValue()) diff --git a/cmd/minikube/cmd/node.go b/cmd/minikube/cmd/node.go index 6dac2ca409..f851788ac6 100644 --- a/cmd/minikube/cmd/node.go +++ b/cmd/minikube/cmd/node.go @@ -24,7 +24,7 @@ import ( // nodeCmd represents the set of node subcommands var nodeCmd = &cobra.Command{ Use: "node", - Short: "Node operations", + Short: "Add, remove, or list additional nodes", Long: "Operations on nodes", Run: func(cmd *cobra.Command, args []string) { exit.UsageT("Usage: minikube node [add|start|stop|delete|list]") diff --git a/cmd/minikube/cmd/node_list.go b/cmd/minikube/cmd/node_list.go index 0295837ceb..7ec8075424 100644 --- a/cmd/minikube/cmd/node_list.go +++ b/cmd/minikube/cmd/node_list.go @@ -30,7 +30,7 @@ import ( var nodeListCmd = &cobra.Command{ Use: "list", Short: "List nodes.", - Long: "List existing Minikube nodes.", + Long: "List existing minikube nodes.", Run: func(cmd *cobra.Command, args []string) { if len(args) != 0 { exit.UsageT("Usage: minikube node list") @@ -40,7 +40,7 @@ var nodeListCmd = &cobra.Command{ _, cc := mustload.Partial(cname) if len(cc.Nodes) < 1 { - glog.Warningf("Did not found any Minikube node.") + glog.Warningf("Did not found any minikube node.") } else { glog.Infof("%v", cc.Nodes) } diff --git a/cmd/minikube/cmd/options.go b/cmd/minikube/cmd/options.go index 80f97606d1..63211aefbb 100644 --- a/cmd/minikube/cmd/options.go +++ b/cmd/minikube/cmd/options.go @@ -28,10 +28,11 @@ import ( // optionsCmd represents the options command var optionsCmd = &cobra.Command{ - Use: "options", - Short: "Show a list of global command-line options (applies to all commands).", - Long: "Show a list of global command-line options (applies to all commands).", - Run: runOptions, + Use: "options", + Short: "Show a list of global command-line options (applies to all commands).", + Long: "Show a list of global command-line options (applies to all commands).", + Hidden: true, + Run: runOptions, } // runOptions handles the executes the flow of "minikube options" diff --git a/cmd/minikube/cmd/pause.go b/cmd/minikube/cmd/pause.go index d7b090ce83..448583d8fe 100644 --- a/cmd/minikube/cmd/pause.go +++ b/cmd/minikube/cmd/pause.go @@ -41,7 +41,7 @@ var ( // pauseCmd represents the docker-pause command var pauseCmd = &cobra.Command{ Use: "pause", - Short: "pause containers", + Short: "pause Kubernetes", Run: runPause, } diff --git a/cmd/minikube/cmd/podman-env.go b/cmd/minikube/cmd/podman-env.go index 124a721de8..62356a49ee 100644 --- a/cmd/minikube/cmd/podman-env.go +++ b/cmd/minikube/cmd/podman-env.go @@ -103,7 +103,7 @@ func createExternalSSHClient(d drivers.Driver) (*ssh.ExternalClient, error) { // podmanEnvCmd represents the podman-env command var podmanEnvCmd = &cobra.Command{ Use: "podman-env", - Short: "Sets up podman env variables; similar to '$(podman-machine env)'", + Short: "Configure environment to use minikube's Podman daemon", Long: `Sets up podman env variables; similar to '$(podman-machine env)'.`, Run: func(cmd *cobra.Command, args []string) { cname := ClusterFlagValue() diff --git a/cmd/minikube/cmd/root.go b/cmd/minikube/cmd/root.go index 1d5c4433f8..ff4cd84ffd 100644 --- a/cmd/minikube/cmd/root.go +++ b/cmd/minikube/cmd/root.go @@ -58,8 +58,8 @@ var viperWhiteList = []string{ // RootCmd represents the base command when called without any subcommands var RootCmd = &cobra.Command{ Use: "minikube", - Short: "Minikube is a tool for managing local Kubernetes clusters.", - Long: `Minikube is a CLI tool that provisions and manages single-node Kubernetes clusters optimized for development workflows.`, + Short: "minikube quickly sets up a local Kubernetes cluster", + Long: `minikube is a tool that provisions and manages local Kubernetes clusters optimized for development workflows.`, PersistentPreRun: func(cmd *cobra.Command, args []string) { for _, path := range dirs { if err := os.MkdirAll(path, 0777); err != nil { @@ -163,7 +163,7 @@ func setFlagsUsingViper() { func init() { translate.DetermineLocale() RootCmd.PersistentFlags().StringP(config.ProfileName, "p", constants.DefaultClusterName, `The name of the minikube VM being used. This can be set to allow having multiple instances of minikube independently.`) - RootCmd.PersistentFlags().StringP(configCmd.Bootstrapper, "b", "kubeadm", "The name of the cluster bootstrapper that will set up the kubernetes cluster.") + RootCmd.PersistentFlags().StringP(configCmd.Bootstrapper, "b", "kubeadm", "The name of the cluster bootstrapper that will set up the Kubernetes cluster.") groups := templates.CommandGroups{ { diff --git a/cmd/minikube/cmd/service.go b/cmd/minikube/cmd/service.go index 7e3407b853..b4ce0ba84d 100644 --- a/cmd/minikube/cmd/service.go +++ b/cmd/minikube/cmd/service.go @@ -59,8 +59,8 @@ var ( // serviceCmd represents the service command var serviceCmd = &cobra.Command{ Use: "service [flags] SERVICE", - Short: "Gets the kubernetes URL(s) for the specified service in your local cluster", - Long: `Gets the kubernetes URL(s) for the specified service in your local cluster. In the case of multiple URLs they will be printed one at a time.`, + Short: "Returns a URL to connect to a service", + Long: `Returns the Kubernetes URL for a service in your local cluster. In the case of multiple URLs they will be printed one at a time.`, PersistentPreRun: func(cmd *cobra.Command, args []string) { t, err := template.New("serviceURL").Parse(serviceURLFormat) if err != nil { @@ -101,7 +101,7 @@ You may select another namespace by using 'minikube service {{.service}} -n 0 { diff --git a/pkg/minikube/node/cache.go b/pkg/minikube/node/cache.go index 19d37c9f80..d5a36a5e15 100644 --- a/pkg/minikube/node/cache.go +++ b/pkg/minikube/node/cache.go @@ -41,7 +41,7 @@ const ( cacheImageConfigKey = "cache" ) -// BeginCacheKubernetesImages caches images required for kubernetes version in the background +// BeginCacheKubernetesImages caches images required for Kubernetes version in the background func beginCacheKubernetesImages(g *errgroup.Group, imageRepository string, k8sVersion string, cRuntime string) { // TODO: remove imageRepository check once #7695 is fixed if imageRepository == "" && download.PreloadExists(k8sVersion, cRuntime) { diff --git a/pkg/minikube/node/start.go b/pkg/minikube/node/start.go index 689530fda5..2f326ddd92 100644 --- a/pkg/minikube/node/start.go +++ b/pkg/minikube/node/start.go @@ -75,14 +75,14 @@ type Starter struct { ExistingAddons map[string]bool } -// Start spins up a guest and starts the kubernetes node. +// Start spins up a guest and starts the Kubernetes node. func Start(starter Starter, apiServer bool) (*kubeconfig.Settings, error) { // wait for preloaded tarball to finish downloading before configuring runtimes waitCacheRequiredImages(&cacheGroup) sv, err := util.ParseKubernetesVersion(starter.Node.KubernetesVersion) if err != nil { - return nil, errors.Wrap(err, "Failed to parse kubernetes version") + return nil, errors.Wrap(err, "Failed to parse Kubernetes version") } // configure the runtime (docker, containerd, crio) diff --git a/pkg/minikube/registry/global.go b/pkg/minikube/registry/global.go index 3e92a73bab..a323cac88d 100644 --- a/pkg/minikube/registry/global.go +++ b/pkg/minikube/registry/global.go @@ -36,7 +36,7 @@ const ( None = "none" ) -// IsKIC checks if the driver is a kubernetes in container +// IsKIC checks if the driver is a Kubernetes in container func IsKIC(name string) bool { return name == Docker || name == Podman } diff --git a/pkg/minikube/service/service.go b/pkg/minikube/service/service.go index e50d4cc6c6..732878fc8d 100644 --- a/pkg/minikube/service/service.go +++ b/pkg/minikube/service/service.go @@ -48,7 +48,7 @@ const ( DefaultInterval = 1 ) -// K8sClient represents a kubernetes client +// K8sClient represents a Kubernetes client type K8sClient interface { GetCoreClient(string) (typed_core.CoreV1Interface, error) } @@ -197,7 +197,7 @@ func printURLsForService(c typed_core.CoreV1Interface, ip, service, namespace st func CheckService(cname string, namespace string, service string) error { client, err := K8s.GetCoreClient(cname) if err != nil { - return errors.Wrap(err, "Error getting kubernetes client") + return errors.Wrap(err, "Error getting Kubernetes client") } svc, err := client.Services(namespace).Get(service, meta.GetOptions{}) diff --git a/pkg/storage/storage_provisioner.go b/pkg/storage/storage_provisioner.go index 3d29cc22b5..b7587d36b8 100644 --- a/pkg/storage/storage_provisioner.go +++ b/pkg/storage/storage_provisioner.go @@ -112,7 +112,7 @@ func (p *hostPathProvisioner) Delete(volume *core.PersistentVolume) error { // StartStorageProvisioner will start storage provisioner server func StartStorageProvisioner(pvDir string) error { - glog.Infof("Initializing the Minikube storage provisioner...") + glog.Infof("Initializing the minikube storage provisioner...") config, err := rest.InClusterConfig() if err != nil { return err diff --git a/pkg/util/utils.go b/pkg/util/utils.go index 37de6085cd..6a5c3bf0f6 100644 --- a/pkg/util/utils.go +++ b/pkg/util/utils.go @@ -90,7 +90,7 @@ func MaybeChownDirRecursiveToMinikubeUser(dir string) error { return nil } -// ParseKubernetesVersion parses the kubernetes version +// ParseKubernetesVersion parses the Kubernetes version func ParseKubernetesVersion(version string) (semver.Version, error) { return semver.Make(version[1:]) } diff --git a/test/integration/addons_test.go b/test/integration/addons_test.go index 081e78763d..597617beef 100644 --- a/test/integration/addons_test.go +++ b/test/integration/addons_test.go @@ -88,7 +88,7 @@ func validateIngressAddon(ctx context.Context, t *testing.T, profile string) { client, err := kapi.Client(profile) if err != nil { - t.Fatalf("failed to get kubernetes client: %v", client) + t.Fatalf("failed to get Kubernetes client: %v", client) } if err := kapi.WaitForDeploymentToStabilize(client, "kube-system", "ingress-nginx-controller", Minutes(6)); err != nil { @@ -158,7 +158,7 @@ func validateIngressAddon(ctx context.Context, t *testing.T, profile string) { func validateRegistryAddon(ctx context.Context, t *testing.T, profile string) { client, err := kapi.Client(profile) if err != nil { - t.Fatalf("failed to get kubernetes client for %s : %v", profile, err) + t.Fatalf("failed to get Kubernetes client for %s : %v", profile, err) } start := time.Now() @@ -232,7 +232,7 @@ func validateRegistryAddon(ctx context.Context, t *testing.T, profile string) { func validateMetricsServerAddon(ctx context.Context, t *testing.T, profile string) { client, err := kapi.Client(profile) if err != nil { - t.Fatalf("failed to get kubernetes client for %s: %v", profile, err) + t.Fatalf("failed to get Kubernetes client for %s: %v", profile, err) } start := time.Now() @@ -274,7 +274,7 @@ func validateMetricsServerAddon(ctx context.Context, t *testing.T, profile strin func validateHelmTillerAddon(ctx context.Context, t *testing.T, profile string) { client, err := kapi.Client(profile) if err != nil { - t.Fatalf("failed to get kubernetes client for %s: %v", profile, err) + t.Fatalf("failed to get Kubernetes client for %s: %v", profile, err) } start := time.Now() diff --git a/test/integration/fn_tunnel_cmd.go b/test/integration/fn_tunnel_cmd.go index a23c418bcc..e990b02778 100644 --- a/test/integration/fn_tunnel_cmd.go +++ b/test/integration/fn_tunnel_cmd.go @@ -132,7 +132,7 @@ func validateServiceStable(ctx context.Context, t *testing.T, profile string) { client, err := kapi.Client(profile) if err != nil { - t.Fatalf("failed to get kubernetes client for %q: %v", profile, err) + t.Fatalf("failed to get Kubernetes client for %q: %v", profile, err) } // Start the "nginx" pod. diff --git a/test/integration/version_upgrade_test.go b/test/integration/version_upgrade_test.go index f13c5b3d15..3f2626a882 100644 --- a/test/integration/version_upgrade_test.go +++ b/test/integration/version_upgrade_test.go @@ -123,7 +123,7 @@ func TestVersionUpgrade(t *testing.T) { t.Logf("Attempting to downgrade Kubernetes (should fail)") args = append([]string{"start", "-p", profile, "--memory=2200", fmt.Sprintf("--kubernetes-version=%s", constants.OldestKubernetesVersion), "--alsologtostderr", "-v=1"}, StartArgs()...) if rr, err := Run(t, exec.CommandContext(ctx, tf.Name(), args...)); err == nil { - t.Fatalf("downgrading kubernetes should not be allowed. expected to see error but got %v for %q", err, rr.Command()) + t.Fatalf("downgrading Kubernetes should not be allowed. expected to see error but got %v for %q", err, rr.Command()) } t.Logf("Attempting restart after unsuccessful downgrade")