Merge pull request #12885 from minikube-bot/auto_bump_golint_version
bump golint versionpull/12900/head
commit
40eceaa001
2
Makefile
2
Makefile
|
@ -76,7 +76,7 @@ MINIKUBE_RELEASES_URL=https://github.com/kubernetes/minikube/releases/download
|
|||
KERNEL_VERSION ?= 4.19.202
|
||||
# latest from https://github.com/golangci/golangci-lint/releases
|
||||
# update this only by running `make update-golint-version`
|
||||
GOLINT_VERSION ?= v1.42.1
|
||||
GOLINT_VERSION ?= v1.43.0
|
||||
# Limit number of default jobs, to avoid the CI builds running out of memory
|
||||
GOLINT_JOBS ?= 4
|
||||
# see https://github.com/golangci/golangci-lint#memory-usage-of-golangci-lint
|
||||
|
|
|
@ -103,10 +103,10 @@ func recentReleases(n int) ([]string, error) {
|
|||
foundDefault := false
|
||||
|
||||
for _, v := range versions {
|
||||
if strings.HasPrefix(constants.NewestKubernetesVersion, v) {
|
||||
if strings.HasPrefix(constants.NewestKubernetesVersion, v) { //nolint:gocritic // Complains "constants.NewestKubernetesVersion and v arguments order looks reversed"
|
||||
foundNewest = true
|
||||
}
|
||||
if strings.HasPrefix(constants.DefaultKubernetesVersion, v) {
|
||||
if strings.HasPrefix(constants.DefaultKubernetesVersion, v) { //nolint:gocritic // Same as above
|
||||
foundDefault = true
|
||||
}
|
||||
}
|
||||
|
|
|
@ -293,7 +293,7 @@ func prepareTempMinikubeDirWithHyperkitDriver(name, driver string) (string, stri
|
|||
}
|
||||
|
||||
// try to copy cached files to the temp minikube folder to avoid downloading of iso and preloads
|
||||
_ = CopyDir(filepath.Join(localpath.MakeMiniPath("cache")), filepath.Join(mkDir, "cache"))
|
||||
_ = CopyDir(localpath.MakeMiniPath("cache"), filepath.Join(mkDir, "cache"))
|
||||
|
||||
// change permission to allow driver to be executable
|
||||
if err = os.Chmod(testDriverPath, 0755); err != nil {
|
||||
|
|
Loading…
Reference in New Issue