From 405ccc57dfbfbddf7ea5a24af70afd82a49e31d6 Mon Sep 17 00:00:00 2001 From: Ilya Zuyev Date: Sun, 13 Dec 2020 21:10:51 -0800 Subject: [PATCH] skip docker login if AUTOPUSH is not defined --- Makefile | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index af141d7fa3..770c9575f7 100644 --- a/Makefile +++ b/Makefile @@ -614,9 +614,11 @@ MA_KICBASE_IMAGE_REGISTRY ?= $(REGISTRY)/kicbase-multiarch:$(KIC_VERSION) $(REGI .PHONY: kic-base-image-multi-arch kic-base-image-multi-arch: docker-multi-arch-builder -# docker login gcr.io/k8s-minikube -# docker login docker.pkg.github.com -# docker login +ifdef AUTOPUSH + docker login gcr.io/k8s-minikube + docker login docker.pkg.github.com + docker login +endif env $(X_BUILD_ENV) docker buildx build --platform $(KICBASE_ARCH) $(addprefix -t ,$(MA_KICBASE_IMAGE_REGISTRY)) --push --build-arg COMMIT_SHA=${VERSION}-$(COMMIT) ./deploy/kicbase .PHONY: upload-preloaded-images-tar