kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #5109 from tstromberg/wrongurl 

Update URL should be concatenated without a /
pull/5112/head
Thomas Strömberg 2019-08-17 07:56:07 -07:00 committed by GitHub
parent 96fcb917f8 95173decc6
commit 3eaec49499
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/minikube/notify/notify.go
View File

@ -36,8 +36,6 @@ import (
"k8s.io/minikube/pkg/version" "k8s.io/minikube/pkg/version"
) )
const updateLinkPrefix = "https://github.com/kubernetes/minikube/releases/tag/v"
var ( var (
timeLayout = time.RFC1123 timeLayout = time.RFC1123
lastUpdateCheckFilePath = constants.MakeMiniPath("last_update_check") lastUpdateCheckFilePath = constants.MakeMiniPath("last_update_check")
@ -67,7 +65,7 @@ func MaybePrintUpdateText(url string, lastUpdatePath string) {
if err := writeTimeToFile(lastUpdateCheckFilePath, time.Now().UTC()); err != nil { if err := writeTimeToFile(lastUpdateCheckFilePath, time.Now().UTC()); err != nil {
glog.Errorf("write time failed: %v", err) glog.Errorf("write time failed: %v", err)
} }
url := fmt.Sprintf("%s/%s", updateLinkPrefix, latestVersion) url := "https://github.com/kubernetes/minikube/releases/tag/v" + latestVersion.String()
out.ErrT(out.WarningType, `minikube {{.version}} is available! Download it: {{.url}}`, out.V{"version": latestVersion, "url": url}) out.ErrT(out.WarningType, `minikube {{.version}} is available! Download it: {{.url}}`, out.V{"version": latestVersion, "url": url})
out.T(out.Tip, "To disable this notice, run: 'minikube config set WantUpdateNotification false'") out.T(out.Tip, "To disable this notice, run: 'minikube config set WantUpdateNotification false'")
} }