kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #9789 from tharun208/fix/config_memory 

fix unable to set memory in config
pull/9883/head
Medya Ghazizadeh 2020-12-08 10:29:11 -08:00 committed by GitHub
parent 4a0382fe72 5b8670c4e9
commit 3e670f24e0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/minikube/cmd/config/config.go
View File

@ -92,8 +92,8 @@ var settings = []Setting{
}, },
{ {
name: "memory", name: "memory",
set: SetInt, set: SetString,
validations: []setFn{IsPositive}, validations: []setFn{IsValidDiskSize},
callbacks: []setFn{RequiresRestartMsg}, callbacks: []setFn{RequiresRestartMsg},
}, },
{ {

4
cmd/minikube/cmd/config/set_test.go
View File

@ -38,6 +38,10 @@ func TestSetNotAllowed(t *testing.T) {
if err == nil || err.Error() != "run validations for \"driver\" with value of \"123456\": [driver \"123456\" is not supported]" { if err == nil || err.Error() != "run validations for \"driver\" with value of \"123456\": [driver \"123456\" is not supported]" {
t.Fatalf("Set did not return error for unallowed value: %+v", err) t.Fatalf("Set did not return error for unallowed value: %+v", err)
} }
err = Set("memory", "10a")
if err == nil || err.Error() != "run validations for \"memory\" with value of \"10a\": [invalid disk size: invalid size: '10a']" {
t.Fatalf("Set did not return error for unallowed value: %+v", err)
}
} }
func TestSetOK(t *testing.T) { func TestSetOK(t *testing.T) {