kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #14038 from Sea-n/fix-github 

Use GitHub instead of Github in documents and code comments
pull/14083/head
Medya Ghazizadeh 2022-04-28 14:12:02 -07:00 committed by GitHub
parent b67d897d2d 0fdefd570e
commit 2857186c28
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
34 changed files with 43 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -2,7 +2,7 @@
[![Actions Status](https://github.com/kubernetes/minikube/workflows/build/badge.svg)](https://github.com/kubernetes/minikube/actions)
[![GoReport Widget]][GoReport Status]
[![Github All Releases](https://img.shields.io/github/downloads/kubernetes/minikube/total.svg)](https://github.com/kubernetes/minikube/releases/latest)
[![GitHub All Releases](https://img.shields.io/github/downloads/kubernetes/minikube/total.svg)](https://github.com/kubernetes/minikube/releases/latest)
[![Latest Release](https://img.shields.io/github/v/release/kubernetes/minikube?include_prereleases)](https://github.com/kubernetes/minikube/releases/latest)

2
hack/jenkins/cloud_shell_functional_tests_docker.sh
View File

@ -20,7 +20,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -x

2
hack/jenkins/linux_integration_tests_docker.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e

2
hack/jenkins/linux_integration_tests_docker_arm64.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e
mkdir -p cron && gsutil -qm rsync "gs://minikube-builds/${MINIKUBE_LOCATION}/cron" cron || echo "FAILED TO GET CRON FILES"

2
hack/jenkins/linux_integration_tests_docker_containerd.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e

2
hack/jenkins/linux_integration_tests_docker_containerd_arm64.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e
mkdir -p cron && gsutil -qm rsync "gs://minikube-builds/${MINIKUBE_LOCATION}/cron" cron || echo "FAILED TO GET CRON FILES"

2
hack/jenkins/linux_integration_tests_docker_crio.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e

2
hack/jenkins/linux_integration_tests_docker_crio_arm64.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e
mkdir -p cron && gsutil -qm rsync "gs://minikube-builds/${MINIKUBE_LOCATION}/cron" cron || echo "FAILED TO GET CRON FILES"

2
hack/jenkins/linux_integration_tests_kvm.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e

2
hack/jenkins/linux_integration_tests_kvm_containerd.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e

2
hack/jenkins/linux_integration_tests_kvm_crio.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e

2
hack/jenkins/linux_integration_tests_none.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e

2
hack/jenkins/linux_integration_tests_podman.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e

2
hack/jenkins/linux_integration_tests_virtualbox.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e

2
hack/jenkins/minikube_cross_build_and_upload.sh
View File

@ -15,7 +15,7 @@
# limitations under the License.
# This script builds the minikube binary for all 3 platforms and uploads them.
# This is to done as part of the CI tests for Github PRs
# This is to done as part of the CI tests for GitHub PRs
# The script expects the following env variables:
# ghprbPullId: The pull request ID, injected from the ghpbr plugin.

6
hack/jenkins/minikube_set_pending.sh
View File

@ -15,14 +15,14 @@
# limitations under the License.
# This script creates several Github statuses using the Github API: https://developer.github.com/v3/repos/statuses/
# This is intended to run before the tests start, so the icons show up on the Github PR and block submit until
# This script creates several GitHub statuses using the GitHub API: https://developer.github.com/v3/repos/statuses/
# This is intended to run before the tests start, so the icons show up on the GitHub PR and block submit until
# the tests finish.
# The script expects the following env variables:
# ghprbPullId: The pull request ID, injected from the ghpbr plugin.
# ghprbActualCommit: The commit hash, injected from the ghpbr plugin.
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -eux -o pipefail

2
hack/jenkins/osx_integration_tests_docker.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -e

2
hack/jenkins/osx_integration_tests_hyperkit.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
set -ex

2
hack/jenkins/osx_integration_tests_virtualbox.sh
View File

@ -21,7 +21,7 @@
# MINIKUBE_LOCATION: GIT_COMMIT from upstream build.
# COMMIT: Actual commit ID from upstream build
# EXTRA_BUILD_ARGS (optional): Extra args to be passed into the minikube integrations tests
# access_token: The Github API access token. Injected by the Jenkins credential provider.
# access_token: The GitHub API access token. Injected by the Jenkins credential provider.
OS="darwin"

2
hack/jenkins/release_build_and_upload.sh
View File

@ -22,7 +22,7 @@
# VERSION_MINOR: The minor version of the tag to be released.
# VERSION_BUILD: The build version of the tag to be released.
# BUCKET: The GCP bucket the build files should be uploaded to.
# GITHUB_TOKEN: The Github API access token. Injected by the Jenkins credential provider.
# GITHUB_TOKEN: The GitHub API access token. Injected by the Jenkins credential provider.
set -eux -o pipefail
readonly VERSION="${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_BUILD}"

4
hack/jenkins/release_github_page.sh
View File

@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# This script generates the Github Release page and uploads all the binaries/etc to that page
# This script generates the GitHub Release page and uploads all the binaries/etc to that page
# This is intended to be run on a new release tag in order to generate the github release page for that release
# The script expects the following env variables:
@ -22,7 +22,7 @@
# VERSION_MINOR: The minor version of the tag to be released.
# VERSION_BUILD: The build version of the tag to be released.
# ISO_SHA256: The sha 256 of the minikube-iso for the current release.
# GITHUB_TOKEN: The Github API access token. Injected by the Jenkins credential provider.
# GITHUB_TOKEN: The GitHub API access token. Injected by the Jenkins credential provider.
set -eux -o pipefail
readonly VERSION="${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_BUILD}"

2
hack/jenkins/release_update_releases_json.sh
View File

@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# This script generates the Github Release page and uploads all the binaries/etc to that page
# This script generates the GitHub Release page and uploads all the binaries/etc to that page
# This is intended to be run on a new release tag in order to generate the github release page for that release
# The script expects the following env variables:

2
hack/jenkins/test-flake-chart/compute_flake_rate.sh
View File

@ -39,7 +39,7 @@ CLOSE_ISSUE_THRESHOLD=20
"${DIR}/../installers/check_install_gh.sh" || true
# Get a list of issues from Github and extract only those that look like flake issues.
# Get a list of issues from GitHub and extract only those that look like flake issues.
# Sort by test name for later usage.
EXISTING_ISSUES_LIST=$(mktemp)
gh issue list -L 10000 -s all -A "minikube-bot" -l kind/failing-test \

2
hack/jenkins/test-flake-chart/sync_tests.sh
View File

@ -20,7 +20,7 @@
# flakes or uploads flakes to flake data.
#
# This script expects the following env variables:
# MINIKUBE_LOCATION: The Github location being run on (e.g. master, 11000).
# MINIKUBE_LOCATION: The GitHub location being run on (e.g. master, 11000).
# COMMIT: Commit hash the tests ran on.
# ROOT_JOB_ID: Job ID to use for synchronization.

2
hack/update/kubernetes_version/update_kubernetes_version.go
View File

@ -139,7 +139,7 @@ func main() {
}
data := Data{StableVersion: stable, LatestVersion: latest, LatestVersionMM: latestMM, LatestVersionP0: latestP0}
// Print PR title for Github action.
// Print PR title for GitHub action.
fmt.Printf("Bump Kubernetes version default: %s and latest: %s\n", data.StableVersion, data.LatestVersion)
update.Apply(ctx, schema, data, prBranchPrefix, prTitle, prIssue)

4
pkg/minikube/notify/constants.go
View File

@ -19,11 +19,11 @@ package notify
const (
// GithubMinikubeReleasesURL is the URL of the minikube github releases JSON file
GithubMinikubeReleasesURL = "https://storage.googleapis.com/minikube/releases-v2.json"
// GithubMinikubeBetaReleasesURL is the URL of the minikube Github beta releases JSON file
// GithubMinikubeBetaReleasesURL is the URL of the minikube GitHub beta releases JSON file
GithubMinikubeBetaReleasesURL = "https://storage.googleapis.com/minikube/releases-beta-v2.json"
// GithubMinikubeReleasesAliyunURL is the URL of the minikube github releases JSON file from Aliyun Mirror
GithubMinikubeReleasesAliyunURL = "https://kubernetes.oss-cn-hangzhou.aliyuncs.com/minikube/releases.json"
// GithubMinikubeBetaReleasesAliyunURL is the URL of the minikube Github beta releases JSON file
// GithubMinikubeBetaReleasesAliyunURL is the URL of the minikube GitHub beta releases JSON file
GithubMinikubeBetaReleasesAliyunURL = "https://kubernetes.oss-cn-hangzhou.aliyuncs.com/minikube/releases-beta.json"
)

2
pkg/perf/monitor/github.go
View File

@ -28,7 +28,7 @@ import (
)
// Client provides the context and client with necessary auth
// for interacting with the Github API
// for interacting with the GitHub API
type Client struct {
ctx context.Context
*github.Client

2
site/content/en/docs/contrib/documentation.en.md
View File

@ -16,7 +16,7 @@ In production, the minikube website is served using [Netlify](https://netlify.co
## Small or cosmetic contributions
Use Github's repositories and markdown editor as described by [Kubernetes's general guideline for documentation contributing](https://kubernetes.io/docs/contribute/start/#submit-a-pull-request)
Use GitHub's repositories and markdown editor as described by [Kubernetes's general guideline for documentation contributing](https://kubernetes.io/docs/contribute/start/#submit-a-pull-request)
## Local documentation website

2
site/content/en/docs/contrib/external-packages.en.md
View File

@ -11,6 +11,6 @@ Chocolatey is a software package manager for Windows that wraps installers, exec
* Chocolatey community is the maintainer of the Minikube package. Latest approved version is available for [Install, Upgrade and Uninstall](https://community.chocolatey.org/packages/Minikube/).
* Get the [current status](https://gist.github.com/choco-bot/a14b1e5bfaf70839b338eb1ab7f8226f) of the Chocolatey pacakge.
* Minikube Chocolatey update script on [Github](https://github.com/chocolatey-community/chocolatey-coreteampackages/tree/master/automatic/minikube).
* Minikube Chocolatey update script on [GitHub](https://github.com/chocolatey-community/chocolatey-coreteampackages/tree/master/automatic/minikube).
**Note: Windows support is limited to 64bit operating systems.**

4
site/content/en/docs/contrib/releasing/binaries.md
View File

@ -66,7 +66,7 @@ sh hack/tag_release.sh 1.<minor>.<patch>
## Build the Release
This step uses the git tag to publish new binaries to GCS and create a github release:
This step uses the git tag to publish new binaries to GCS and create a GitHub release:
* Navigate to the minikube "Release" jenkins job
* Ensure that you are logged in (top right)
@ -85,7 +85,7 @@ After job completion, click "Console Output" to verify that the release complete
The release script updates https://storage.googleapis.com/minikube/releases.json - which is used by the minikube binary to check for updates, and is live immediately.
minikube-bot will also send out a PR to merge this into the tree. Please merge this PR to keep GCS and Github in sync.
minikube-bot will also send out a PR to merge this into the tree. Please merge this PR to keep GCS and GitHub in sync.
## Package managers which include minikube

2
site/content/en/docs/contrib/tests.en.md
View File

@ -148,7 +148,7 @@ Steps:
makes sure minikube start respects the HTTPS_PROXY environment variable and works with custom certs
a proxy is started by calling the mitmdump binary in the background, then installing the certs generated by the binary
mitmproxy/dump creates the proxy at localhost at port 8080
only runs on Github Actions for amd64 linux, otherwise validateStartWithProxy runs instead
only runs on GitHub Actions for amd64 linux, otherwise validateStartWithProxy runs instead
#### validateAuditAfterStart
makes sure the audit log contains the correct logging after minikube start

2
site/content/en/docs/tutorials/continuous_integration.md
View File

@ -23,7 +23,7 @@ For any platform not yet listed we are looking for your help! Please file Pull R
|---|---|--|
| [Prow](https://github.com/kubernetes/test-infra/tree/master/prow) | [Yes](https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes/minikube) ✔️ | [![Prow](https://prow.k8s.io/badge.svg?jobs=pull-minikube-build)](https://prow.k8s.io/?job=pull-minikube-build) |
| [Google Cloud Build](https://cloud.google.com/cloud-build/) | [Yes](https://github.com/minikube-ci/examples/blob/master/gcb.md) ✔️ | [![cloud build status](https://storage.googleapis.com/minikube-ci-example/build/working.svg)](https://pantheon.corp.google.com/cloud-build/dashboard?project=k8s-minikube) |
| [Github](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-continuous-integration) | [Yes](https://github.com/minikube-ci/examples/blob/master/.github/workflows/minikube.yml) ✔️ | [![Github](https://github.com/minikube-ci/examples/workflows/Minikube/badge.svg)](https://github.com/minikube-ci/examples/actions) |
| [GitHub](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-continuous-integration) | [Yes](https://github.com/minikube-ci/examples/blob/master/.github/workflows/minikube.yml) ✔️ | [![GitHub](https://github.com/minikube-ci/examples/workflows/Minikube/badge.svg)](https://github.com/minikube-ci/examples/actions) |
| [Azure Pipelines](https://azure.microsoft.com/en-us/services/devops/pipelines/) | [Yes](https://github.com/minikube-ci/examples/blob/master/azure-pipelines.yml) ✔️ | [![Azure Pipelines](https://dev.azure.com/medyagh0825/minikube-ci/_apis/build/status/examples?api-version=5.1-preview.1)](https://dev.azure.com/medyagh0825/minikube-ci/_build)
| [Travis CI](https://travis-ci.com/) | [Yes](https://github.com/minikube-ci/examples/blob/master/.travis.yml) ✔️ | [![Travis CI](https://travis-ci.com/minikube-ci/examples.svg?branch=master)](https://travis-ci.com/minikube-ci/examples/) |
| [CircleCI](https://circleci.com/) | [Yes](https://github.com/minikube-ci/examples/blob/master/.circleci) ✔️ | [![CircleCI](https://circleci.com/gh/minikube-ci/examples.svg?style=svg)](https://circleci.com/gh/minikube-ci/examples) |

10
site/content/en/docs/tutorials/setup_minikube_in_github_actions.md
View File

@ -1,13 +1,13 @@
---
title: "Setup minikube as CI step in github actions"
linkTitle: "Minikube in Github Actions"
title: "Setup minikube as CI step in GitHub Actions"
linkTitle: "Minikube in GitHub Actions"
weight: 1
date: 2020-06-02
description: >
How to use minikube in github actions for testing your app
How to use minikube in GitHub Actions for testing your app
---
To install and start a minikube cluster, add the following step to your [github action workflow](https://help.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow).
To install and start a minikube cluster, add the following step to your [GitHub Actions workflow](https://help.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow).
```yaml
steps:
@ -16,7 +16,7 @@ To install and start a minikube cluster, add the following step to your [github
uses: medyagh/setup-minikube@master
```
for more information see github actions marketplace [setup-minikube]( https://github.com/marketplace/actions/setup-minikube).
for more information see GitHub Actions marketplace [setup-minikube](https://github.com/marketplace/actions/setup-minikube).
## Example: build image & deploy to minikube on each PR

2
test/integration/functional_test.go
View File

@ -611,7 +611,7 @@ func validateStartWithProxy(ctx context.Context, t *testing.T, profile string) {
// validateStartWithCustomCerts makes sure minikube start respects the HTTPS_PROXY environment variable and works with custom certs
// a proxy is started by calling the mitmdump binary in the background, then installing the certs generated by the binary
// mitmproxy/dump creates the proxy at localhost at port 8080
// only runs on Github Actions for amd64 linux, otherwise validateStartWithProxy runs instead
// only runs on GitHub Actions for amd64 linux, otherwise validateStartWithProxy runs instead
func validateStartWithCustomCerts(ctx context.Context, t *testing.T, profile string) {
defer PostMortemLogs(t, profile)
err := startProxyWithCustomCerts(ctx, t)