From 277a331f6b96dc038ef8ca3b38fd5e97b5e49ff5 Mon Sep 17 00:00:00 2001 From: Thomas Stromberg Date: Thu, 23 Apr 2020 12:38:05 -0700 Subject: [PATCH] Skip if empty, turn inability to poll other clusters into a warning --- pkg/minikube/machine/cache_images.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pkg/minikube/machine/cache_images.go b/pkg/minikube/machine/cache_images.go index 94702cbc07..e677e5e58d 100644 --- a/pkg/minikube/machine/cache_images.go +++ b/pkg/minikube/machine/cache_images.go @@ -158,6 +158,10 @@ func needsTransfer(imgClient *client.Client, imgName string, cr cruntime.Manager // CacheAndLoadImages caches and loads images to all profiles func CacheAndLoadImages(images []string) error { + if len(images) == 0 { + return nil + } + // This is the most important thing if err := image.SaveToDir(images, constants.ImageCacheDir); err != nil { return errors.Wrap(err, "save to dir") @@ -192,7 +196,7 @@ func CacheAndLoadImages(images []string) error { status, err := Status(api, m) if err != nil { - glog.Errorf("error getting status for %s: %v", pName, err) + glog.Warningf("error getting status for %s: %v", pName, err) failed = append(failed, pName) continue } @@ -200,7 +204,7 @@ func CacheAndLoadImages(images []string) error { if status == state.Running.String() { // the not running hosts will load on next start h, err := api.Load(m) if err != nil { - glog.Errorf("Failed to load machine %q: %v", m, err) + glog.Warningf("Failed to load machine %q: %v", m, err) failed = append(failed, pName) continue }