address review comments

pull/8863/head
Medya Gh 2020-07-28 10:53:36 -07:00
parent 1eaa6b4306
commit 1f5fc25ae0
1 changed files with 12 additions and 1 deletions

View File

@ -17,8 +17,11 @@ limitations under the License.
package config
import (
"fmt"
"github.com/spf13/cobra"
"k8s.io/minikube/pkg/addons"
"k8s.io/minikube/pkg/minikube/constants"
"k8s.io/minikube/pkg/minikube/exit"
"k8s.io/minikube/pkg/minikube/out"
)
@ -42,7 +45,15 @@ var addonsEnableCmd = &cobra.Command{
exit.WithError("enable failed", err)
}
if addon == "dashboard" {
out.T(out.Tip, "Some dashboard features require the 'metrics-server' add-on. For full features consider enabling metrics-server addon.")
tipProfileArg := ""
if ClusterFlagValue() != constants.DefaultClusterName {
tipProfileArg = fmt.Sprintf(" -p %s", ClusterFlagValue())
}
out.T(out.Tip, `Some dashboard features require the metrics-server addon. To enable all features please run:
minikube{{.profileArg}} addons enable metrics-server
`, out.V{"profileArg": tipProfileArg})
}