kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #12127 from spowelljr/fixSkaffoldTets 

Fix `TestSkaffold` on Windows
pull/12131/head
Medya Ghazizadeh 2021-08-05 01:20:49 -07:00 committed by GitHub
parent 923455d7ca f089c7f8e1
commit 1eebdca5bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/integration/skaffold_test.go
View File

@ -81,7 +81,11 @@ func TestSkaffold(t *testing.T) {
} }
oldPath := os.Getenv("PATH") oldPath := os.Getenv("PATH")
os.Setenv("PATH", fmt.Sprintf("%s:%s", filepath.Dir(abs), os.Getenv("PATH"))) pathSeparator := ":"
if runtime.GOOS == "windows" {
pathSeparator = ";"
}
os.Setenv("PATH", fmt.Sprintf("%s%s%s", filepath.Dir(abs), pathSeparator, os.Getenv("PATH")))
// make sure 'docker' and 'minikube' are now in PATH // make sure 'docker' and 'minikube' are now in PATH
for _, binary := range []string{"minikube", "docker"} { for _, binary := range []string{"minikube", "docker"} {