From 1ba9792419b540bcd4fd5708aaa500ad52663265 Mon Sep 17 00:00:00 2001
From: Steven Powell <spowellgrr@gmail.com>
Date: Wed, 21 Sep 2022 16:06:21 -0700
Subject: [PATCH] fix update check logic

---
 cmd/minikube/cmd/start.go     | 7 ++-----
 pkg/minikube/notify/notify.go | 6 ++++++
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go
index 3a9f6ca313..6eb57cf23e 100644
--- a/cmd/minikube/cmd/start.go
+++ b/cmd/minikube/cmd/start.go
@@ -148,11 +148,8 @@ func runStart(cmd *cobra.Command, args []string) {
 	displayVersion(version.GetVersion())
 	go download.CleanUpOlderPreloads()
 
-	// No need to do the update check if no one is going to see it
-	if !viper.GetBool(interactive) || !viper.GetBool(dryRun) {
-		// Avoid blocking execution on optional HTTP fetches
-		go notify.MaybePrintUpdateTextFromGithub()
-	}
+	// Avoid blocking execution on optional HTTP fetches
+	go notify.MaybePrintUpdateTextFromGithub()
 
 	displayEnviron(os.Environ())
 	if viper.GetBool(force) {
diff --git a/pkg/minikube/notify/notify.go b/pkg/minikube/notify/notify.go
index 00858de862..c67371c57e 100644
--- a/pkg/minikube/notify/notify.go
+++ b/pkg/minikube/notify/notify.go
@@ -119,6 +119,12 @@ func shouldCheckURLVersion(filePath string) bool {
 	if !viper.GetBool(config.WantUpdateNotification) {
 		return false
 	}
+	if !viper.GetBool("interactive") {
+		return false
+	}
+	if viper.GetBool("dry-run") {
+		return false
+	}
 	lastUpdateTime := timeFromFileIfExists(filePath)
 	return time.Since(lastUpdateTime).Hours() >= viper.GetFloat64(config.ReminderWaitPeriodInHours)
 }